Checkout Tools
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge r1788032, r1788033, r1783764, r1707512, r1783770 from trunk:

Save a few bytes in the conf pool.

'push_item' and 'add_alt' already duplicate their parameters, so we can safely use the temp_pool here.

Use 'ap_cstr_casecmp' to simplify code.

Remove useless case. We know that to can not be NULL at this point.

Follow up to r1772812: update APLOGNO().

* modules/ssl/ssl_engine_kernel.c: Constify the ssl_hook_Fixup_vars array itself.

winnt/service: each log message should use its own APLOGNO.

Submitted by: jailletc36, ylavic, jorton, ylavic

Reviewed by: jailletc36, covener, jim

  1. … 5 more files in changeset.
Merge r1787525, r1787553, r1788451 from trunk:

Add IndexOptions UseOldDateFormat

*) mod_autoindex: Add IndexOptions UseOldDateFormat to allow the date

format from 2.2 in the Last Modified column. PR60846.

PR34014 / r903052 changed date format for autoindex

Submitted By: Hank Ibell <hwibell gmail.com>

update comments post-r1787525

no strncasecmp because flag has no value

Submitted by: covener

Reviewed by: covener, jim, druggeri

  1. … 5 more files in changeset.
Merge r1705983 from trunk:

Fix some style issues on files that can easily be synch'ed with 2.4.x

Submitted by: jailletc36

Reviewed/backported by: jim

  1. … 17 more files in changeset.
Merge r1701436 from trunk:

allow autoindex w/o mod_dir/mod_mime setting the DIR_MAGIC_TYPE.

Submitted by: covener

Reviewed/backported by: jim

  1. … 3 more files in changeset.
Backport r1690137.

Doc and comment fix only

  1. … 11 more files in changeset.
Merge r1648201 from trunk:

Add class attributes for empty descriptions

Submitted by: druggeri

Reviewed/backported by: jim

  1. … 3 more files in changeset.
Merge r1597642, r1608999, r1605207, r1610366, r1610353, r1611871 from trunk:

Rename module name in doxygen + partly revert r832442 which skipped doxygen doc generation for 'mod_watchdog.h'

s/apr_pstrndup/apr_pstrmemdup/ to save a few cycles

Use ap_remove_input_filter_byhandle instead of duplicating the code.

Remove some 'register' in variable declaration.

Remove some 'register' in variable declaration.

Save a few cycles by calling 'apr_isalnum' instead of 'apr_isalpha' and 'apr_isdigit'.

Do not use deprecated define.

No change in generated code because MODULE_MAGIC_NUMBER is defined as:

#define MODULE_MAGIC_NUMBER MODULE_MAGIC_NUMBER_MAJOR

Submitted by: jailletc36

Reviewed/backported by: jim

  1. … 12 more files in changeset.
Merge r1491221, r1491479, r1491538 from trunk:

Reduce stack usage, 32 bytes are enough here, no need to take 8k in the stack. (19 would be enough, but be safe...)

Use the size of the buffer as opposed to MAX_STRING_LEN.

Reduce stack usage, 32 bytes are enough here, no need to

take 8k in the stack. (19 would be enough, but be safe...)

Use the size of the buffer as opposed to MAX_STRING_LEN.

Followup to r1491221+r1491479: change consistently

the same code used in another place in the same file.

Submitted by: jailletc36, minfrin, rjung

Reviewed/backported by: jim

  1. … 2 more files in changeset.
Merge r1407459, r1407460, r1419781, r1418524, r1401448, r1405407, r1405973, r1419726, r1418769, r1417197 from trunk:

remove warning:

mod_remoteip.c:404:38: warning: data argument not used by format string [-Wformat-extra-args]

It's a hack, but maintain the orig hack ;)

Remove warnings

mod_speling.c:400:41: warning: data argument not used by format string [-Wformat-extra-args]

r->uri, nuri, ref);

mod_speling.c:508:53: warning: data argument not used by format string [-Wformat-extra-args]

r->uri, candidates->nelts, ref);

Use 'apr_is_empty_table()' instead of testing against 'apr_table_elts(...)->nelts'

Use ap_rputs instead of ap_rvputs where applicable.

No need to apr_pstrdup things here, 'apr_socket_accept_filter' already makes it own copy.

Not compiled nor tested as on my system APR_HAS_SO_ACCEPTFILTER is set to 0.

revert r1401448 and add a comment on why there's a bewildering copy

of args passed to apr_socket_accept_filter()

cppCheck: kill two warnings about incorrect printf parameters.

'worker_thread_count' is unsigned

cppCheck: same expression on both side of '|'.

Fix it the same way other messages are managed in the function.

Fix a few 'too many arguments for format' warnings

cppCheck: kill a unread variable warning

Submitted by: jim, jailletc36, jailletc36, jailletc36, trawick, jailletc36, jailletc36, sf, jailletc36

Reviewed/backported by: jim

  1. … 13 more files in changeset.
Merge r1337344, r1378178, r1397636, r1398025, r1398040, r1398481, r1407004, r1407006, r1407088, r1407528 from trunk:

* support/suexec.c: Add gcc format-string attributes to logging

functions.

(main): Always print uid/gid as unsigned long, and cast to avoid

warnings (which somewhat defeats the point of the format string

attrs, but is necessary since the size of gid/uid varies).

remove an unnecessary check in a nest loop of ap_create_environment()

s/;;/;/

No need to test for NULL before calling apr_pstrdup.

No need it apr_pcalloc here, the memory is fully initialized the line just after

cppCheck: unreadVariable - 'serviceFlag' is not used in the function, so remove it

Remove unused code. "Next week" hasn't happened in the last 10 years or so.

log client error at level debug, log broken Host header value

remove some more old unused code

remove obsolete comment from 1.3 days

Submitted by: jorton, pqf, jailletc36, jailletc36, jailletc36, jailletc36, sf, sf, sf, sf

Reviewed/backported by: jim

  1. … 16 more files in changeset.
Various code cleanup to avoid compiler, cppcheck, or clang warnings:

modules/filters/mod_charset_lite.c: Remove dead assignments

modules/filters/mod_include.c: likewise

modules/metadata/mod_usertrack.c: likewise

modules/proxy/mod_proxy_ftp.c: likewise

modules/ssl/ssl_engine_pphrase.c: likewise

modules/proxy/mod_proxy_balancer.c: likewise;

Remove NULL check that can never happen

modules/proxy/proxy_util.c: Axe NULL-check that can never happen and if it

would, it would just mask another bug

os/unix/unixd.c: likewise

modules/http/http_filters.c: Remove sub-condition that is always true

modules/lua/mod_lua.c: Add default cases to switch statements

modules/generators/mod_autoindex.c: Unsigned value can never be < 0

server/util_expr_eval.c: Fix compiler warnings with VC and on OS2

  1. … 12 more files in changeset.
Backport r1209766, r1210252, r1210284:

Add lots of unique tags to error log messages

ssl_util.c: Downgrade some dynamic locking messages from level DEBUG

to TRACE1-3

  1. … 164 more files in changeset.
rollback recent autoindex changes (1204355:1204306)

  1. … 5 more files in changeset.
Merge r1204341 from trunk:

PR51471: IndexIgnore doesn't work in DirectoryMatch.

  1. … 1 more file in changeset.
Merge r1204307 from trunk:

PR39923: Allow AddDescription to work with absolute filesystem paths,

by not adding "*/" to their prefix (intended for relative paths)

  1. … 1 more file in changeset.