mod_auth_basic.c

Checkout Tools
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge r1749402, r1656549, r1840776, r1800126, r1817131, r1834226 from trunk:

Style only

Be more consistent:

- add space between (if|while) and \(

- place of 'break ' statement

Fix cut and paste typo in error message + remove empty lines to be consistent

follow-up to r1656549.

Instead of logging a password (which is not a good practice), clarify the associated message

* Silence compiler warning

Be less tolerant when parsing the credencial for Basic authorization. Only spaces should be accepted after the authorization scheme. \t are also tolerated.

The current code accepts \v and \f as well.

The same behavior is already used in 'ap_get_basic_auth_pw()' which is mostly the same function as 'get_basic_auth()'.

Function used as 'apr_reslist_destructor' when calling 'apr_reslist_create()' should have the following prototype:

apr_status_t (*apr_reslist_destructor)(void *resource, void *params, apr_pool_t *pool);

Submitted by: jailletc36, rpluem, jailletc36, jailletc36

Reviewed by: jailletc36, minfrin, jim

  1. … 6 more files in changeset.
Merge r1756038 from trunk:

Fix spelling in comments and text files.

No functional change.

PR 59990

Submitted by: rjung

Reviewed/backported by: jim

  1. … 72 more files in changeset.
Merge r1716940, r1717086 from trunk:

Use 'ap_pbase64decode' to simplify code.

Silent a sparse Warning.

cid->ecb->lpszLogData can not be NULL.

It is defined in mod_isapi.h as:

typedef struct EXTENSION_CONTROL_BLOCK {

...

char lpszLogData[80];

...

Submitted by: jailletc36

Reviewed/backported by: jim

  1. … 3 more files in changeset.
Merge r1629440, r1629441, r1681424, r1681440, r1681685 from trunk:

Style (mostly indent)

remove a useless local variable initialization

More style

Constify + save a few bytes in conf pool (+ some minor space adjustments)

Save a few bytes in conf pool and axe a function that duplicates 'ap_set_string_slot'

Save a few bytes in conf pool

Submitted by: jailletc36

Reviewed/backported by: jim

  1. … 5 more files in changeset.
Merge r1638072 from trunk:

mod_auth_basic: Fix comment mentioning 403 instead of 401.

Submitted by: jkaluza

Reviewed/backported by: jim

  1. … 2 more files in changeset.
Merge r1611978, r1612068 from trunk:

Add missing APLOGNO.

Refactor to keep APLOGNO on the same line as ap_log_error, when applicable.

Add missing APLOGNO.

Refactor some lines to keep APLOGNO on the same line as ap_log_error, when applicable.

Split lines longer than 80.

Improve alignment.

Submitted by: jailletc36

Reviewed/backported by: jim

  1. … 18 more files in changeset.
Add AuthBasicUseDigestAlgorithm directive to allow migration of

passwords from digest to basic authentication.

Proposed by: chrisd

Reviewed by: jim, rjung

Backport of r1514064 from trunk.

  1. … 6 more files in changeset.
Merge r1406068, r1425777, r1427546, r1462643, r1487530, r1493330 from trunk:

Replace duplicate log tags

Check that AsyncRequestWorkerFactor is not negative

PR :54254

Submitted by: Jackie Zhang <jackie qq zhang gmail com>

remove unneeded include statements

Name pool + concat string at compile time when possible

* modules/filters/mod_ratelimit.c (rate_limit_filter): Log the error

code.

Correct typo in error message

Submitted by: sf, jailletc36, jorton, jailletc36

Reviewed/backported by: jim

  1. … 9 more files in changeset.
Merge r1457471, r1457504, r1462266, r1468581 from trunk:

mod_auth_basic: Add a generic mechanism to fake basic authentication

using the ap_expr parser. This allows the administrator to construct

their own username and password for basic authentication based on their

needs. Alternative fix for PR52616.

Remove the Authorization header should either the username or the password

resolve to an empty string.

* Inherit providers during merging

mod_auth_basic: Allow AuthBasicFake to be switched off for an URL space.

Submitted by: minfrin, rpluem, minfrin

Reviewed/backported by: jim

  1. … 9 more files in changeset.
Backport r1209766, r1210252, r1210284:

Add lots of unique tags to error log messages

ssl_util.c: Downgrade some dynamic locking messages from level DEBUG

to TRACE1-3

  1. … 164 more files in changeset.