Checkout Tools
  • last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
On win32, we must never, never close the parent's copy of the

child's read end for a reliable piped logger. The child runs

and manages it's own logs, and even if the parent did instead,

the mpm would be adjusted to pass down the child write ends

without read ends to the pipes, so this forever makes no sense.

Backport: r607666

Remove existing showstopper

  1. … 1 more file in changeset.
Merge r580437 from trunk:

Share a single write-pipe handle for piped stderr logging, this

prevents an extra logging process from hanging around after the

initial config-phase.

Reviewed by: rpluem, wrowe

Submitted by: wrowe

Reviewed by: jim

  1. … 1 more file in changeset.
Backport applied

  1. … 2 more files in changeset.
server/log.c (log_error_core): For APLOG_DEBUG on Unix, if __FILE__

is an absolute path (as in a VPATH build), just log the basename.

Submitted by: jorton

Backport: r105258

Reviewed by: wrowe, trawick, rpluem

  1. … 1 more file in changeset.
Finish commit r570307, with some play-by-play commentary to

match trunk.

log core: Fix issue which could cause piped loggers to be orphaned

and never terminate after a graceful restart. PR 40651. [Joe Orton,

Ruediger Pluem]

log core: fix the new piped logger case where we couldn't connect

the replacement stderr logger's stderr to the NULL stdout stream.

Continue in this case, since the previous alternative of no error

logging at all (/dev/null) is far worse. [William Rowe]

disambiguate an error message to diagnose future error reports

Backport: 452431, 568326, 568322

  1. … 2 more files in changeset.
update license header text
  1. … 314 more files in changeset.
Revert 395235, the major copyright fubar by me.

  1. … 697 more files in changeset.
Update the last year of Copyright for the 2.0.x branch.

  1. … 696 more files in changeset.
from trunk, backport ap_log_cerror(), along with some helpful uses

of it

Reviewed by: stoddard, wrowe

  1. … 5 more files in changeset.
Merge r170441, r170573, r170719 from trunk:

* server/log.c (piped_log_spawn): Return the APR error code,

as expected by piped_log_maintenance (and fixing "Unknown

error" messages in error path there).

(ap_open_piped_log): Expect an APR error code.

* server/log.c (ap_open_piped_log): Remove errno handling.

* server/log.c (piped_log_spawn): Don't leak an fd for each


Reviewed by: jorton, trawick, wrowe

  1. … 2 more files in changeset.
merge this fix from trunk:

Prevent hangs of child processes when writing to piped loggers at

the time of graceful restart.

PR: 26467

Reviewed by: jorton, pquerna

  1. … 3 more files in changeset.
merge this fix from trunk:

fix minor annoyance on z/OS: __FILE__ is set to

"./foo.c" instead of simply "foo.c", so filter

out all but the basename before logging it with

debug messages

Reviewed by: pquerna, wrowe

Update copyright year to 2005 and standardize on current copyright owner line.

  1. … 483 more files in changeset.
general property cleanup

  1. … 720 more files in changeset.