Checkout Tools
  • last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
general property cleanup

  1. … 847 more files in changeset.
Add in suggested patch for AuthDigestRealmSeed issue

  1. … 10 more files in changeset.
Add fatal exception hook for running diagnostic code after a


Reviewed by: Bill Stoddard, Mads Toftum

  1. … 7 more files in changeset.
take Brad's lead and export some new API functions from httpd on


Get ap_strtol playing nicely on Windows and AIX

  1. … 2 more files in changeset.
Apply a stricter check to the request line syntax, in order to prevent

arbitrary user input to end up (unescaped) in the access_log and error_log

files. Until now, garbage could be injected to spoof accesses to nonexistent

(or inaccessible) resources -- of course without the client actually

getting access to them.

Now anything but whitespace following the "<method> <url> HTTP/x.y" request

line is disallowed, and special characters in the request are escaped

in the log.

  1. … 6 more files in changeset.
Namespace protect getline() and get_chunk_size().

Export ap_getline() and ap_get_chunk_size().


Obtained from:

Submitted by:

Reviewed by:

  1. … 2 more files in changeset.
Export ap_uuencode

  1. … 1 more file in changeset.
Add ap_custom_response to the exports file

My bad, sorry FirstBill. Since the other raw reg* fns aren't exported

regerror does not belong here.

Pick up a few more symbols. Thanks Bill Rowe.

Export a couple more symbols.

Add a couple of symbol exports.

Export ap_configtestonly. Needed for mod_perl on AIX.

Submitted By: Paul Reder

NT does not handle spaces in service names well.

Attached are two patches to correct how Apache

deals with this.

The first patch adds the util function

ap_remove_spaces and exports it on all platforms.

The second patch changes some service and registry

functions to make use of this new function.

NT developers of Apache admin modules could use

some functionality from registry.c.

The third patch exports four ap_x functions from


Submitted by: Keith Wannamaker

Reviewed by: Bill Stoddard

  1. … 8 more files in changeset.
More AIX DSO tweaking. Apache's AIX DSO emulation code does not work with

64 bit builds of Apache. Use native DSO support with AIX V4.3 and later.

Native AIX DSO support is broken prior to 4.3, so we need to continue

using Apache's version on pre 4.3 releases of AIX

PR: 5309

Submitted by: Chris Graham (

Reviewed by: Bill Stoddard

  1. … 2 more files in changeset.
Add a symbol required for fast_cgi on AIX.

To get mod_perl running as a DSO under AIX two additional functions

must be exported from httpd. This was missed as no standard module is

using these symbols.

Submitted by: Jens-Uwe Mager <>

Clean up the base64 and SHA1 additions and make sure they are

represented in the ApacheCore.def, ApacheCoreOS2.def, and httpd.exp


I am very unhappy with the implementation assumptions between

ap_validate_password and the various encoding routines, like the

length of an encoded password never being greater than 120 characters,

but I have no time to fix them right now. Not to mention all the other

usages of magic numbers with no explanation. Yuck.

  1. … 16 more files in changeset.
Add a couple of missed exports.

In order for DSO modules to be able to use the bundled XML functions on AIX

they need to be listed here.

back out Ken's recent patch, I'm vetoing it:

- it adds a new API which can only be implemented through O(n^2) methods

- it does not solve the problem in a way which is compatible with existing


- We went over this, and other solutions were presented. The current

situation is already O(n^2), so I'm not just vetoing this based on that

-- I'm vetoing this because I don't want another O(n^2) API embedded

into the code. A solution which would retain more compatibility with

existing modules would add an "table *vary" to the request_rec, and

then modify ap_send_http_header to merge the contents of the table

and any "Vary" entry in r->headers_out. This can be done with a simple

sort operation.

  1. … 10 more files in changeset.

Treat the Vary response header field specially; change the

modules that touch it to use a new routine that only adds a

token if it isn't already present. O(n^2) behaviour as

Dean points out, but absent set/atom operations it seems

a reasonable stopgap for 1.3.7.

PR: 4118 (previously closed with 'use "force-no-vary"')

Reviewed by: Ken Coar

  1. … 8 more files in changeset.
Fix broken AIX shared module build. The httpd.exp file was not up to date.

Also install the httpd.exp file on a 'make install' to allow apxs builds

against it on AIX. apxs is still completely broken on AIX. It

generates bogus -bI and -bE stuff. Working on fix for that.

  1. … 1 more file in changeset.
Force regerror() to be linked into the core so DSOs can use the core's regex

library. regerror() is needed by PHP3.

  1. … 3 more files in changeset.
Replace regexec() calls with calls to a new API stub function ap_regexec().

This solves problems with DSO modules which use the regex library.

Submitted by: Jens-Uwe Mager <>, Ralf S. Engelschall

Reviewed by: Ralf S. Engelschall

  1. … 11 more files in changeset.

Add a definition so that mod_perl can be built/linked as a


Submitted by: Paul Reder <>

Reviewed by: Ken Coar

Added ap_sub_req_method_uri() for doing a subrequest with a method

other than GET, and const'd the definition of method in request_rec.

Submitted by: Greg Stein <>

Reviewed by: Roy Fielding, Dean Gaudet, Doug MacEachern

  1. … 8 more files in changeset.

Bloody line-ending rubbish..

  1. … 1 more file in changeset.
Refix the entity tag comparisons for If-Range, If-Match and If-None-Match.

Comparisons need to be case sensitive and in all but one case (cache update)

need to be strong comparisons, taking into account the possibility that

any of the current Etag or the one(s) received from the client may be weak.

Changed name of ap_find_list_item() to ap_size_list_item() to be consistent

with other find routines and added new (simple) ap_find_list_item(), whose

implementation will eventually be replaced with something more efficient.

PR: 2065, 3657

Submitted by: Roy Fielding, Ken Coar, Dean Gaudet

  1. … 6 more files in changeset.