Checkout Tools
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Changeset 79486 is being indexed.

Bug Fixes:

- gzip -cdq requires at least 4k of a partial gzipped file, we

were sending it only 1k, and it wouldn't produce any output. But raising

HOWMANY to 4k has implications on the performance of the (lame) ascmagic()

code. So ascmagic() cheats and only looks at 1k (the previous HOWMANY

setting)

- use spawn_child() interface to avoid a resource leak (zombie

child); I don't think even worked on WIN32 before, but it might now... I

special case and use spawnvp() on WIN32.

- use pfopen()/popenf() to avoid resource leaks

Cleanups:

- no need to test return from palloc since it never returns NULL

- ensure all log messages include the module name

- Some cases were assuming that aplog_error was a never returning

function. Deal gracefully by propagating an error code back

up the call chain.

- remove some useless code in fsmagic() -- we don't use lstat(), we

use stat() so the only possibility where we'll get S_IFLNK is

if it's a broken symlink.

- for various errors just DECLINE rather than cause the phase to abort

early (a lesson we're learning from all the M_PUT changes we've

had recently)

PR: 1205

Obtained from:

Submitted by:

Reviewed by: Jim Jagielski, Martin Kraemer

  1. … 1 more file in changeset.
The indentation was all whacky and there were various bits not in our

coding style. Fix it up. (There's no code changes in this rev.)

Added apache EMail address to all Apache License Headers

  1. … 88 more files in changeset.
Insert APLOG_NOERRNO where appropriate.

Remove needless errstr buffers, can just pass it all to aplog_errno.

Add __attribute__((format(printf,5,6))) to aplog_error so that we get

useful -Wall warnings about bad printf lists to aplog_error.

#define __attribute__(__x) to be nothing on non-__GNUC__ compilers.

Clean up use of TRANS in http_log.[ch].

  1. … 28 more files in changeset.
PR:

Okay, enough damage for tonight. If any of this is wrong, someone please

scream. If not, I'll try and do some more tomorrow; I'm just being extra careful.

  1. … 4 more files in changeset.
Convert log_*() to aplog_error().

Wow! This module wins the prize for most calls to error...

PR:

Typo!

remove unreachable code

Add the post read-request phase placeholder to the structures

in the standard modules.

PR: 1009

  1. … 33 more files in changeset.
added child_exit hook for modules

PR:

Obtained from:

Submitted by: Doug MacEachern

Reviewed by: Dean Gaudet

  1. … 37 more files in changeset.
Remove header files that are already included by other headers.

This avoids problems on some OSes that can't handle the same header

being included twice.

Reviewed by: Brian Behlendorf, Dean Gaudet

Submitted by:

Obtained from:

fix seg fault if there is an error decompressing

PR: 904

Submitted by: Martin Kraemer <Martin.Kraemer@mch.sni.de>

Reviewed by: Dean Gaudet

  1. … 1 more file in changeset.
Added missing header-parser entry in module structure.

Submitted by: Martin Kraemer

Added child_init method.

  1. … 38 more files in changeset.
Files often compile better when statements are terminated by semicolons.

Reviewed by:

Submitted by:

Obtained from:

Use STD{IN,OUT,ERR}_FILENO as dictated by posix.1.

Submitted by: Stanley Gambarin <stanleyg@cs.bu.edu>

Reviewed by: Dean Gaudet

  1. … 2 more files in changeset.
General mod_mime_magic cleanup.

The fixes include:

- change DEBUG define to MIME_MAGIC_DEBUG to avoid namespace

collisions.

- change fprintf(stderr, ...) into log_printf

- remove '\n's from log_printf calls

- couple of possible buffer overflow cleanups

- minor spelling cleanup

Reviewed by: Ian Kluft, Jim Jagielski

Submitted by:

Obtained from:

-Wall cleanup

  1. … 5 more files in changeset.
Added mod_mime_magic.

Submitted by: Ian Kluft <ikluft@cisco.com>

    • -0
    • +2597
    ./mod_mime_magic.c
  1. … 7 more files in changeset.