Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates
* modules/generators/mod_cgid.c (get_cgi_pid): Fix test for pid=0.

(cgid_handler): Remove duplicated test for pid=0 here added in


Backport proposal r1879832.

[skip ci]


[skip ci]

Consider case insensitive filessystems

Consider case insensitive filessystems and thus choose a new non conflicting

name for the directory to store CHANGES entries.

*) mod_http2:

Fixes <>:

"LimitRequestFields 0" now disables the limit, as documented.

Fixes <>:

Do not count repeated headers with same name against the field

count limit. The are merged internally, as if sent in a single HTTP/1 line.

Can we have mercy with people working on case-preserving file systems?

Test VPATH build in Travis, update docs.

Add a new way to document changes

* Define the update-changes target to merge the change files

from the changes directory to the top of the CHANGES file and remove

them afterwards. If a Subversion binary was found during configure try

to svn rm them otherwise just delete them.

* Search for the Subversion binary.

* acinclude.m4: Set the corresponding Makefile variable for the Subversion


* README.CHANGES: New file to document the new approach.

Actually clear the cache for the worker MPM (missed in r1879757).

Try removing the cached ~/perl5 to reset the broken worker

MPM test job.

* Propose
The mod_watchdog change is not user-visible (AFAIK) so should not be in CHANGES.

Merge r1879381, r1879382, r1879383, r1879384 from trunk:

* Let dump_brigade print the length of the brigade

* Create helper function isValidAddress to determine if an address is valid [skip ci]

* Use isValidAddress when dumping buckets [skip ci]

* Improve formating and aligning [skip ci]

Submitted by: rpluem

That was not me. Honors go to Joe.
Not obvious why the worker job is persistently failing in CPAN,

mark it as allowed_failure.


[skip ci]


*) mod_watchdog: Switch to simpler logic to avoid the thread cleanup running

before the thread has started, avoiding mutex operations with undefined

behaviour. [Christophe Jaillet]

Vote and promote.

*) mod_http2: connection terminology renamed to master/secondary.

trunk patch:

2.4.x patch:

+1: icing, ylavic, minfrin

ylavic: nitpicking, mixed "H2_secondary_IN" and "H2_secondary_OUT" case to

register the filters, but not for adding them. IIRC filters names

are case insentive so shouldn't matter, just popped at my eyes..

icing: updated patch and added r1879156 to fix the eye bleed.

jailletc36: CHANGES could also be looked at if it makes sense to update the terminology

also here

*) core: Drop an invalid Last-Modified header value coming

from a (F)CGI script instead of replacing it with Unix epoch.

Warn the users about Last-Modified header value replacements

and violations of the RFC.

trunk patch:

2.4.x: trunk patches work, final view:

svn merge -c 1748379,1750747,1750749,1750953,1751138,1751139,1751139,1757818,1879253,r1879348 ^/httpd/httpd/trunk .

The code has been tested with a simple PHP script returning different Last-Modified

headers (GMT now, GMT now Europe/Paris, GMT tomorrow, GMT yesterday, PST now).

+1: elukey, jorton, jim

jorton: +1 though I'd say log at WARN or INFO for the APR_BAD_DATE case

rather than "silently" (at normal log-level) dropping the parsed header?

[also nit: wrapping a lone ap_log_rerror(,APLOG_X) call in

if (APLOGrX(..) is unnecessary/redundant]

  1. … 4 more files in changeset.
Revert r1879627, the Travis job has now recovered. [skip ci]

Clear cache for the worker job which appears to be in a bad state.

[CTR under Travis exception]

Merge r1705539, r1877263, r1877291, r1879445 from trunk:

deduplicate the code handling the directory traversal for the

SSL[Proxy]CACertificatePath and SSLProxyMachineCertificatePath


* modules/ssl/ssl_engine_init.c (ssl_add_version_components,

ssl_init_Module): Use temporary pool for variable lookup results

which don't need to live in pconf.

mod_ssl: Factor out code to read a BIO into a palloc'ed string:

* modules/ssl/ssl_util_ssl.c (modssl_bio_free_read): New function.

(asn1_string_convert): Use it here.

* modules/ssl/ssl_engine_vars.c: Use it throughout.

* modules/ssl/ssl_scache.c (ssl_scache_init): Use <16 character

cname argument for socache ->init() per the API constraint.

Submitted by: kbrand, jorton, jorton, jorton

Reviewed by: jailletc36, minfrin, jim

Merge r1864868 from trunk:

Fix a signed/unsigned comparison that can never match.

-1 is a valid length value (for socket, pipe and cgi buckets for example)

All path I've checked cast the -1 to (apr_size_t) in order for the comparison to work. So do it as well here.

This has been like that in trunk since r708144, about 11 years ago, so I assume that it is not really an issue.

Spotted by gcc 9.1 and -Wextra

Submitted by: jailletc36

Reviewed by: jailletc36, minfrin, jim



For TEST_SSL=1 runs, test SSLSessionCache with shmcb, memcached

and redis socache providers. Force TLSv1.2 for these runs since

TLSv1.3 doesn't use the cache.

Check for and use gettid() directly if available; glibc 2.30 and later

provides a wrapper for the system call:

* Check for gettid() and define HAVE_SYS_GETTID if

gettid() is only usable via syscall().

* server/log.c (log_tid): Use gettid() directly if available.