Checkout Tools
  • last updated 4 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1873372 is being indexed.

Fix some grammar errors in the docs

Merge r1871810 from trunk:

*) mod_http2: Fixed rare cases where a h2 worker could deadlock the main connection.

Submitted by: icing

Reviewed by: icing, jim, steffenal

Merge r1872455 from trunk:

add r/o iterable tables

The current apr tables exposed support get/set but we cannot get the keys

or iterate. add _table() alternatives

Submitted by: covener

Reviewed by: covener, jim, humbedooh

Merge r1870650 from trunk:

PR63971 expose apr_table_unset for headers/envvars

via nil assignment

Submitted by: covener

Reviewed by: covener, jim, humbedooh

Update generated docs

  1. … 4 more files in changeset.
Fixed some grammar errors in the docs.

Fixed some grammar errors in the docs.

Update generated docs.

  1. … 253 more files in changeset.


Propose PR 64096 fix. [skip ci]

Have not seen false negatives with t/apache/expr_string.t since

r1872705 so let's try e-mail notifications for 2.4.x again. [skip ci]

casting some votes
Vote mod_http2


Had some time... votes on backports

Add tag and revision to release vote email template
Make the changes modifier perl script bail if it made no changes
fr doc rebuild.

fr doc XML file update.

fr doc rebuild.

fr doc XML files updates.

Vote. [skip ci]
Notes/votes. [skip ci]

Reset mod_ssl PKCS#11 proposal with added r1836547. [skip ci]

Simplified mod_systemd backport proposal w/o IdleShutdown feature.

Note partial merge of some commits, socket activation changes are

excluded. mod_systemd.c as proposed is exactly as in trunk.

mod_setenvif: add "early mode"

Primarily to run before `RequestHeader ... ... early`

Merge r1822531, r1829676, r1847232, r1847234, r1861333, r1852442, r1866145, r1868295, r1868296 from trunk:

mod_proxy: fix proxy connection cleanup from an n+2 pool.

When connection_destructor() is called after pchild is gone, we can't

dereference worker->cp anymore. This happens is debug/one_process mode only,

if we exit by calling apr_terminate() or clearing the process pool directly.

Fix this by NULL-ing worker->cp in conn_pool_cleanup(), and by registering it

as a pre_cleanup.

Delay some memory allocation.

If this handler will not handle the request, no need to waste bytes in the request pool.

Add error messages and return bad request.

fix incorrect rv. Sorry.

Follow up to r1847232.

There is no point to use "old" numbers in recent commit.

Also avoid number duplication. The messages are the same but in different code path, so having different numbers makes sense.

This also avoids a warning when running:

make update-log-msg-tags

Make proxy modules compile if APR_HAS_THREADS is not defined.

restore use of global mutex under !APR_HAS_THREADS

followup to r1852442 which appears to have been too agressive in wrapping

blocks with #if APR_HAS_THREADS. With !APR_HAS_THREADS a global mutex

is a proc mutex.

* Add back logging goodness

Add back logging goodness added by covener in r1865938.

Fix pool concurrency problems

Create a subpool of the connection pool for worker scoped DNS resolutions.

This is needed to avoid race conditions in using the connection pool by multiple

threads during ramp up.

Recheck after obtaining the lock if we still need to do things or if they

were already done by another thread while we were waiting on the lock.

* modules/proxy/proxy_util.c: Create a subpool of the connection pool for worker

scoped DNS resolutions and use it.

* modules/proxy/mod_proxy.h: Define AP_VOLATILIZE_T and add dns_pool to

struct proxy_conn_pool.

* modules/proxy/mod_proxy_ftp.c: Use dns_pool and consider that

worker->cp->addr is volatile in this location of the code.

PR: 63503

Submitted by: ylavic, jailletc36, jfclere, jfclere, jailletc36, stsp, covener, rpluem, rpluem

Reviewed by: rpluem, covener, jim

Merge r1851332, r1861432, r1862202, r1864759, r1867254, r1867255, r1867569, r1869512 from trunk:

fix a misleading comment about s->defn_name

use the provided types via the macro

* modules/metadata/mod_mime_magic.c: Constify some constant

data, remove unused "suf_recursion" field. No functional


Axe some dead code + slighly improve a comment

Fix a typo

Fix a typo

* modules/ssl/ssl_engine_log.c (ssl_log_cert_error): Use string

length returned by apr_vsnprintf. No functional change.

mod_authz_core: follow up to r1864759.

We should at least log the unexpected provider_name == NULL condition.

Submitted by: covener, jorton, jailletc36, jailletc36, jailletc36, jorton, ylavic

Reviewed by: jailletc36, jim, ylavic


Proposal and votes