Checkout Tools
  • last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates

Changeset 1800951 is being indexed.

mod_negotiation: add Accept variant tests

Also remove the duplicated config in the comments.

mod_lua: add apr_table compatibility test

We might back this out later, if we decide not to keep the

(undocumented) global variable.

Vote/promote one.

Two more string parsing oddities for consideration
Correct string scope to prevent duplicated values for subsequent tokens.

Fix negotiation type parsing to be strict about "*", "*/*" and "type/*"


Submitted by: wrowe, Robert Święcki <robert>

mod_lua: add some tests for the header table functionality
Mark backported patch 1800173 in commit 1800215
Merge r1800788 from trunk:

Add mod_proxy_hcheck to generated httpd.spec file. PR 60506.

Submitted by: ylavic

Reviewed by: ylavic, rpluem, jim


vote on rpm change

* Vote

mod_lua: Improve compatibility with Lua 5.1, 5.2 and 5.3.

PR58188, PR60831, PR61245.


The following lua 5.2 and 5.3 compat change

should be checked for runtime correctness

by someone more knowledgeable about lua.

Index: modules/lua/lua_apr.c

--- modules/lua/lua_apr.c (original)

+++ modules/lua/lua_apr.c Tue Jul 4 20:48:43 2017

@@ -82,7 +82,11 @@ static const luaL_Reg lua_table_methods[

int ap_lua_init(lua_State *L, apr_pool_t *p)


luaL_newmetatable(L, "Apr.Table");

+#if LUA_VERSION_NUM < 502

luaL_register(L, "apr_table", lua_table_methods);


+ luaL_newlib(L, lua_table_methods);


lua_pushstring(L, "__index");

lua_pushstring(L, "get");

lua_gettable(L, 2);

Fix another mod_lua compile error.

Compilation now tested against Lus 5.1, 5.2

and 5.3. The libs were compiled with COMPAT

flags set, but mod_lua no longer sets them

so it should compile and run with non-COMPAT

libs as well.

Fix new compilation breakage in mod_lua.

Mostly revert the configure compat check for

lua from r1785753. This should now no longer

be needed.

Fix last compat issue with Lua 5.2 and 5.3.

Patch taken from PR58188 which picked it from


Still needs testing.

More mod_lua compat for Lua 5.1, 5.2, 5.3.

One last use of luaL_register() with a non-NULL

"name" argument remaining.

Not tested yet.

mod_lua: Improve compatibility with Lua 5.1, 5.2 and 5.3.

PR58188, PR60831, PR61245.

Still to solve: replace uses of luaL_register().

Add mod_proxy_hcheck to generated httpd.spec file. PR 60506.

Merge r1800594 from trunk:

* Do not apply the strict permissions of the temporary file to a possibly

existing passwd file.

This long standing bug was triggered by fixing a bug in APR in r1791029.

PR: 61240

Submitted by: rpluem

Reviewed by: rpluem, ylavic, jim

SECURITY: CVE-2017-9789: Read after free in mod_http2.

When under stress, closing many connections, the HTTP/2

handling code would sometimes access memory after it has

been freed, resulting in potentially erratic behaviour.

Merge r1800689 from trunk:

Disable and give warning when mpm_prefork is encountered.

The server will continue to work, but HTTP/2 will no longer be negotiated.

Submitted by: icing

Reviewed by: icing, ylavic, jim


Votes on backports

* Propose
On the 2.4.x branch:

propose backport of http2/prefork disabling.