Clone Tools
  • last updated 18 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Squiggly now only replaces ContainerControllers if they don't implement ISpellingContainerController

FLEX-34756 Minor improvements.

FLEX-34756 The unit test revealed a bug in the solution: isTextFieldReadyForSpellingJob() should return true only if the textFlow is not damaged (it used to do the opposite).

FLEX-34756 Adding a unit test that reproduces the bug, and its supporting files.

FLEX-34756 -Renamed some variables for clarity -Separated the creation of the highlighters and SpellingService in new functions, so that they can be mocked for unit testing.

FLEX-34756 CAUSE: If a spelling job runs while the textFlow of RichEditableText is damaged, then the values that SpellUI.getValidFirstWordIndex() and SpellUI.getValidLastWordIndex() receive from SelectionManager.computeSelectionIndex() will be inaccurate. Sometimes, as in the example attached to the ticket, they will cause a runtime error.

SOLUTION: Prevent a spelling job from being executed when the textFlow is damaged.

NOTES: -also removed an unused variables and inaccurate comment from SparkHighlighter and SpellUI.

FLEX-34721 Made the Squiggly test running extensible - now when you write unit tests for other sub-projects, such as SpellingEngine, you can run them by adding a new line in the 'unit-tests' target of Squiggly/main/build.xml, on the model of the ones already there. Then you add a build.xml file in the sub-project you're testing, which includes a target called 'unit-tests' and is the same as the one in Squiggly/main/SpellingUIEx/build.xml.

    • -0
    • +27
    ./SpellingUI/build.xml
    • -0
    • +27
    ./SpellingUIEx/build.xml
FLEX-34721 Set up the build files to call flexunit-tests.xml from the SDK root in order to run the unit tests. Note that for now we're only running the tests in SpellingUIEx.

  1. … 1 more file in changeset.
FLEX-34717 the build script expects the test files to end in 'Tests'.

FLEX-34717 Clarified how the tests can fail.

FLEX-34717 Minor improvements to both versions of SpellUI.

FLEX-34717 Added the same unit test and fix as for SpellingUIEx.

FLEX-34717 Before the dictionary loads, both hh and scm are null, so cleanUp() shouldn't assume they're not.

FLEX-34717 Moved the unit test outside the source folder, so that it's not included in the swc.

FLEX-34717 Added a unit test to reproduce the bug. Currently it fails.

FLEX-34705 Removed unused imports.

  1. … 49 more files in changeset.
Revert this as the non-maven version has been released in 1.1, haven't this before

FLEX-34640: Squiggly: Generate / Package RSLs and deploy with Maven

  1. … 1 more file in changeset.
Misspelling of apache-flex-linguistic-utils instead of apache-flex-spelling-linguistic-utils

    • -1
    • +1
    ./maven/apache-flex-spelling-framework.pom
fix case of swc names

update version to 1.1

spelling ui sec not needed here

change to use newer version of the UI files

change to use newer version of the UI files

change to use newer version of the UI files

old version of files no longer required

Add missing example file

    • -0
    • +70
    ./Demo/SpellingDemoEx/src/AdobeSpellingDemoEx.mxml
Fixed a small bug in the pom-generation script.

Added a maven.xml to allow package, install and deploy of maven artifacts.

    • -0
    • +18
    ./maven/apache-flex-spelling-engine.pom
    • -0
    • +33
    ./maven/apache-flex-spelling-framework.pom
    • -0
    • +18
    ./maven/apache-flex-spelling-linguistic-utils.pom
    • -0
    • +27
    ./maven/apache-flex-spelling-ui-api.pom
    • -0
    • +27
    ./maven/apache-flex-spelling-ui-ex.pom
    • -0
    • +27
    ./maven/apache-flex-spelling-ui-tlf.pom
    • -0
    • +27
    ./maven/apache-flex-spelling-ui.pom
    • -0
    • +36
    ./maven/squiggly.pom
Change default config file name to SpellingConfig.xml in docs