flex-tlf

Clone Tools
  • last updated 12 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Uncomment OperationTest - After latest changes in TLF it looks like tests do not freeze on these class anymore

    • -1
    • +1
    /automation_tests/src/AllTestsSuite.as
Fix another ASDoc issue

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

Fix ASDoc issue

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

FLEX-34649 Handle situation where textlines don't exist because they've been scrolled off-screen

add missing headers

Removing the last span from a paragraph was causing ensureTerminatorAfterReplace() to create a new terminatorSpan.

Fixed an issue where some Operations were failing. I do not remember why I added normalizeRange() to this function, but I don't see any obvious issues with removing it.

Better handling of inserting table rows with merged cells.

insertColumnAt columns.length was failing. This is now fixed. There's no check for merged cells which will cause it to fail as well. It might be a good idea to add more complex logic to handle that, but currently adding columns to tables with merged cells will cause all kinds of trouble and we do not support that.

Clean up whitespace

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

Removing OperationTest just for check whether this fix the build

    • -1
    • +1
    /automation_tests/src/AllTestsSuite.as
Changed build.properties

Merge branch 'develop' into tables

* develop:

the original change broke a few tests. I think this one is better

Reverted a commit from Alex that was lost with the last merge. Fixed line start index for TextFlowLine initialization

Change var name again, to keep to existing namimg convention

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

The local var had the same name as the function argument. The Falcon compiler objects to this ;-)

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

the original change broke a few tests. I think this one is better

Ignore table space-before mid-paragraph

Add flexdebug property to ant build.xml and build.properties file

Add failing test to MinimalTestsSuite

    • -2
    • +2
    /automation_tests/src/MinimalTestsSuite.as
Fixed vertical placement of table blocks to take into account the previous line descent and paragraph space before/space after.

Some code cleanup

Fixed inserting columns so cells are inserted in the correct location

Merge remote-tracking branch 'remotes/origin/develop' into tables

* remotes/origin/develop: (31 commits)

Add TabTest with ingnored noTabStop test

Add WritingModeTest, UndoRedoTest, TextFlowEditTest Remove unused variable from TestDescriptorRunner

Back to the original implementation Ignore arrowUp and arrowDown tests in GeneralFunctionsTest

Add echo to build.xml for print minimalTests value

Set minimalTests property to true just for check ContainerTypeTest

Add property minimalTests to make MinimalTestsSuite runnable

FLEX-34611: Application crash when textFlow property set to null with preserveSelection

FLEX-26478 Responding to dev review by adding curly braces around if clauses. Also optimised imports and renamed comment parameters in StandardFlowComposer and ContainerController.

Remove unused import in ContainerAttributeTest

FLEX-26478 CAUSE: When replacing ContainerControllers (triggered when the text changes in a TextField / TextArea), StandardFlowComposer tried to dispose of the discarded ones first. It did this by calling clearSelectionShapes() and setRootElement(null) on the ContainerControllers. However, if that controller was already listening for mouse scroll events (when the user selects text and moves the mouse outside the text field in such a way that causes the text to scroll), this listener wasn't removed. Which meant that the next time scrollTimerHandler() was called (on the inactive ContainerController), textFlow was null due to the call to setRootElement(null).

Revert "revert these to see if they made a difference"

revert these to see if they made a difference

Attempt to fix build - set forkValue to true

another attempt to fix flex-tlf

Try to fix build with really high values -Xmx1024m -XX:MaxPermSize=1024m

Try to fix build increase -Xmx512m

Try to fix build - higher values for MaxPermSize=768

Back to the original values for jvm.args

Remove additional mxmlc buld of Flow.swf from testApps target in build.xml

try even more PermGen

...

Conflicts:

textLayout/src/flashx/textLayout/compose/StandardFlowComposer.as

textLayout/src/flashx/textLayout/container/ContainerController.as

Added check for valid terminator span after replacement

Add TabTest with ingnored noTabStop test

    • -0
    • +2
    /automation_tests/src/AllTestsSuite.as
    • -531
    • +556
    /automation_tests/src/UnitTest/Tests/TabTest.as
Add WritingModeTest, UndoRedoTest, TextFlowEditTest Remove unused variable from TestDescriptorRunner

    • -0
    • +6
    /automation_tests/src/AllTestsSuite.as
Forced redrawing of cells when the parent ContainerController.updateCompositionShapes() is called. This fixes drawing of cells when the table structure of an existing table changes. It might be more efficient if there's a check to see if the table structure changes rather than blindly redrawing the table block every time.

Back to the original implementation Ignore arrowUp and arrowDown tests in GeneralFunctionsTest

Cells were incorrectly setting padding every time they were composed which was causing cell lines to become incorrectly invalid and put cells into an unstable state. I think ContainerController should be adding the array including tables to _shapeChildren and not the old _linesInView which only contains pure lines.