Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert FLEX-34880 part 3

This reverts commit 2b09e327281211d26d65dd5d061b02d645cbdd39.

    • -2
    • +3
    ./newComps/CustComp_sortField_compareFunction.mxml
  1. … 9 more files in changeset.
Revert FLEX-34880 part 1 This reverts commit 0b5a634dabb00c04a492a08375e29c6885c1486f.

  1. … 9 more files in changeset.
FLEX-34880 Placed the other ISortField setters behind mx_internal and removed them from the interface.

  1. … 9 more files in changeset.
FLEX-34880 Placed only one state setter (SortField.compareFunction) behind mx_internal (thus also renaming it to SortField.compareFunction_) to provide the template for the others. Also removed it from the interface (ISortField).

    • -3
    • +2
    ./newComps/CustComp_sortField_compareFunction.mxml
  1. … 9 more files in changeset.
FLEX-35043 PROBLEM: The assumptions in SF_ORIG_list_events_tester.List_events_collectionKind_move made obvious another problem caused by FLEX-34885: calling itemUpdated(item) did not reposition the item according to the sorting rules (unless the Sort had a customCompareFunction).

CAUSE: FLEX-34885 assumed that the initial logic of checking for !updateEntry.property was to detect when entire objects were replaced with others in the collection. However, it was also detecting when the developer signalled that something (undefined) about an object had changed, and they wanted the sorting / filtering to be reapplied.

SOLUTION: now we call moveItemInView() also when updateEntry.property is null and there are no oldValue or newValue specified in the CollectionEvent.

NOTES:

-also updated ListCollectionView_PropertyChangeEvent_Tests and added a new function for objects which are not bindable. As expected, there is a failure without this change to ListCollectionView, and with the change all unit tests pass.

-made explicit a conversion from Object into Boolean in a call to moveItemInView().

-reformated event instantiations to be on one line.

-made some minor changes to SF_ORIG_ListBasic.mxml, which is used by SF_ORIG_list_events_tester.

  1. … 3 more files in changeset.
FLEX-33706 added missing import

  1. … 1 more file in changeset.
Fix another sort order issue.

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/sdk/branches/develop@1389593 13f79535-47bb-0310-9956-ffa450edef68

  1. … 1 more file in changeset.
Modify test to compute the results from flash.globalization.Collator. Different player versions return different orders per some Unicode standard that changes from time to time.

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/sdk/branches/develop@1389214 13f79535-47bb-0310-9956-ffa450edef68

Fixed test script

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/sdk/branches/develop@1387616 13f79535-47bb-0310-9956-ffa450edef68

Mustella submission

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1370401 13f79535-47bb-0310-9956-ffa450edef68

    • -0
    • +35
    ./SF_Constructor.mxml
    • -0
    • +164
    ./SF_ORIG_ArrayCollection.mxml
    • -0
    • +193
    ./SF_ORIG_AsyncListView.mxml
    • -0
    • +985
    ./SF_ORIG_DataGridApp.mxml
    • -0
    • +1
    ./SF_ORIG_DataGridApp_halo.compile
    • -0
    • +948
    ./SF_ORIG_DataGridApp_halo.mxml
    • -0
    • +125
    ./SF_ORIG_IViewCursor.mxml
    • -0
    • +275
    ./SF_ORIG_ListBasic.mxml
    • -0
    • +169
    ./SF_ORIG_ListCollectionView.mxml
    • -0
    • +60
    ./SF_ORIG_dataGroup_Events_itemIndex.mxml
    • -0
    • +48
    ./SF_ORIG_fxDataContainer_methods.mxml
    • -0
    • +35
    ./SF_SortField_arraySortOnOption.mxml
    • -0
    • +35
    ./SF_Sort_fields.mxml
    • -0
    • +35
    ./SF_Sort_fields_ext.mxml
  1. … 3503 more files in changeset.