Clone Tools
  • last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert FLEX-34880 part 3

This reverts commit 2b09e327281211d26d65dd5d061b02d645cbdd39.

  1. … 9 more files in changeset.
Revert FLEX-34880 part 1 This reverts commit 0b5a634dabb00c04a492a08375e29c6885c1486f.

  1. … 8 more files in changeset.
FLEX-34880 Placed the other ISortField setters behind mx_internal and removed them from the interface.

  1. … 8 more files in changeset.
FLEX-34880 Placed only one state setter (SortField.compareFunction) behind mx_internal (thus also renaming it to SortField.compareFunction_) to provide the template for the others. Also removed it from the interface (ISortField).

  1. … 9 more files in changeset.
FLEX-35043 PROBLEM: The assumptions in SF_ORIG_list_events_tester.List_events_collectionKind_move made obvious another problem caused by FLEX-34885: calling itemUpdated(item) did not reposition the item according to the sorting rules (unless the Sort had a customCompareFunction).

CAUSE: FLEX-34885 assumed that the initial logic of checking for !updateEntry.property was to detect when entire objects were replaced with others in the collection. However, it was also detecting when the developer signalled that something (undefined) about an object had changed, and they wanted the sorting / filtering to be reapplied.

SOLUTION: now we call moveItemInView() also when updateEntry.property is null and there are no oldValue or newValue specified in the CollectionEvent.

NOTES:

-also updated ListCollectionView_PropertyChangeEvent_Tests and added a new function for objects which are not bindable. As expected, there is a failure without this change to ListCollectionView, and with the change all unit tests pass.

-made explicit a conversion from Object into Boolean in a call to moveItemInView().

-reformated event instantiations to be on one line.

-made some minor changes to SF_ORIG_ListBasic.mxml, which is used by SF_ORIG_list_events_tester.

  1. … 3 more files in changeset.
FLEX-34879 Moving setter assignments into constructor.

FLEX-34879 Replacing SortField setters with constructor arguments.

  1. … 2 more files in changeset.
FLEX-34854 Minor edits while checking a mustella failure.

  1. … 1 more file in changeset.
increase tolerance on this test. The TextDecoration gets rendered with some blendmode for some reason

add display list xml for these tests

add display list xml for these tests

*.png.xml files for failing FXG tests (FP 16)

Signed-off-by: flex-mustella.cloudapp.net <erikdebruin@apache.org>

*.png.xml files for failing FXG tests (FP 16)

Signed-off-by: flex-mustella.cloudapp.net <erikdebruin@apache.org>

    • -0
    • +44
    ./spark/core/fxg/properties/baselines/bitmapgraphics_bitmapgraphic_overlap_visibility2@win.png.xml
    • -0
    • +21
    ./spark/core/fxg/properties/baselines/fill_bitmap_fill_bitmap_matrix_fill_path_no_tiling@win.png.xml
    • -0
    • +32
    ./spark/core/fxg/properties/baselines/fill_bitmap_fill_bitmap_matrix_fill_shape_no_tiling@win.png.xml
Fix test to match 'new' selectedIndices value (FLEX-34657)

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

Fix test to match 'new' selectedIndices value (FLEX-34657)

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

Mustella tests to go with "FLEX-34657: SelectedIndices order is messed up"

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

    • -0
    • +89
    ./components/List/Properties/SparkList_Properties.mxml
    • -0
    • +63
    ./components/List/SWFs/SparkList_Basic.mxml
Mustella tests to go with "FLEX-34657: SelectedIndices order is messed up"

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>

    • -0
    • +63
    ./components/List/SWFs/SparkList_Basic.mxml
Revert "Merge commit '1884960242f835879f5ca6504659072a2305f120' into release4.14.0"

This reverts commit 7a051584552d332fc27e743b6ef83864a0737e53, reversing

changes made to 1884960242f835879f5ca6504659072a2305f120.

  1. … 45 more files in changeset.
FLEX-25045 added mustella test for issue

this test now needs some pixel tolerance

update mac baseline now that it is out from under the panel gradient

fix failing advancedcss test on windows. The button was in the dropshadow of a panel and was rendered differently on FP14 vs FP11. I moved the button below the dropshadow

FLEX-34450 updated baseline image

FLEX-34450 remove now redundant email domain length checks from locale unit tests

    • -16
    • +0
    ./LangPacks/Dutch/tests/emailValidatorTests.mxml
FLEX-34450 - remove invalid domain checks from thise locale because the length is no longer checked

Fix FLEX-34450 by removing the length checks for the last part of an email domain Update Mustella tests to mathc new behaviour i.e. the tests should now return valid

  1. … 1 more file in changeset.
FLEX-34378 count multiple separators as an invalid date format

  1. … 1 more file in changeset.
sub pixel differences

sub pixel differences were cause random failures

FLEX-369 new baselines so test pass