Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FLEX-35375 CAUSE: DataGrids didn't dispatch a VALUE_COMMIT event when a new dataProvider cleared the selection, thus allowing the selectedItem, selectedIndex, selectedItems, selectedIndexes to become null without a notification. Which also means that if there was any binding set up for any of those variables, it won't be triggered. SOLUTION: we now dispatch a VALUE_COMMIT event when a new dataProvider ends up clearing the selection. NOTE: also added a unit test for this bug, which fails without the fix and passes with the above fix.

    • -0
    • +110
    ./spark/components/Grid_FLEX_35375_Tests.as
  1. … 1 more file in changeset.
missing headers

    • -0
    • +19
    ./spark/components/_HeadquarterVO.as
  1. … 3 more files in changeset.
FLEX-35362 Added unit test to reproduce the bug. As expected, it currently fails.

    • -0
    • +60
    ./spark/components/DropDownListBase_FLEX_35362_Tests.as
FLEX-35306 Addd unit test. Fails when reverting the fix, passes with the fix.

    • -0
    • +274
    ./spark/components/List_FLEX_35306_Tests.as
    • -0
    • +49
    ./spark/components/_CompanyVO.as
    • -0
    • +23
    ./spark/components/_HeadquarterVO.as
    • -0
    • +22
    ./spark/components/_ListWithMXMLBinding.mxml
FLEX-35267 Updated unit test to support horizontal scrolling and two new grid profiles. Currently tests fail, but for perplexing reasons (seems like a failure to validate, despite the unit test calling validateNow() way too many times...).

  1. … 1 more file in changeset.
FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test to pass I've improved the logic in GridHeaderViewLayout.getHeaderIndexAt() which, in turn, made a few functions redundant in GridColumnHeaderGroup. All tests currently pass.

FLEX-35267 Updated unit test - made it easier to read, and now we're also testing GridColumnHeaderGroup.containsGlobalCoordinates(). For the test to pass I've improved the logic in GridHeaderViewLayout.getHeaderIndexAt() which, in turn, made a few functions redundant in GridColumnHeaderGroup. All tests currently pass.

  1. … 2 more files in changeset.
FLEX-35260 Now we are taking into account paddingTop and paddingBottom in getHeaderIndexAt(). Unit test updated as well (and passes, including a second data grid configuration).

  1. … 1 more file in changeset.
FLEX-35260 Now the unit test passes, having been updated to check the column header view boundaries. Other changes: -Now we're ignoring the grid header's right padding, because it doesn't make a visual difference (except in the edge case where, together with the left and right padding, the column widths are wider than the grid's width, in which case the grid header expands beyond the grid limits), but we are starting to take into account bottom and top padding. -Renamed some variables and functions for clarity in GridColumnHeaderView and GridDimensions. -Improved error messages in the unit test

  1. … 3 more files in changeset.
FLEX-35260 Now in the unit test we're also verifying areCoordinatesOverAHeaderView(). Currently fails (for point "b").

FLEX-35267 FLEX-35260 Added a unit test which can verify the column-index and header-index related functions more thoroughly. Currently it fails, as expected.

FLEX-26808 Increased a test function's timeout and added a bit more information to see why another is failing.

FLEX-34088 Using addChild instead of addElement for FlexUnit to get the test to run.

FLEX-35126 Added a unit test to reprouce the bug. Currently it passes, as expected. (But if I manually put back the fix for FLEX-34088, it fails, as it should, meaning it actually tests the correct bug.)

    • -0
    • +182
    ./spark/components/DropDownList_FLEX_35126_Tests.as
FLEX-34088 Added unit test to reproduce the bug. Currently it passes, but I tested locally with some modifications to DropDownController and can certify it does indeed fail when it should - namely, when both the fix for FLEX-34088 and FLEX-34078 are removed. In other words, the fix for FLEX-34078 also fixes this issue, making the current fix superfluous. I'll remove it in the next commit.

  1. … 1 more file in changeset.
FLEX-33311 Replacing all UIImpersonator.addElement() with UIImpersonator.addChild() to get the unit tests to run.

    • -1
    • +1
    ./spark/layouts/ConstraintLayout_FLEX_33311_Tests.as
    • -2
    • +2
    ./spark/skins/spark/FLEX_34625_Tests.as
FLEX-33311 Adding unit test to reproduce the bug. Currently fails, as expected.

    • -0
    • +139
    ./spark/layouts/ConstraintLayout_FLEX_33311_Tests.as
FLEX-26808 Added unit tests to make sure that the selection (made either programmatically or through ctrl-clicking on the grid) is preserved when the user starts dragging the items. The tests pass locally.

-Also added VectorUtil.toArrayObject() to convert a Vector.<Object> to an Array (uses the same private function as VectorUtil.toArrayInt(), so I haven't added unit tests).

-Added a missing semicolon in Grid.as

  1. … 2 more files in changeset.
FLEX-34837 As noticed in FLEX-26808, if the dimensions are not specified the grid layout will not render its GridViews. Test still passes.

FLEX-26808 Adding unit test. For now we're just testing that Ctrl+Click deselects the (selected) first item (test passes). Dragging behaviour will follow.

    • -0
    • +203
    ./spark/components/DataGrid_FLEX_26808_Tests.as
FLEX-34625 FLEX-34959 Timeouts are controlled in two places, and I omitted this one in the previous commit.

    • -2
    • +2
    ./spark/skins/spark/FLEX_34625_Tests.as
FLEX-34959 FLEX-34625 Increasing test timeout, as it looks like 4 frames were rendered in more than 500ms.

    • -2
    • +3
    ./spark/skins/spark/FLEX_34625_Tests.as
this got these test to pass on my mac

    • -3
    • +7
    ./spark/skins/spark/FLEX_34625_Tests.as
  1. … 1 more file in changeset.
try to fix these tests

FLEX-34625 Reverting unit test to pre-debug version.

    • -41
    • +8
    ./spark/skins/spark/FLEX_34625_Tests.as
FLEX-34837 Added unit test which reproduces the bug from the DataGrid side. NOTE: this unit test works in IntelliJ - i.e. fails as expected -, but fails in the SDK with the message "UIImpersonator doesn't work correctly!" because FlexUnit is not compiled for Flex projects (so UIImpersonator doesn't act as it does locally). When we release a new version of FlexUnit we can correct this.

    • -0
    • +201
    ./spark/components/DataGrid_FLEX_34837_Tests.as
FLEX-34854 Moved the test to a better package and added a header comment.

    • -0
    • +56
    ./spark/collections/SortField_Tests.as
    • -37
    • +0
    ./spark/skins/spark/SortField_Tests.as
FLEX-34854 Changes while investigating a mustella failure (probably) introduced by the changes to this ticket: added a new unit test, corrections to comments, optimizing object initializations and removing unused variables.

    • -0
    • +37
    ./spark/skins/spark/SortField_Tests.as
  1. … 5 more files in changeset.
FLEX-34721 In order to support Squiggly to run its own unit tests via flexunit-tests.xml, we had to make some changes: -all the existing unit tests have been moved to a directory called 'tests' on the same level as the 'src' directory of each project. That's because other projects (in this case, Squiggly) don't compile their sources based on a manifest.xml file, or on a main .as file that links in all the classes. This means that if the 'src' folder will contain unit tests in Squiggly, they will be compiled into the swc, which we don't want. Also it's generally better to assume that tests do not reside in the 'src' directory of the project. -as a result, flexunit-tests.xml looks for unit tests in project.root/tests, instead of project.root/src. -the 'test-run' target of flexunit-tests.xml was split into four targets, which mapped onto what that targed used to do before. The exception is -test-run-execute-with-extra-lib, which only runs if the target was called from a project which needs to specify an additional libraries folder (different Squiggly sub-projects need this, because they depend on other sub-projects).

    • -0
    • +138
    ./spark/skins/spark/FLEX_34625_Tests.as
  1. … 6 more files in changeset.