Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FLEX-34926 fixed misplaced [PercentProxy] metatag

    • -2
    • +2
    ./components/gridClasses/GridColumn.as
FLEX-35028 stop RTE when clicking on DG header

FLEX-26808 Minor refactoring while reading the code: asdocs improvements, and adding missing semicolon.

FLEX-26808 Optimizing imports.

FLEX-26808 Terminating statements, correcting asdocs, and removing an unused variable and unused method.

FLEX-26808 CAUSE: DataGrid.grid_mouseDownHandler() committed the selection before checking whether the user was likely to begin a drag operation.

SOLUTION: Following the pattern in the spark List component, we're committing the selection on MOUSE_DOWN only if the user has clicked on an item which isn't selected yet, or the grid is not dragEnabled, or we're not in row selection mode (i.e. either GridSelectionMode.SINGLE_ROW or GridSelectionMode.MULTIPLE_ROWS). But when it looks like the user might start a dragOperation, we're deferring the selection adjustment to the MOUSE_UP event (caught either in DataGrid.grid_mouseUpHandler() or in DataGrid.sandbox_mouseUpHandler() ).

NOTES:

-also removed some duplication between DataGrid.grid_mouseDownHandler() and DataGrid.removeMouseHandlersForDragStart().

-also corrected some asdocs @see references.

FLEX-26808 Improved asdocs and comment.

FLEX-26808 Renamed getFirstItemValue to getFirstItem.

  1. … 2 more files in changeset.
FLEX-26808 Moving Vector-related function List.getFirstItemValue() to new VectorUtil class (unit tested in VectorUtilTests.as)

  1. … 2 more files in changeset.
update version to 4.16.0

  1. … 19 more files in changeset.
FLEX-34979 Adding Apache header.

    • -0
    • +19
    ./collections/AdvancedStyleClient_.as
FLEX-34979 CAUSE: The transformation of the spark Sort and SortField from extending AdvancedStyleClient to implementing its interfaces and using an instance of it as a class member had some more bugs: -the id setter didn't exist -when AdvancedStyleClient dispatched an event, Sort / SortField didn't pick up on it and dispatch forward -When AdvancedStyleClient initialized it added itself as a styleClient to the document. This is undesired for Sort and SortField because from then on the style code would used the AdvancedStyleClient member instead of the Sort / SortField instances, as before, which meant that their relevant functions (such as setStyle or styleChanged) were never called.

SOLUTION:

-there is now an id setter in AdvancedStyleClientImplementation

-AdvancedStyleClient_ was introduced to be able to override some functions of AdvancedStyleClient

-Sort and SortField now listen to the events dispatched via their AdvancedStyleClient_ member and pass on the events if there's a listener for them

-on initialization we now add the Sort / SortField instances as styleClients to the document instead of their AdvancedStyleClient members, which should now be hidden from any code interacting with Sort and SortField (this is achieved in AdvancedStyleClient_)

-all the instances where AdvancedStyleClient interacted with the StyleProtoChain using 'this' were changed into using the Sort / SortField instances

NOTES:

-Since some of the public functions in AdvancedStyleClient (getStyle, setStyle, styleChanged) are also called internally from other AdvancedStyleClient functions (or could be, in the future), and we need them to hit the Sort / SortField implementations instead, AdvancedStyleClient_ now overrides those functions and makes sure that the Sort / SortField versions are called.

-AdvancedStyleClient.setDeferredStyles() was made protected so that AdvancedStyleClient_.as can override it to make sure that StyleProtoChain.setStyle is always called referring to Sort or SortField instead of the instance of AdvancedStyleClient_ they use internally.

    • -1
    • +23
    ./collections/AdvancedStyleClientImplementation.as
    • -0
    • +107
    ./collections/AdvancedStyleClient_.as
  1. … 1 more file in changeset.
FLEX-34979 CAUSE: When the transition was made from the spark Sort and SortField extending AdvancedStyleClient to implementing its interfaces, the omission was that only IAdvancedStyleClient was implemented, as opposed to all three relevant interfaces (IAdvancedStyleClient, IFlexModule, IMXMLObject). More specifically the mustella failures reflected that the function initialized() wasn't present anymore, as that function, called automatically by the framework, is responsible for registering the Sort and SortField instances with the IFlexModuleFactory implementor (FlexModuleFactory or SystemManager, etc.).

SOLUTION:

The spark versions of Sort and SortField now also implement IFlexModule and IMXMLObject via AdvancedStyleClientImplementation.

NOTES:

-also cleaned some imports in AdvancedStyleClient.

    • -0
    • +22
    ./collections/AdvancedStyleClientImplementation.as
  1. … 1 more file in changeset.
FLEX-33537: Updated to force properties to be validated before setting the focus to the textDisplay. This seems to stop it tripping over itself with the visible skin states.

Revert "FLEX-33537: Changed the internal setfocus to the textDisplay call to be callLater. This allows for the skin/child components to be setup before receiving focus."

This reverts commit d5c329722cd60568c53210973024b591b912b486.

fix missing import

FLEX-34944 CAUSE: GridItemRenderer implements its own logic for rendering tooltips in grids. However, it doesn't cater for the situation when those tooltips are due to Validation errors. In that situation it should leave the rendering to ToolTipManager.

SOLUTION: GridItemRenderer.toolTipShowHandler now avoids overriding the default tooltip behaviour when the errorString is not empty.

NOTES:

-in ToolTipManagerImpl I cleaned imports, made some functions static where appropriate, and removed an unused function parameter.

  1. … 1 more file in changeset.
FLEX-34941 Although not directly connected to this ticket, taking the opportunity to remove two unused (and identical) private static methods (for which, are they to be needed in the future, we have an alternative in mx.utils.ObjectUtil.getValue).

  1. … 1 more file in changeset.
FLEX-34028: Removed 2 variables that were not being used and changed the event ctrlKey/shiftKey selection check to before the dragEnabled check.

FLEX-34028: Changed how the down click drag preparation behavior works. If the CTRL key is down and the current item being clicked on is already selected (meaning would toggle it's selection) it will avoid the drag prep.

FLEX-34741: Corrected the dropIndicator. It will now use the grid.layout.centergridview.layout instead of the grid.layout directly. Also removed the calculateDropLocation from the DataGrid as it is no longer used.

FLEX-34837 Minor changes: asdocs, making some private functions static where applicable, removing unused namespaces.

    • -24
    • +19
    ./components/gridClasses/GridItemEditor.as
FLEX-34837 Making sure that sorting with complex fields is the same as with simple fields in terms of locale awareness. For this I created a spark ComplexSortField which extends the spark SortField (and is thus locale-aware) and adds in the functionality for complex fields. Then GridSortFieldComplex could extend this version, to make sure that locale is handled correctly.

    • -0
    • +53
    ./collections/ComplexSortField.as
  1. … 1 more file in changeset.
FLEX-34837 CAUSE: DataGrid never had a mechanism by which it could monitor changes to the complex dataFields (e.g. "address.street") of the items in its dataProvider. Because of this, it couldn't ask for the collection to re-sort its items when one of these values changed. The best it could do was to keep track of when these values changed through its GridItemEditor, which it could detect.

SOLUTION: Now ListCollectionView can be asked (by DataGrid.ensureComplexFieldsMonitoring) to monitor all changes to the complex fields by which it's sorted (through the ComplexFieldChangeWatcher). Whenever one of them changes, the collection is resorted. Also, the sorting that GridColumn used to do through one of its own sortFunctions, is now left to Sort and SortField to do, as they've specialized in complex fields as well.

NOTES:

-This also means that GridItemEditor doesn't need to manually dispatch an itemUpdated event each time an item has been edited through it.

    • -60
    • +16
    ./components/gridClasses/GridColumn.as
    • -6
    • +0
    ./components/gridClasses/GridItemEditor.as
    • -83
    • +0
    ./components/gridClasses/GridSortField.as
    • -0
    • +72
    ./components/gridClasses/GridSortFieldComplex.as
    • -0
    • +45
    ./components/gridClasses/GridSortFieldSimple.as
  1. … 2 more files in changeset.
FLEX-34854 spark.collections.Sort.sort() was very similar to mx.collections.Sort.sort(), with the only difference in the fact that the latter tried to use Array.sortOn when appropriate. So, to remove the duplication I introduced a new flag to the mx version called useSortOn, which the spark version defaults to false. This way I could completely remove spark.collections.Sort.sort() and reset a few members of the mx version as private, as before.

  1. … 1 more file in changeset.
FLEX-34854 The spark Sort now extends the mx version, to prevent the need of changing both classes when a bug is fixed or a feature is implemented. NOTES: -this is a result of the mailing list discussion entitled 'Can we unify spark and mx Sort and SortField?'. -some members of mx.collections.Sort needed to be marked protected so that the sort() function could access them. In the next commit they will be reverted by implementing a way in which the sort() function doesn't need to be overridden. -mx.collections.Sort needed to have a new method, createEmptySortField(), which is now used by noFieldsCompare(), and that ensures that the differences in spark.collections.Sort.noFieldsCompare() are preserved without having to copy-paste the entire method.

  1. … 1 more file in changeset.
FLEX-34854 FLEX-34884 Mirror of commit 047017398a2ccea7ddb2b0300ec4a184ad7f9ab6 for the spark version of Sort.as.

FLEX-34854 FLEX-34852 Removing unused variables. NOTE: this mirrors commit 5a27cc8044e4e7a8e22cb2c75037bb9356d6d128.

FLEX-34854 Changes to asdocs comments to get the spark and mx versions of Sort.as more similar.

  1. … 1 more file in changeset.
FLEX-34854 The spark SortField now extends the mx version, to prevent the need of changing both classes when a bug is fixed or a feature is implemented. NOTES: -this is a result of the mailing list discussion entitled 'Can we unify spark and mx Sort and SortField?'. -the compareFunction getter and setter have been kept only for the asdoc comment to show the differences between the spark and mx SortField. -the spark DataGrid was using AdvancedStyleClient to refer to spark SortFields instead of the interface, IAdvancedStyleClient. This needed to be corrected, because the spark SortField does not extend AdvancedStyleClient anymore. -SortField.stringCompare() and .xmlCompare() needed to be protected (they were private) so that they could be overridden in spark SortField.

    • -0
    • +144
    ./collections/AdvancedStyleClientImplementation.as
  1. … 1 more file in changeset.