Clone Tools
  • last updated 11 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix for https://issues.apache.org/jira/browse/FLEX-34772 Add 'padding' property

Signed-off-by: OmPrakash Muppirala <bigosmallm@gmail.com>

  1. … 5 more files in changeset.
Fix for https://issues.apache.org/jira/browse/FLEX-34772 Add 'padding' property

Signed-off-by: OmPrakash Muppirala <bigosmallm@gmail.com>

  1. … 5 more files in changeset.
FLEX-28291 Responding to dev review: converting tabs to spaces.

  1. … 1 more file in changeset.
FLEX-28291 CAUSE: Please see the fxp attached to the ticket for a way to reproduce this bug. From the Flex Jira bugs and the bug reports in our application I'm sure there are many other ways, but that's the one I could find.

There are ways to time the call to getMajorSize() on LinearLayoutVector in such a way that at that particular moment it's not yet synchronised with the DataGroup's current dataProvider, but instead with the previous one. (This applies for a snapshot before and after it's refresh()ed, as the items can vary wildly, as in the attachment). But getMajorSize() assumes that its blockTable is an accurate mapping of the current dataProvider length (disguised as DataGroup.numElements), and that therefore the index it receives as a parameter will exist (after the 'index >> BLOCK_SHIFT' mapping) in its blockTable Vector. Indeed, its assumption is correct, because it's the responsibility of VerticalLayout and HorizontaLayout to keep it in sync with the changed dataProvider.

This possibility is opened by List.dataProviderRefreshed(), which waits for the validation cycle to finish before asking the list to ensureCaretVisibility() for an index it computed before the validation cycle. However, if the dataProvider somehow changes after the validation cycle and before UPDATE_COMPLETE, we're in trouble.

SOLUTION:

Get VerticalLayout and HorizontaLayout to call updateLLV(g) before calling getBounds() on their LinearLayoutVector. This way, at least, the blockTable Vector in LinearLayoutVector has the correct length, if incorrect (empty) data.

NOTES:

-As alluded to above, while this fix does remove the fatal, it does not actually make the list scroll to the previously selected index. To achieve that we would need to call updateDisplayListVirtual() instead of updateLLV, but that's impossible because it will fail with another fatal (Error #1009 in VerticalLayout/calculateElementWidth():1721). That's because now the DataGroup will return null for getVirtualElementAt(), as its 'virtualLayoutUnderway' is false, since the validation cycle has completed. To get around this we'd need to either call validateNow whenever the DataGroup's dataProvider is reset, refreshed or replaced, or instead remove the virtualLayoutUnderway conditional from getVirtualElementAt(), but both of these are major changes with many potential side effects. If anyone wants to investigate them, they are most welcome.

-From what I can tell, the only reason List.dataProviderRefreshed() exists is that when it redraws, the list does not keep the current scroll position, but instead starts from the top/left. If we could make it redraw directly on the current scroll position (or the maximum the new items can occupy), we would remove the need for List.dataProviderRefreshed(), thus removing the potential for this bug.

  1. … 1 more file in changeset.
FLEX-28291 Removing unused imports.

  1. … 3 more files in changeset.
Transferred from the Adobe Open Source Subversion Repository

Revision: 23247

Author: cframpto@adobe.com

Date: 2011-12-20T19:21:13.134833Z

Log Message:

-----------

Remove ADOBE SYSTEMS license and replace with Apache license in headers - frameworks. A 2nd pass will be needed to get the files not handled up by the scripts.

Modified Paths:

--------------

4959 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285392 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23246

Author: cframpto@adobe.com

Date: 2011-12-20T17:40:08.069454Z

Log Message:

-----------

Rollback 23243. If comment followed header it was stripped as well.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285391 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23243

Author: cframpto@adobe.com

Date: 2011-12-20T00:59:57.384047Z

Log Message:

-----------

In frameworks, remove Adobe headers from all files except xml/mxml file types. There are also a few .txt files that are license files that I didn't touch yet.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285390 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 22828

Author: eday@adobe.com

Date: 2011-09-30T17:39:52.356390Z

Log Message:

-----------

Fix for clearVirtualLayoutCache problem which was making renderers disappear

Need to invalidate the layout target after clearing the LLV.

QE notes:

Doc notes:

Bugs: SDK-SDK-31677

Reviewer: Evtim

Tests run: checkintests, full desktop cyclone, mobile List

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285389 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 22408

Author: egeorgie@adobe.com

Date: 2011-09-06T18:39:28.713918Z

Log Message:

-----------

Fix SDK-30012 Scroller does not work as I would have thought it should with child elements

- Make sure Horizontal/Vertical layout respect element's minimum in the minor dimension when %size is in play. Version checked.

QE notes:

Doc notes:

Bugs: SDK-30012

Reviewer: Hans

Tests run: Cyclone

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285388 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 22200

Author: egeorgie@adobe.com

Date: 2011-08-25T00:49:34.044884Z

Log Message:

-----------

Fix SDK-31339 First item of a DataGroup isn't shown when it's null

- Use _columnWidth/_rowHeight instead of getters

QE notes:

Doc notes:

Bugs: SDK-31339

Reviewer: Chiedo

Tests run:

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285387 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 22190

Author: egeorgie@adobe.com

Date: 2011-08-24T21:16:42.308482Z

Log Message:

-----------

SDK-31167 ensureIndexIsVisible doesn't work properly with fullscreen images when useVirtualLayout is true and columnWidth is set

- Make sure columnWidth/rowHeight settings are used as defaultMajorSize for the LLV in virtualized HorizontalLayout/VerticalLayout

QE notes:

Doc notes:

Bugs: SDK-31167

Reviewer: Hans

Tests run:

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285386 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 21763

Author: eday@adobe.com

Date: 2011-08-02T00:08:19.563082Z

Log Message:

-----------

Item Snapping fixes + tests

- Made page velocity change per XD motion review

- Fixed small bug causing RTE on orientation changes

- Fixed small bug causing RTE with empty list

- Added snapping and paging cases to MobileSkins app

- Added snapping and paging tests to mobile checkintests

QE notes:

Doc notes:

Bugs:

Reviewer: Jason Szeto

Tests run: checkintests, full Cyclone

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/airMobileBasicTests/src/mobile/scripts/ListSnappingTestScript.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/components/Scroller.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/renderers</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/airMobileBasicTests/src/mobile/views/ListPaging.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/views/MobileSkinsHomeView.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite1.jpg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite2.jpg</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite3.jpg</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/tests/airMobileBasicTests/src/airMobileBasicTests-config.xml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite4.jpg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/airMobileBasicTests/src/mobile/views/ListSnapping.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite5.jpg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/assets/yosemite6.jpg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/views/ListPagingView.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/airMobileBasicTests/src/mobile/scripts/ListPagingTestScript.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/renderers/ImageRenderer.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/tests/MobileSkins/src/views/ListSnappingView.mxml</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285385 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 21680

Author: jszeto@adobe.com

Date: 2011-07-21T21:56:22.533455Z

Log Message:

-----------

Item Snapping, SpinnerList and DateSpinner Initial checkin

Merging in changes from sandbox development branch

SpinnerList and DateSpinner are in usable states, but there is still unimplemented functionality.

QE notes: none

Doc notes: none

Bugs: none

Reviewer: Tom Kraikit, Eric Day, Jason Szeto

Tests run: checkintests, full cyclone

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile/SpinnerListSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile/DateSpinnerSkin.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/DateAndTimeRangeList.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/.settings/org.eclipse.core.resources.prefs</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile/SpinnerListScrollerSkin.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/components/ScrollSnappingMode.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/manifest.xml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/CalendarDate.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/DateSelectorDisplayMode.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/.settings</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile320/assets/SpinnerListContainerBackground.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile240/assets/SpinnerListContainerBackground.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src/DateSpinnerTest-app.xml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/effects/ThrowEffect.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile160/assets/SpinnerListContainerBackground.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/SpinnerListContainer.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/components/List.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src/views</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/layouts/VerticalSpinnerLayout.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/.flexProperties</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/libs</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/components/Scroller.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile/SpinnerListContainerSkin.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/.actionScriptProperties</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/bundles/en_US/components.properties</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/components/supportClasses/TouchScrollHelper.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile320/assets/TabbedViewNavigatorButtonBarFirstButton_down.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/SpinnerList.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src/DateSpinnerTest.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src/blackberry-tablet.xml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/src/views/DateSpinnerTestHomeView.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/DateSpinner.as</path>

<path kind="dir" action="M">/private/flex/sdk/branches/4.y</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/defaults.css</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile320/assets/SpinnerListContainerSelectionIndicator.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile240/assets/SpinnerListContainerSelectionIndicator.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/src/spark/components/SpinnerListItemRenderer.as</path>

<path kind="dir" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobilecomponents/.settings</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile160/assets/SpinnerListContainerSelectionIndicator.fxg</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/MobileThemeClasses.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/development/eclipse/flex/DateSpinnerTest/.project</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile320/assets/SpinnerListContainerShadow.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile240/assets/SpinnerListContainerShadow.fxg</path>

<path kind="file" action="A">/private/flex/sdk/branches/4.y/frameworks/projects/mobiletheme/src/spark/skins/mobile160/assets/SpinnerListContainerShadow.fxg</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285384 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 21298

Author: eday@adobe.com

Date: 2011-05-26T18:40:11.465737Z

Log Message:

-----------

Vertical and horizontal layout now always update content size: even if no items are visible.

QE notes: none

Doc notes: none

Bugs: SDK-30297

Reviewer: Hans

Tests run: checkintests, Cyclone

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/4.y/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285383 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 20555

Author: smgilson@adobe.com

Date: 2011-03-02T21:32:19.735501Z

Log Message:

-----------

minor ASdoc edits for max row/column count and baseline align

QE notes:

Doc notes:

Bugs:

Reviewer:

Tests run: checkintests

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/HGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/VGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285382 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19816

Author: rfrishbe@adobe.com

Date: 2011-01-20T00:06:35.709500Z

Log Message:

-----------

Cleaning up how virtualization works. Getting rid of an extra validateNow() and a setLayoutBoundsSize(0,0) call. Now when grabbing a virtual item renderer, we just "bring it up to speed" in that we are in the middle of an updateDisplayList() pass, so we force it to validateProperties() and validateSize(). It'll just validateDisplayList() naturally as part of the natural LayoutManager pass that it's already in the middle of.

The main performance boost comes from removing the setLayoutBoundsSize(0,0) call, which was already made in the justify layout case, so we shouldn't see a huge difference in Mobile performance; however, we should see a performance boost for scrolling virtual lists in general because of this.

QE notes: -

Doc notes:

Bugs: SDK-29057

Reviewer: Evtim, Hans

Tests run: checkintests, full mustella cyclone (tho I did make one minor change afterwards in DataGroup)

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285381 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19758

Author: aharui@adobe.com

Date: 2011-01-14T00:58:13.969259Z

Log Message:

-----------

reverting svn 19330 as it relied on svn 18635

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285380 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19635

Author: aharui@adobe.com

Date: 2011-01-07T00:25:18.039632Z

Log Message:

-----------

revert the layout changes from svn 18635. Management feels that there isn't enough time to thoroughly test the changes.

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/TextBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/layoutClasses/PriorityQueue.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/ScrollerLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/core/Application.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobiletheme/src/spark/skins/mobile/ViewNavigatorApplicationSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobiletheme/src/spark/skins/mobile/SkinnableContainerSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/RichEditableText.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/controls/SWFLoader.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/primitives/BitmapImage.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/primitives/supportClasses/GraphicElement.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/BasicLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobilecomponents/src/spark/components/IconItemRenderer.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Group.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobiletheme/src/spark/skins/mobile/ViewNavigatorSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/PopUpAnchor.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/flash-integration/src/mx/flash/UIMovieClip.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LinearLayoutVector.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/events/FlexEvent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/airspark/src/spark/components/Window.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/StyleProtoChain.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/core/SpriteVisualElement.as</path>

<path kind="file" action="D">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/IContainerInvalidating.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/DefaultItemRenderer.as</path>

<path kind="file" action="D">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/ILayoutManagerContainerClient.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGrid.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/GroupBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobiletheme/src/spark/skins/mobile/TabbedViewNavigatorApplicationSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/IStyleManager.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/ILayoutElement.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mobiletheme/src/spark/skins/mobile/TextAreaSkin.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/gridClasses/GridLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/airframework/src/mx/core/Window.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/TextFieldGridItemRendererInclude.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/StyleManagerImpl.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/core/Container.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/LayoutManager.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Application.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285379 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19330

Author: klin@adobe.com

Date: 2010-12-13T21:11:45.439252Z

Log Message:

-----------

Fix for DataGroup and List baselinePosition calculations. DataGroup now uses the typicalItem's renderer to calculate its baselinePosition. To do this, DataGroup delegates the calculations to the layout. ListBase uses the baselinePosition of the DataGroup to calculate its own.

QE notes: No

Doc notes: No

Bugs: SDK-28596

Reviewer: Hans

Tests run: cyclone server, checkintests

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285378 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19291

Author: klin@adobe.com

Date: 2010-12-10T21:58:08.665321Z

Log Message:

-----------

Removing excess ASDoc for verticalAlign and horizontalAlign.

QE notes: No

Doc notes: No

Bugs: SDK-28586

Reviewer: Carol

Tests run: checkintests

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285377 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19127

Author: aharui@adobe.com

Date: 2010-12-08T00:17:29.798813Z

Log Message:

-----------

Reset minorSize only in certain situations to prevent looping bug.

QE notes: none

Doc notes: none

Bugs: SDK-28585

Reviewer: Hans, Evtim

Tests run: checkintests mustella full run

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LinearLayoutVector.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285376 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19105

Author: gruehle@adobe.com

Date: 2010-12-07T19:03:28.396000Z

Log Message:

-----------

Fix off-by-one error in recent scroll optimizations.

QE notes:

Doc notes:

Bugs: SDK-28666, SDK-28667

Reviewer: Evtim

Tests run: checkintests

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285375 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 18799

Author: gruehle@adobe.com

Date: 2010-11-23T15:14:35.654523Z

Log Message:

-----------

Performance optimization when scrolling small amounts in VerticalLayout and HorizontalLayout. If the scroll can be done by simply changing scrollRect, don't call invalidateDisplayList() on the target.

QE notes: Keep an eye out for any visual artifacts when scrolling.

Doc notes: None

Bugs: None

Reviewer: Ryan, Evtim

Tests run: Full mustella pass on cyclone server

Is noteworthy for integration: Yes

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285374 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 18635

Author: aharui@adobe.com

Date: 2010-11-17T00:18:36.469040Z

Log Message:

-----------

Add estimatedSizes to the layout infrastructure to better deal with text reflow.

Add new events to layout infrastructure to deal with caching of size information

QE notes: New APIs and Interfaces

Doc notes: New APIs and interfaces

Bugs: SDK-27226, SDK-26155, SDK-25483, SDK-23621, SDK-27225, SDK-26993, SDK-25535, SDK-25521

Reviewer: Evtim

Tests run: checkintests mustella full run

Is noteworthy for integration: yes

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/TileLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/TextBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/layoutClasses/PriorityQueue.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/ScrollerLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/core/Application.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/RichEditableText.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/controls/SWFLoader.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/primitives/supportClasses/GraphicElement.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/BasicLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Group.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/PopUpAnchor.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/flash-integration/src/mx/flash/UIMovieClip.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/events/FlexEvent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/StyleProtoChain.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/core/SpriteVisualElement.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/IContainerInvalidating.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/tests/basicTests/spark/scripts/FormTestScript.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/ILayoutManagerContainerClient.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/DefaultItemRenderer.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/supportClasses/LayoutBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/supportClasses/GroupBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/IStyleManager.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/ILayoutElement.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/gridClasses/GridLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/TextFieldGridItemRendererInclude.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/StyleManagerImpl.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/core/Container.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/managers/LayoutManager.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Application.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285373 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 18145

Author: egeorgie@adobe.com

Date: 2010-10-13T20:16:24.277475Z

Log Message:

-----------

Fix SDK-28197 requestedMaxColumnCount in HorizontalLayout is not respected

The problem was we didn't take into account the maxRequested in the non-virtual code path.

QE notes:

Doc notes: None

Bugs: SDK-28197

Reviewer: Hans

Tests run: mustella cyclone

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285372 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 17882

Author: egeorgie@adobe.com

Date: 2010-09-27T18:53:27.336327Z

Log Message:

-----------

Add requestedMaxRowCount, requresteMaxColumnCount properties to HGroup/HorizontalLayout, VGroup/VerticalLayout

QE notes: Ready for testing

Doc notes: None.

Bugs: SDK-25364, SDK-20588

Reviewer: None.

Tests run: mustella cyclone

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/HGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/ComboBoxSkin.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/skins/spark/DropDownListSkin.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/wireframe/src/spark/skins/wireframe/ComboBoxSkin.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/wireframe/src/spark/skins/wireframe/DropDownListSkin.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/VGroup.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285371 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 17634

Author: egeorgie@adobe.com

Date: 2010-09-09T18:16:16.842150Z

Log Message:

-----------

Fix SDK-27326 Changing layout and item renderer at the same time causes RTE in LinearLayoutVector

In this change:

- instantiate the LLV on demand, release when layout is reset

QE notes: None

Doc notes: None

Bugs: SDK-27326

Reviewer: Hans

Tests run: full cyclone

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285370 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 17468

Author: klin@adobe.com

Date: 2010-08-24T20:48:50.296115Z

Log Message:

-----------

When measuring the layoutTarget's size, Horizontal/VerticalLayout will take into account the size of the live renderers if the target is a DataGroup. This will produce a better measured size when dealing with renderers that change size often. In measureVirtual(), we go through the live renderers and add their preferred size and subtract the cached size from the measured size.

QE notes: No

Doc notes: No

Bugs: SDK-25605

Reviewer: Evtim

Tests run: checkintests, VerticalLayout, HorizontalLayout

Is noteworthy for integration: No

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285369 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 16784

Author: aharui@adobe.com

Date: 2010-07-02T00:23:38.805179Z

Log Message:

-----------

numElements is an int, so use int in the loops so -1 doesn't get coerced silently to 2^32

QE notes: none

Doc notes: none

Bugs: SDK-25716

Reviewer: Corey

Tests run: checkintests mustella/gumbo/layout

Is noteworthy for integration: no

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/HorizontalLayout.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/layouts/VerticalLayout.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1285368 13f79535-47bb-0310-9956-ffa450edef68