Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FLEX-35375 CAUSE: DataGrids didn't dispatch a VALUE_COMMIT event when a new dataProvider cleared the selection, thus allowing the selectedItem, selectedIndex, selectedItems, selectedIndexes to become null without a notification. Which also means that if there was any binding set up for any of those variables, it won't be triggered. SOLUTION: we now dispatch a VALUE_COMMIT event when a new dataProvider ends up clearing the selection. NOTE: also added a unit test for this bug, which fails without the fix and passes with the above fix.

  1. … 2 more files in changeset.
FLEX-35082: Changed the way regex was being used to compare the given pattern for dataProvider objects in the findRowIndex / findRowIndices methods.

  1. … 1 more file in changeset.
FLEX-26808 Added unit tests to make sure that the selection (made either programmatically or through ctrl-clicking on the grid) is preserved when the user starts dragging the items. The tests pass locally.

-Also added VectorUtil.toArrayObject() to convert a Vector.<Object> to an Array (uses the same private function as VectorUtil.toArrayInt(), so I haven't added unit tests).

-Added a missing semicolon in Grid.as

  1. … 2 more files in changeset.
FLEX-26808 Minor refactoring while reading the code: asdocs improvements, and adding missing semicolon.

  1. … 2 more files in changeset.
FLEX-34838 CAUSE: When there is a column sort applied, GridItemEditor.save() is fooling the grid dataProvider into thinking that it's correctly sorted when it's not: by setting dataProvider.sort = null, making the desired change, and then re-setting the sort, the currently-edited row stays in the same position, but the dataProvider now believes the selectedItem is in the correct position given the sort (I say that because ListCollectionView.getItemIndex() uses the sort when it's not null, but that only works if all the items are correctly sorted).

SOLUTION:

GridItemEditor doesn't do the sort ignoring trick anymore, which means that if needed, the currently selected row will jump to another location based on the sorting rule, and that getItemIndex() will work correclty. To compensate for the row potentially jumping to another location, Grid now scrolls to where the item has landed.

  1. … 1 more file in changeset.
re-fix FLEX-34644. Wasn't handling scrolling correctly

FLEX-34644. DataGrid background was too big

FLEX-34228 missing ";" or ";" in wrong place

  1. … 28 more files in changeset.
FLEX-33992 fix zero division issue

FIXED broken mustella tests after : FIXED mispelled variable that caused getter to be used instead.

FIXED FLEX-33899 DataGrid goes blank when removing last item from dataProvider when requestedRowCount is set FIXED mispelled variable that caused getter to be used instead.

UPDATE FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed) => also handle case when collection.source is set but collection.refresh() is not called, [Mustella test pass] - gumbo/components/DataGrid/Properties - gumbo/components/DataGrid/Styles

REFIX FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed

[Mustella test pass]

- gumbo/components/DataGrid/Properties

- gumbo/components/DataGrid/Styles

  1. … 1 more file in changeset.
UNDO FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed ) UNDO Fix https://issues.apache.org/jira/browse/FLEX-33818 (Spark Datagrid column resize and sort bug when releasing mouse outside of headers)

  1. … 1 more file in changeset.
FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed ) FIX minor ASDOC wording in CalloutSkin for desktop

  1. … 1 more file in changeset.
FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

Correcting ASDOC comments.

FLEX-33526: Changed null test of dataProvider to be more consistent

  1. … 1 more file in changeset.
FLEX-33526: Added null test for values array.

  1. … 1 more file in changeset.
FLEX-33526: Added the findRowIndices method to allow array values.

  1. … 3 more files in changeset.
FLEX-33498: Corrected asdoc changes from a merge issue.

  1. … 2 more files in changeset.
FLEX-33498: Adding new feature for dataProvider/selectedIndex supporting components. This covers; Grid, DataGrid, ListBase, ComboBox, DropDownList, List, ButtonBar, TabBar, ButtonBarBase

  1. … 4 more files in changeset.
FLEX-33190: Corrected ASDOC comments to use the new release version that it was tested with.

  1. … 2 more files in changeset.
Fixed HTML formating so class correctly compiles in asdocs

Adding more datagrid double click modes

  1. … 3 more files in changeset.
FLEX-33328 - Merge Adobe.next bug fixes and new features into spark DataGrid. The new features include the new properties lockedRowCount, lockedColumnCount, multiColumnSortingEnabled, and moving and sorting columns via the keyboard. The DataGrid does size a bit differently mostly due to bug fixes. The skin changed because of new parts introduced for the locked rows and columns so custom skins need to be upgraded which is easy to do.

The mustella tests for the existing features pass on OSX. No mustella tests have been added yet for the new features.

The new features may need a bit more work but given all the existing tests pass the DataGrid should be pretty stable if you don't use any of the new features.

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/sdk/branches/develop@1425063 13f79535-47bb-0310-9956-ffa450edef68

  1. … 138 more files in changeset.
Transferred from the Adobe Open Source Subversion Repository

Revision: 23247

Author: cframpto@adobe.com

Date: 2011-12-20T19:21:13.134833Z

Log Message:

-----------

Remove ADOBE SYSTEMS license and replace with Apache license in headers - frameworks. A 2nd pass will be needed to get the files not handled up by the scripts.

Modified Paths:

--------------

4959 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1279039 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23246

Author: cframpto@adobe.com

Date: 2011-12-20T17:40:08.069454Z

Log Message:

-----------

Rollback 23243. If comment followed header it was stripped as well.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1279038 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23243

Author: cframpto@adobe.com

Date: 2011-12-20T00:59:57.384047Z

Log Message:

-----------

In frameworks, remove Adobe headers from all files except xml/mxml file types. There are also a few .txt files that are license files that I didn't touch yet.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1279037 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 20622

Author: klin@adobe.com

Date: 2011-03-04T23:55:42.632363Z

Log Message:

-----------

Fix renderer properties not being updated when hover/caretIndicator are null. When the hover/caretIndicator doesn't exist, we weren't invalidating the display list when the hover or caret indices changed even though the renderers may depend on those indices.

QE notes: No

Doc notes: No

Bugs: SDK-29677

Reviewer: Hans

Tests run: cyclone server, checkintests

Is noteworthy for integration: No

Modified Paths:

--------------

/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Grid.as

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1279036 13f79535-47bb-0310-9956-ffa450edef68