Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FLEX-34880 Added an asdoc recommendation that developers use Sort and SortField as immutable objects, although the current API allows for mutability.

  1. … 2 more files in changeset.
Revert FLEX-34880 part 3

This reverts commit 2b09e327281211d26d65dd5d061b02d645cbdd39.

  1. … 9 more files in changeset.
FLEX-34880 Placed only one state setter (SortField.compareFunction) behind mx_internal (thus also renaming it to SortField.compareFunction_) to provide the template for the others. Also removed it from the interface (ISortField).

  1. … 9 more files in changeset.
FLEX-34979 Adding Apache header.

FLEX-34979 CAUSE: The transformation of the spark Sort and SortField from extending AdvancedStyleClient to implementing its interfaces and using an instance of it as a class member had some more bugs: -the id setter didn't exist -when AdvancedStyleClient dispatched an event, Sort / SortField didn't pick up on it and dispatch forward -When AdvancedStyleClient initialized it added itself as a styleClient to the document. This is undesired for Sort and SortField because from then on the style code would used the AdvancedStyleClient member instead of the Sort / SortField instances, as before, which meant that their relevant functions (such as setStyle or styleChanged) were never called.

SOLUTION:

-there is now an id setter in AdvancedStyleClientImplementation

-AdvancedStyleClient_ was introduced to be able to override some functions of AdvancedStyleClient

-Sort and SortField now listen to the events dispatched via their AdvancedStyleClient_ member and pass on the events if there's a listener for them

-on initialization we now add the Sort / SortField instances as styleClients to the document instead of their AdvancedStyleClient members, which should now be hidden from any code interacting with Sort and SortField (this is achieved in AdvancedStyleClient_)

-all the instances where AdvancedStyleClient interacted with the StyleProtoChain using 'this' were changed into using the Sort / SortField instances

NOTES:

-Since some of the public functions in AdvancedStyleClient (getStyle, setStyle, styleChanged) are also called internally from other AdvancedStyleClient functions (or could be, in the future), and we need them to hit the Sort / SortField implementations instead, AdvancedStyleClient_ now overrides those functions and makes sure that the Sort / SortField versions are called.

-AdvancedStyleClient.setDeferredStyles() was made protected so that AdvancedStyleClient_.as can override it to make sure that StyleProtoChain.setStyle is always called referring to Sort or SortField instead of the instance of AdvancedStyleClient_ they use internally.

    • -1
    • +23
    ./AdvancedStyleClientImplementation.as
    • -0
    • +107
    ./AdvancedStyleClient_.as
  1. … 1 more file in changeset.
FLEX-34979 CAUSE: When the transition was made from the spark Sort and SortField extending AdvancedStyleClient to implementing its interfaces, the omission was that only IAdvancedStyleClient was implemented, as opposed to all three relevant interfaces (IAdvancedStyleClient, IFlexModule, IMXMLObject). More specifically the mustella failures reflected that the function initialized() wasn't present anymore, as that function, called automatically by the framework, is responsible for registering the Sort and SortField instances with the IFlexModuleFactory implementor (FlexModuleFactory or SystemManager, etc.).

SOLUTION:

The spark versions of Sort and SortField now also implement IFlexModule and IMXMLObject via AdvancedStyleClientImplementation.

NOTES:

-also cleaned some imports in AdvancedStyleClient.

    • -0
    • +22
    ./AdvancedStyleClientImplementation.as
  1. … 1 more file in changeset.
FLEX-34837 Making sure that sorting with complex fields is the same as with simple fields in terms of locale awareness. For this I created a spark ComplexSortField which extends the spark SortField (and is thus locale-aware) and adds in the functionality for complex fields. Then GridSortFieldComplex could extend this version, to make sure that locale is handled correctly.

    • -0
    • +53
    ./ComplexSortField.as
  1. … 2 more files in changeset.
FLEX-34854 spark.collections.Sort.sort() was very similar to mx.collections.Sort.sort(), with the only difference in the fact that the latter tried to use Array.sortOn when appropriate. So, to remove the duplication I introduced a new flag to the mx version called useSortOn, which the spark version defaults to false. This way I could completely remove spark.collections.Sort.sort() and reset a few members of the mx version as private, as before.

  1. … 1 more file in changeset.
FLEX-34854 The spark Sort now extends the mx version, to prevent the need of changing both classes when a bug is fixed or a feature is implemented. NOTES: -this is a result of the mailing list discussion entitled 'Can we unify spark and mx Sort and SortField?'. -some members of mx.collections.Sort needed to be marked protected so that the sort() function could access them. In the next commit they will be reverted by implementing a way in which the sort() function doesn't need to be overridden. -mx.collections.Sort needed to have a new method, createEmptySortField(), which is now used by noFieldsCompare(), and that ensures that the differences in spark.collections.Sort.noFieldsCompare() are preserved without having to copy-paste the entire method.

  1. … 1 more file in changeset.
FLEX-34854 FLEX-34884 Mirror of commit 047017398a2ccea7ddb2b0300ec4a184ad7f9ab6 for the spark version of Sort.as.

FLEX-34854 FLEX-34852 Removing unused variables. NOTE: this mirrors commit 5a27cc8044e4e7a8e22cb2c75037bb9356d6d128.

FLEX-34854 Changes to asdocs comments to get the spark and mx versions of Sort.as more similar.

  1. … 1 more file in changeset.
FLEX-34854 The spark SortField now extends the mx version, to prevent the need of changing both classes when a bug is fixed or a feature is implemented. NOTES: -this is a result of the mailing list discussion entitled 'Can we unify spark and mx Sort and SortField?'. -the compareFunction getter and setter have been kept only for the asdoc comment to show the differences between the spark and mx SortField. -the spark DataGrid was using AdvancedStyleClient to refer to spark SortFields instead of the interface, IAdvancedStyleClient. This needed to be corrected, because the spark SortField does not extend AdvancedStyleClient anymore. -SortField.stringCompare() and .xmlCompare() needed to be protected (they were private) so that they could be overridden in spark SortField.

    • -0
    • +144
    ./AdvancedStyleClientImplementation.as
  1. … 2 more files in changeset.
FLEX-34884 The new function added to ISortField impacted GridSortField and the spark SortField as well, so I added these functions there too. Currently they are not being called, so it's safe. But soon they will, once all the changes from the mx side will be made onto the spark side of sorting.

  1. … 1 more file in changeset.
FLEX-34853, FLEX-34879 CAUSE: ListCollectionView.getItemIndex() uses findItem() which, along with findFirst(), findAny() and findLast(), always use the Sort to do the searching if the collection is already sorted. However, this assumes that all the current properties of Sort (including the properties of its SortFields) accurately represent the current sorting order in the collection, which is not the case. The reason is that one can change any property of Sort and SortField without the collection noticing. This leads to the error.

SOLUTION:

After discussing it with Alex H, I decided to implement a step-by-step transformation of SortField and Sort into true (i.e. immutable) value objects. They are suited to this design pattern because they have no identity, and the fact that they are now mutable has allowed this bug to exist. This way, no property will be changeable on SortField and Sort without recreating an object (and potentially cloning an existing one).

This first step (FLEX-34879) is to mark the setters and the reverse() functions as deprecated for the next release, and to ensure that users can specify all the state fields directly in the constructors.

  1. … 4 more files in changeset.
FLEX-34838 Corrected some AsDocs, changed variable names from 'type' (reserved keyword) to other names, and removed unused variables.

  1. … 5 more files in changeset.
make catch block empty to improve performance

Fixed malformed asdocs comments

  1. … 1 more file in changeset.
FLEX-33702: Added sortCompareType to AdvancedDataGrid and corrected some spelling.

  1. … 3 more files in changeset.
FLEX-33702: Added column sort type access to the datagrid columns.

    • -0
    • +119
    ./SortFieldCompareTypes.as
  1. … 6 more files in changeset.
revert addition of removeItem to IList. It was breaking third-party Ilist impls, including LCDS DataList

  1. … 4 more files in changeset.
Be consistant with creating new Arrays and Objects

  1. … 32 more files in changeset.
implement removeItem method from IList in the rest of classes implementing the interface in the flex-sdk

  1. … 8 more files in changeset.
FLEX-33328 - Merge Adobe.next bug fixes and new features into spark DataGrid. The new features include the new properties lockedRowCount, lockedColumnCount, multiColumnSortingEnabled, and moving and sorting columns via the keyboard. The DataGrid does size a bit differently mostly due to bug fixes. The skin changed because of new parts introduced for the locked rows and columns so custom skins need to be upgraded which is easy to do.

The mustella tests for the existing features pass on OSX. No mustella tests have been added yet for the new features.

The new features may need a bit more work but given all the existing tests pass the DataGrid should be pretty stable if you don't use any of the new features.

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/sdk/branches/develop@1425063 13f79535-47bb-0310-9956-ffa450edef68

  1. … 138 more files in changeset.
Transferred from the Adobe Open Source Subversion Repository

Revision: 23247

Author: cframpto@adobe.com

Date: 2011-12-20T19:21:13.134833Z

Log Message:

-----------

Remove ADOBE SYSTEMS license and replace with Apache license in headers - frameworks. A 2nd pass will be needed to get the files not handled up by the scripts.

Modified Paths:

--------------

4959 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278169 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23246

Author: cframpto@adobe.com

Date: 2011-12-20T17:40:08.069454Z

Log Message:

-----------

Rollback 23243. If comment followed header it was stripped as well.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278168 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23243

Author: cframpto@adobe.com

Date: 2011-12-20T00:59:57.384047Z

Log Message:

-----------

In frameworks, remove Adobe headers from all files except xml/mxml file types. There are also a few .txt files that are license files that I didn't touch yet.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278167 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 20322

Author: mhorn@adobe.com

Date: 2011-02-15T18:47:39.396141Z

Log Message:

-----------

asdoc updates

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278166 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 20013

Author: harishs@adobe.com

Date: 2011-01-31T15:32:09.255609Z

Log Message:

-----------

QE notes: Globalization changes. Full cyclone run has been done. Default locale changes and sort bug fixes since Dec 14 2010

Doc notes: ASDOC comments for all classes have been updated.

Bugs: SDK-29132 SDK-29127 SDK-28163 SDK-29075 SDK-28600 SDK-28492 SDK-28856

Reviewer: Gordon Smith, Xie Fang, Zhigang Qi

Tests run: cyclone and checkintests

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/AdvancedStyleClient.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/NumberValidatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/GlobalizationValidatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/supportClasses/CollatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/NumberFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/CurrencyFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/NumberValidator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/DateTimeFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/CurrencyValidator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Group.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/supportClasses/GlobalizationBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/GlobalizationUtils.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/SortingCollator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/StringTools.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/LastOperationStatus.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/supportClasses/NumberFormatterBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/MatchingCollator.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278165 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19226

Author: harishs@adobe.com

Date: 2010-12-09T18:33:35.483731Z

Log Message:

-----------

QE notes:

Doc notes: Updated asdocs for spark validators/sort/sortfield

Bugs:

Reviewer:

Tests run:

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="D">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/MatchingCollatorExample.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/SortField.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/examples/SortingCollatorExample.mxml</path>

<path kind="file" action="D">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/SortingCollatorExample.mxml</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/examples/StringToolsExample.mxml</path>

<path kind="dir" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/examples</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

<path kind="file" action="D">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/StringToolsExample.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/NumberValidator.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/asdoc/en_US/spark/globalization/examples/MatchingCollatorExample.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/CurrencyValidator.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1278164 13f79535-47bb-0310-9956-ffa450edef68