Clone Tools
  • last updated 14 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FLEX-34853, FLEX-34879 CAUSE: ListCollectionView.getItemIndex() uses findItem() which, along with findFirst(), findAny() and findLast(), always use the Sort to do the searching if the collection is already sorted. However, this assumes that all the current properties of Sort (including the properties of its SortFields) accurately represent the current sorting order in the collection, which is not the case. The reason is that one can change any property of Sort and SortField without the collection noticing. This leads to the error.

SOLUTION:

After discussing it with Alex H, I decided to implement a step-by-step transformation of SortField and Sort into true (i.e. immutable) value objects. They are suited to this design pattern because they have no identity, and the fact that they are now mutable has allowed this bug to exist. This way, no property will be changeable on SortField and Sort without recreating an object (and potentially cloning an existing one).

This first step (FLEX-34879) is to mark the setters and the reverse() functions as deprecated for the next release, and to ensure that users can specify all the state fields directly in the constructors.

  1. … 5 more files in changeset.
FLEX-34854 Minor changes to imports, asdocs and removing an unused variable.

  1. … 3 more files in changeset.
Transferred from the Adobe Open Source Subversion Repository

Revision: 23247

Author: cframpto@adobe.com

Date: 2011-12-20T19:21:13.134833Z

Log Message:

-----------

Remove ADOBE SYSTEMS license and replace with Apache license in headers - frameworks. A 2nd pass will be needed to get the files not handled up by the scripts.

Modified Paths:

--------------

4959 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258665 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23246

Author: cframpto@adobe.com

Date: 2011-12-20T17:40:08.069454Z

Log Message:

-----------

Rollback 23243. If comment followed header it was stripped as well.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258664 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 23243

Author: cframpto@adobe.com

Date: 2011-12-20T00:59:57.384047Z

Log Message:

-----------

In frameworks, remove Adobe headers from all files except xml/mxml file types. There are also a few .txt files that are license files that I didn't touch yet.

Modified Paths:

--------------

2361 paths were modified

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258663 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 20013

Author: harishs@adobe.com

Date: 2011-01-31T15:32:09.255609Z

Log Message:

-----------

QE notes: Globalization changes. Full cyclone run has been done. Default locale changes and sort bug fixes since Dec 14 2010

Doc notes: ASDOC comments for all classes have been updated.

Bugs: SDK-29132 SDK-29127 SDK-28163 SDK-29075 SDK-28600 SDK-28492 SDK-28856

Reviewer: Gordon Smith, Xie Fang, Zhigang Qi

Tests run: cyclone and checkintests

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/styles/AdvancedStyleClient.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/NumberValidatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/GlobalizationValidatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/supportClasses/CollatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/NumberFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/CurrencyFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/NumberValidator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/DateTimeFormatter.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/CurrencyValidator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Group.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/supportClasses/GlobalizationBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/GlobalizationUtils.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/SortingCollator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/StringTools.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/LastOperationStatus.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/formatters/supportClasses/NumberFormatterBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/globalization/MatchingCollator.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258662 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19749

Author: cframpto@adobe.com

Date: 2011-01-13T23:22:00.733543Z

Log Message:

-----------

If Sort/findItem throws a SortError exception because the find criteria doesn't exist in the sorted list, ListCollectionView/findItem will now return -1. Add @throw to the ASdoc for ISort/findItem so that the docs match the current behavior for both the mx and spark versions of Sort/findItem.

QE notes:

Doc notes:

Bugs: SDK-28640, SDK-29101

Reviewer: Kevin, Hans

Tests run: cyclone

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ListCollectionView.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258661 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19318

Author: harishs@adobe.com

Date: 2010-12-13T19:22:11.302860Z

Log Message:

-----------

QE notes: Pulling back rev 19300 as it makes somes tests compilation fail...

Doc notes:

Bugs:

Reviewer:

Tests run:

Is noteworthy for integration:

Modified Paths:

--------------

/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258660 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19300

Author: harishs@adobe.com

Date: 2010-12-11T17:05:41.985690Z

Log Message:

-----------

QE notes:

Doc notes:

Bugs: No bugs fixed. Just applied code reveiw feedback.

Reviewer: Gordon Smith

Tests run: checkintests and full cyclone tests.

Is noteworthy for integration:

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258659 13f79535-47bb-0310-9956-ffa450edef68

Transferred from the Adobe Open Source Subversion Repository

Revision: 19060

Author: harishs@adobe.com

Date: 2010-12-06T17:34:15.020965Z

Log Message:

-----------

QE notes: Did checkintests, performed full cyclone run. There were 19 failures in mustella report. QE Judy (Mingzhou Gao and Joann Chung Anderson) confirmed that they are known problems.

Doc notes: As part of Sort and Sortfield updates, the asdoc comments were updated to reflect globalization changes.

Bugs: Fixed sdk-28493, 28691,28494, 28345, 28320, 28387, 28314, 28145

Reviewer: Gordon Smith

Tests run: cyclone, checkintests, bugs testfiles

Is noteworthy for integration: Sort and Sortfield updated with globalization support using the new spark globalization sort classes.

Number and CurrencyValidators support national digits and unicode minus symbols.

groupingPattern property dropped for Number and Currency Validators.

Modified Paths:

--------------

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/tests/basicTests/BasicTests-config.xml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/controls/DataGrid.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/NumberValidatorBase.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ICollectionView.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/spark-manifest.xml</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ISortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/tests/basicTests/BasicTests.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/DataGrid.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/NumberValidator.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/advancedgrids/src/mx/olap/OLAPCube.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/CurrencyValidator.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections/SortField.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/core/UIComponent.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/bundles/en_US/validators.properties</path>

<path kind="dir" action="A">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/collections</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/mx/src/mx/controls/treeClasses/HierarchicalCollectionView.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ListCollectionView.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/components/Group.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/spark/src/spark/validators/supportClasses/GlobalizationUtils.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/advancedgrids/src/mx/olap/DefaultCubeImpl.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/tests/basicTests/spark/scripts/SortTestScript.mxml</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionView.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/Sort.as</path>

<path kind="file" action="M">/private/flex/sdk/branches/hero_private/frameworks/projects/framework/src/mx/collections/ModifiedCollectionView.as</path>

<path kind="file" action="A">/private/flex/sdk/branches/hero_private/frameworks/tests/basicTests/spark/views/SortTests.mxml</path>

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1258658 13f79535-47bb-0310-9956-ffa450edef68

Initial directories and placeholder files

git-svn-id: https://svn.apache.org/repos/asf/incubator/flex/trunk@1247405 13f79535-47bb-0310-9956-ffa450edef68

  1. … 2637 more files in changeset.