Clone Tools
  • last updated 16 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Fix package name of spark/components/MobileBusyIndicator.as Fix constructor name

Add Apache license header

Add android4 specific TextSkinBase

Add AndroidPlatformVersionOverride to FrameworkClasses

FLEX-34034 handle degenerate case when copying single newline into TextInput

another test commit, testing using my apache username on commit

fix missing slash

remove temp target

My test commit to repo

Let's make magic happen

Renaming class to AndroidPlatformVersionOverride as that makes more sense

Adding a mixin to set android os version during AIR simulation Updated android4x.css with os-version media queries.

    • -251
    • +253
add release target to convert final rc

sdk rcs have release notes in them

FLEX-34460 adt is missing in windows install

switch version to 4.14

  1. … 9 more files in changeset.
ant script to generate release candidates for the sdk

    • -0
    • +463
add signing targets

FLEX-34458 CAUSE: Because HierarchicalCollectionViewCursor uses both relative and absolute bookmarks in the various collections of the hierarchy, there needs to be special treatment for these two cases. Namely, while it works great with absolute bookmarks to call .movePrevious on the bookmark when something is deleted in the same collection before the selected item, it doesn't work well for the relative CursorBookmark.LAST currentChildBookmark value. Because HierarchicalCollectionViewCursor.collectionChangeHandler() did not make any difference between absolute and relative bookmarks, it used to call .movePrevious() on the bookmark even if it was the absolute value CursorBookmark.LAST.


In this situation we don't need to .movePrevious() when items above are deleted, because CursorBookmark.LAST will always point to the last item in the collection, no matter what changes happened to that collection.

FLEX-34458 Added a unit test which reproduces the bug (which means it currently fails).

FLEX-34456 CAUSE: When a HierarchicalCollectionViewCursor reacted to a deletion before another cursor, it deleted the parent mappings of the deleted nodes (even if it didn't need to make any changes to its internal state). Since these mappings are on the HierarchicalCollectionView, the next cursor to react to the same deletion would compute that the parent of the deleted node is null, and everything went bad from there. In other words, if two or more cursors are created on the same HierarchicalCollectionView, they will work against each other when deletions occur (or replacements, which HierarchicalCollectionView transforms into deletions). I think that the mapping deletions happened because HierarchicalCollectionViewCursor was written with the assumption that there would only be one cursor for each collection.


Now we're making it HierarchicalCollectionView's job to remove the parent mappings of all the affected nodes after it gives all the cursors the chance to react to the deletion.


-As part of this change I realised that the conditions for an if clause introduced for FLEX-34424 were not enough: in order to choose strategy 2) (see revision 82d6b51 for details) for adjusting the cursor position, not only does current need to be null, but afterLast and beforeFirst need to be false (because if they are true, it's expected and correct that current == null).

-This led me to notice that HierarchicalCollectionViewCursor.beforeFirst was true if current == null && currentIndex <= collection.length, which doesn't make sense. In fact, these conditions correctly determine the FLEX-34424 situation, in which the item at the current index doesn't exist anymore, which makes current null, although currentIndex is within bounds. (Another clue that the condition for beforeFirst is wrong is ListCollectionView.beforeFirst, which checks the index against -1, rather than allowing any index up to the collection length.) So I changed this to check for any value < 0.

-I also made HierarchicalCollectionView.parentMap private instead of accessible from other classes (like HierarchicalCollectionViewCursor), and made the operations on it (deletions and additions) accessible only through functions, rather than using the map directly, as before.

-Both the above changes also affected LeafNodeCursor, which also had a defective beforeFirst getter, and also directly manipulated the collection's parentMap.

-Also removed unused variables from HierarchicalCollectionView.removeChild() and .collectionChangeHandler().

Merge remote-tracking branch 'origin/develop' into FLEX-34119

FLEX-34456 Added a unit test which reproduces the bug.

correct case for osmf.swc so compiles on Linux work

FLEX-34450 updated baseline image

FLEX-34450 remove now redundant email domain length checks from locale unit tests

FLEX-34450 - remove invalid domain checks from thise locale because the length is no longer checked

Adding fonts. Edit the LICENSE file to mention the font files

Fix FLEX-34450 by removing the length checks for the last part of an email domain Update Mustella tests to mathc new behaviour i.e. the tests should now return valid

FLEX-34424 CAUSE: HierarchicalCollectionViewCursor deals with deletions of nodes before the current node in two distinct ways: 1) relatively: if it's possible, it calls movePrevious() as many times as the number of nodes removed; if not, 2) absolutely: it seeks to the location of the first deleted node from the beginning of the hierarchy. The problem was in the conditions used to determine whether to use method 1) or 2): indeed, method 1) should be used when the node that used to be at 'currentIndex' has been directly affected by the deletion (i.e. that node is among the ones deleted). However, it should also be used when it has been indirectly (but irretrievably) affected, because enough nodes have been removed from its siblings collection that there is no item anymore on the value of the CursorBookmark we have stored for it (i.e. if it was the 8th node in a collection of 9 nodes, and two nodes before it have been deleted, there's no 8th node to retrieve anymore). The way we know this is that HierarchicalCollectionViewCursor.current now returns null. (So when 'current' was null, it was impossible to retrieve the parent stack of the items up to the root, and everything would fail from there onward.)


Choose deletion strategy 1) when 'current == null'.


-This now makes HierarchicalCollectionViewCursor_FLEX_34424_Test pass.

-This implies that the computation of the parent nodes (in the 'parentStack' array) now happens after this check, whereas it used to happen before.

-It also implies that the index HierarchicalCollectionViewCursor seeks to in strategy 1) is different when 'current == null' (namely, it's 'currentIndex - n').

-Renamed some variables in these conditional statements, to make it easier to decypher what is happening.

FLEX-34424 Improved the unit test by making it parameterized and adding a few more cases.