Clone Tools
  • last updated 11 mins ago
Constraints: committers
Constraints: files
Constraints: dates
changed primary email @https://github.com/settings/emails to see if it shows up in the commit

testing write access for user kmg

Merge remote-tracking branch 'origin/develop' into develop

Compiler: fixed issue where adding an id to a fx:Vector when using -keep compiler argument would result in a compiler error because the wrong class was imported in the generated code for the bindable property.

getMultiName() in flex2.compiler.as3.binding.Info wasn't treating __AS3__.vec.Vector.<T> the same as __AS3__.vec:Vector.<T>, causing it to return the wrong namespace and class name.

Compiler: fixed an issue where adding a subclass of a Vector's type to the Vector in MXML would result in an internal build error because the subclass didn't get added as a dependency.

Example MXML that causes build error:

<fx:Vector type="mx.core.UIComponent">



I discovered that it would work fine if another Button was added elsewhere in the MXML document, so I figured that somehow the Vector's items weren't checked for dependencies.

Fixed by passing the VectorNode to the same analyze() function used for ArrayNode in the private DependencyAnalyzer class in InterfaceCompiler at the end of the analyze() function for VectorNode. There is no analyze() function for ArrayNode, so I determined that it must fall back to the version with the parameter typed as Node. Originally, the analyze() function for VectorNode only grabbed the Vector's type as a dependency and didn't look at the items added to the Vector.

git test, user name change

git test

sometime target hasn't finished loading?

    • -0
    • +3
add more diagnostics to comparebitmap

    • -0
    • +4
Merge branch 'FLEX-34837' into develop



FLEX-34854 Minor changes to imports, asdocs and removing an unused variable.

FLEX-34852 Alex H rightly pointed out that there can be objects with fields that contain "." in them. So I added a unit test to cater for this scenario, which changes the way this feature can be implemented.

FLEX-34852 FLEX-34853 Due to many bugs which link sorting a ListCollectionView and getItemIndex / removeAll throwing a fatal error (e.g. FLEX-22649, FLEX-34838, FLEX-4705), we're adding these methods at the end of each (applicable) test. NOTE that this way we opened FLEX-34853.

FLEX-34837 Added two more test functions to make sure that sorting with a custom compare function works well despite using a SortField with a complex field for its name. They do pass, indeed.

FLEX-34837 Making the code intention more explicit and removing an IntelliJ code analysis warning.

FLEX-34852 FLEX-34837 Making sure that flexunit tests are run for the framework project, in which ListCollectionView resides. Note that this will introduce some failing tests in the nightly build until this ticket is closed.

    • -0
    • +6
FLEX-34852 Added another test class to test the basic functionality of sorting (using simple fields). That's because we have to make sure that we don't break existing functionality when adding the feature of sorting by complex fields. Currently all functions pass.

FLEX-34837 Added another test function to test the basic functionality of sorting by complex fields. (Note that because the feature isn't yet implemented, this also fails currently.)

Renamed VOs in the default package so as not to clash with future others that might have the same name.

FLEX-34837 Renamed VOs in the default package so as not to clash with future others that might have the same name.

FLEX-34850 forgot import.

FLEX-34850 Making the column sorting identical, whether or not the dataField is complex.

FLEX-32249 Now AdvancedDataGrid.makeListData() uses the HierarchicalCollectionViewCursor through its IHierarchicalCollectionViewCursor interface, so that other cursors can be used which don't extend HierarchicalCollectionViewCursor.

FLEX-34838 CAUSE: When there is a column sort applied, GridItemEditor.save() is fooling the grid dataProvider into thinking that it's correctly sorted when it's not: by setting dataProvider.sort = null, making the desired change, and then re-setting the sort, the currently-edited row stays in the same position, but the dataProvider now believes the selectedItem is in the correct position given the sort (I say that because ListCollectionView.getItemIndex() uses the sort when it's not null, but that only works if all the items are correctly sorted).


GridItemEditor doesn't do the sort ignoring trick anymore, which means that if needed, the currently selected row will jump to another location based on the sorting rule, and that getItemIndex() will work correclty. To compensate for the row potentially jumping to another location, Grid now scrolls to where the item has landed.

fix: Regression in fdb tool: commands using line number as the only argument fail, like: list 8 or break 8

FLEX-34751: Regression in fdb tool: VM is resumed if breakpoint can't be set

FLEX-34837 Added a unit test to reproduce the bug.

FLEX-34838 Corrected some AsDocs, changed variable names from 'type' (reserved keyword) to other names, and removed unused variables.

git test

FLEX-34824: Add WaitForCondition mustella script

Wait for an ActionScript condition to become true before

continuing to the next step.

    • -0
    • +150