Clone Tools
  • last updated a few minutes ago
Constraints: committers
Constraints: files
Constraints: dates
FLEX-34456 Added a unit test which reproduces the bug.

correct case for osmf.swc so compiles on Linux work

FLEX-34450 updated baseline image

FLEX-34450 remove now redundant email domain length checks from locale unit tests

FLEX-34450 - remove invalid domain checks from thise locale because the length is no longer checked

Adding fonts. Edit the LICENSE file to mention the font files

Fix FLEX-34450 by removing the length checks for the last part of an email domain Update Mustella tests to mathc new behaviour i.e. the tests should now return valid

FLEX-34424 CAUSE: HierarchicalCollectionViewCursor deals with deletions of nodes before the current node in two distinct ways: 1) relatively: if it's possible, it calls movePrevious() as many times as the number of nodes removed; if not, 2) absolutely: it seeks to the location of the first deleted node from the beginning of the hierarchy. The problem was in the conditions used to determine whether to use method 1) or 2): indeed, method 1) should be used when the node that used to be at 'currentIndex' has been directly affected by the deletion (i.e. that node is among the ones deleted). However, it should also be used when it has been indirectly (but irretrievably) affected, because enough nodes have been removed from its siblings collection that there is no item anymore on the value of the CursorBookmark we have stored for it (i.e. if it was the 8th node in a collection of 9 nodes, and two nodes before it have been deleted, there's no 8th node to retrieve anymore). The way we know this is that HierarchicalCollectionViewCursor.current now returns null. (So when 'current' was null, it was impossible to retrieve the parent stack of the items up to the root, and everything would fail from there onward.)


Choose deletion strategy 1) when 'current == null'.


-This now makes HierarchicalCollectionViewCursor_FLEX_34424_Test pass.

-This implies that the computation of the parent nodes (in the 'parentStack' array) now happens after this check, whereas it used to happen before.

-It also implies that the index HierarchicalCollectionViewCursor seeks to in strategy 1) is different when 'current == null' (namely, it's 'currentIndex - n').

-Renamed some variables in these conditional statements, to make it easier to decypher what is happening.

FLEX-34424 Improved the unit test by making it parameterized and adding a few more cases.

FLEX-34424 Added a unit test to reproduce FLEX-34424. As expected, it is currently failing. Also added a few more tests to HierarchicalCollectionViewCursor_Basics_Test to do with the deletion of nodes. These are currently passing.

FLEX-34440 CAUSE: When HierarchicalCollectionView converts a CollectionEventKind.REPLACE CollectionEvent into a CollectionEventKind.REMOVE one, it also deletes the parent(s) of the replaced node root(s). However, if the HierarchicalCollectionViewCursor which then immediately responds to this converted event (in collectionChangeHandler()) happens to have its 'current' node inside the replaced branch, it will fail to retrieve all the parents of the current node, because the parent of the root of the branch has been deleted. This is problematic, because HierarchicalCollectionViewCursor.collectionChangeHandler assumes that parentStack and parentBookmarkStack have the same number of items, and that any item in the latter array represents the position (CursorBookmark) of an item in the former array in its siblings collection. So it will try to use a parentBookmarkStack item on a different collection to which it was created on, thus throwing a 'Bookmark no longer valid' CollectionViewError.


HierarchicalCollectionView.nestedCollectionChangeHandler now deletes the parent(s) of the replaced node root(s) *after* dispatching the converted CollectionEvent, as opposed to *before*.


-This now makes HierarchicalCollectionViewCursor_FLEX_34440_Test pass.

-Also removed three unused local variables from HierarchicalCollectionView.nestedCollectionChangeHandler.

FLEX-34119 FLEX-34440 Renaming variables to make code more readable.

FLEX-34119 FLEX-34440 changing the package of the unit tests (and helper classes) to mx.collections.

FLEX-34440 Added unit test to reproduce FLEX-34440. This also required a few changes in HierarchicalCollectionViewTestUtils.

FLEX-34119 FLEX-34440 Adding the setItemAt() operation to HierarchicalCollectionViewCursor_FLEX_34119_Test, which uncovers FLEX-34440. Separate unit test for FLEX-34440 will follow.

New Android4.x skin for ViewMenu and ViewMenuItems that matches

fixed MD5s for FP 13 and 14

FLEX-34119 Renamed a Boolean for clarity in HierarchicalCollectionViewCursor.collectionChangeHandler.

FLEX-34119 Simplified two if statements, removed an unused variable, and removed Duplicate variable definition warnings in HierarchicalCollectionViewCursor.

FLEX-34119 Adding some explanations on the main unit test.

FLEX-34119 CAUSE: HierarchicalCollectionViewCursor.collectionChangeHandler dealt with CollectionEventKind.ADD and CollectionEventKind.REMOVE events in a defective way: when the event happened before the currently-selected node, but in a different collection from the selected node, it assumed that it could use the currentChildBookmark to correct the position of the bookmark in that collection. However, currentChildBookmark can only be used on the collection it was created in, which is the collection of the currently-selected node and its siblings. This made ListCollectionView.getBookmarkIndex throw the 'Bookmark no longer valid' error.


In the case detailed above instead of changing the currentChildBookmark we need to adjust the bookmark associated with the collection that the changing (i.e. added or removed) node is in.


-Another problem in HierarchicalCollectionViewCursor.collectionChangeHandler was that currentChildBookmark was (attempted to be) updated with the corrected position of the parent of the changing node's sibling collection. However, currentChildBookmark represents the position of the currently-selected item, and should only be updated when the selected item's siblings collection changes, not when other collections change. Instead, we need to update the parentBookmarkStack collection, which contains the positions of the selected node's parents' positions in their collections.

-After these changes HierarchicalCollectionViewCursor_FLEX_34119_Test doesn't show any more 'Bookmark no longer valid' errors. (But it still fails due to FLEX-34424).

FLEX-34119 Adding two unit tests for HierarchicalCollectionViewCursor (HCVC). HierarchicalCollectionViewCursor_Basics_Test is meant to ensure that HCVC works as expected in non-corner cases (it's definitely incomplete, and could use more tests. I created it mainly to test the few functions I needed when working with FLEX-34119), while HierarchicalCollectionViewCursor_FLEX_34119_Test reproduces the FLEX-34119 bug (and, incidentally, also uncovered FLEX-34424). FYI The latter test lasts just under 3 minutes on my machine.

    • -0
    • +62
Skins for VScrollBar and HScrollBar

FLEX-34119 renaming variables for increased readability.

merge 4.13.0 to master

merge 4.13.0 to develop

Fix MenuBar.styleChanged() crash bug

menuBarItems.length may be modified as a result of calling getMenuAt(), so we should not save the length value before entering a loop.

Added Polish language properties file to flex sdk

    • -1
    • +1
Merge branch 'develop' of https://git-wip-us.apache.org/repos/asf/flex-sdk into develop

Added with Polish language properties file to flex sdk

    • -0
    • +125