Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DRILL-7414: EVF incorrectly sets buffer writer index after rollover

Enabling the vector validator on the "new" scan operator, in cases

in which overflow occurs, identified that the DrillBuf writer index

was not properly set for repeated vectors.

Enables such checking, adds unit tests, and fixes the writer index

issue.

closes #1878

  1. … 3 more files in changeset.
DRILL-7412: Minor unit test improvements

Many tests intentionally trigger errors. A debug-only log setting

sent those errors to stdout. The resulting stack dumps simply cluttered

the test output, so disabled error output to the console.

Drill can apply bounds checks to vectors. Tests run via Maven

enable bounds checking. Now, bounds checking is also enabled in

"debug mode" (when assertions are enabled, as in an IDE.)

Drill contains two test frameworks. The older BaseTestQuery was

marked as deprecated, but many tests still use it and are unlikely

to be changed soon. So, removed the deprecated marker to reduce the

number of spurious warnings.

Also includes a number of minor clean-ups.

closes #1876

  1. … 15 more files in changeset.
DRILL-7401: Upgrade to SqlLine 1.9.0

closes #1875

  1. … 3 more files in changeset.
DRILL-7402: Suppress batch dumps for expected failures in tests

Drill provides a way to dump the last few batches when an error

occurs. However, in tests, we often deliberately cause something

to fail. In this case, the batch dump is unnecessary.

This enhancement adds a config property, disabled in tests, that

controls the dump activity. The option is enabled in the one test

that needs it enabled.

closes #1872

  1. … 3 more files in changeset.
DRILL-7403: Validate batch checks, vector integretity in unit tests

Enhances the existing record batch checks to check all the various

batch record counts, and to more fully validate all vector types.

This code revealed that virtually all record batches have

problems: they omit setting some record count or other, they

introduce some form of vector corruption.

Since we want things to work as we make fixes, this change enables

the checks for only one record batch: the "new" scan. Others are

to come as they are fixed.

closes #1871

  1. … 1 more file in changeset.
DRILL-7385: Convert PCAP Format Plugin to EVF

    • -0
    • +330
    ./java/org/apache/drill/exec/store/pcap/PcapBatchReader.java
  1. … 2 more files in changeset.
DRILL-6096: Provide mechanism to configure text writer configuration

1. Usage of format plugin configuration allows to specify line and field delimiters, quotes and escape characters.

2. Usage of system / session options allows to specify if writer should add headers, force quotes.

closes #1873

    • -0
    • +7
    ./java/org/apache/drill/exec/ExecConstants.java
  1. … 5 more files in changeset.
DRILL-7377: Nested schemas for dynamic EVF columns

The Result Set Loader (part of EVF) allows adding columns up-front

before reading rows (so-called "early schema.") Such schemas allow

nested columns (maps with members, repeated lists with a type, etc.)

The Result Set Loader also allows adding columns dynamically

while loading data (so-called "late schema".) Previously, the code

assumed that columns would be added top-down: first the map, then

the map's contents, etc.

Charles found a need to allow adding a nested column (a repeated

list with a declared list type.)

This patch revises the code to use the same mechanism in both the

early- and late-schema cases, allowing adding nested columns at

any time.

Testing: Added a new unit test case for the repeated list late

schema with content case.

  1. … 2 more files in changeset.
DRILL-7358: Fix COUNT(*) for empty text files

Fixes a subtle error when a text file has a header (and so has a

schema), but is in a COUNT(*) query, so that no columns are

projected. Ensures that, in this case, an empty schema is

treated as a valid result set.

Tests: updated CSV tests to include this case.

closes #1867

  1. … 2 more files in changeset.
DRILL-5983: Add missing nullable Parquet readers for INT and UINT logical types

closes #1866

DRILL-7170: Ignore uninitialized vector containers for OOM error messages

DRILL-7254: Read Hive union w/o nulls

  1. … 19 more files in changeset.
DRILL-7387: Failed to get value by int key from map nested into struct

  1. … 2 more files in changeset.
DRILL-7380: Query of a field inside of an array of structs returns null

1. Fixed parquet reader projection for Logical lists (DrillParquetReader.java)

2. Fixed projection pushdown for RexFieldAccess (ProjectFieldsVisitor.java)

3. DrillParquetReader.getProjection(...) splitted into few methods

4. Added javadocs for PathSegment and SchemaPath

  1. … 5 more files in changeset.
DRILL-7357: Expose Drill Metastore data through information_schema

1. Add additional columns to TABLES and COLUMNS tables.

2. Add PARTITIONS table.

3. General refactoring to adjust information_schema data retrieval from multiple sources.

closes #1860

    • -0
    • +216
    ./java/org/apache/drill/exec/store/ischema/FilterEvaluator.java
    • -0
    • +413
    ./java/org/apache/drill/exec/store/ischema/RecordCollector.java
  1. … 19 more files in changeset.
DRILL-7373: Fix problems involving reading from DICT type

- Fixed FieldIdUtil to resolve reading from DICT for some complex cases;

- optimized reading from DICT given a key by passing an appropriate Object type to DictReader#find(...) and DictReader#read(...) methods when schema is known (e.g. when reading from Hive tables) instead of generating it on fly based on int or String path and key type;

- fixed error when accessing value by not existing key value in Avro table.

  1. … 7 more files in changeset.
DRILL-7376: Drill ignores Hive schema for MaprDB tables when group scan has star column

  1. … 3 more files in changeset.
DRILL-7368: Fix Iceberg Metastore failure when filter column contains nulls

    • -12
    • +25
    ./java/org/apache/drill/exec/ops/FragmentContext.java
  1. … 6 more files in changeset.
DRILL-7369: Schema for MaprDB tables is not used for the case when several fields are queried

closes #1852

DRILL-7252: Read Hive map using Dict<K,V> vector

  1. … 14 more files in changeset.
DRILL-7367: Remove Server details from response headers

closes #1851

  1. … 1 more file in changeset.
DRILL-7168: Implement ALTER SCHEMA ADD / REMOVE commands

    • -9
    • +112
    ./codegen/includes/parserImpls.ftl
  1. … 7 more files in changeset.
DRILL-7362: COUNT(*) on JSON with outer list results in JsonParse error

closes #1849

  1. … 1 more file in changeset.
DRILL-7360: Refactor WatchService in Drillbit class and fix concurrency issues

DRILL-7222: Visualize estimated and actual row counts for a query

With statistics in place, it is useful to have the estimated rowcount along side the actual rowcount query profile's operator overview. A toggle button allows this with the estimated rows hidden by default

We can extract this from the Physical Plan section of the profile.

Added a toggle-ready table-column header

closes #1779

    • -0
    • +2
    ./java/org/apache/drill/exec/ExecConstants.java
    • -7
    • +57
    ./resources/rest/profile/profile.ftl
DRILL-7356: Introduce session options for the Drill Metastore

closes #1846

    • -0
    • +63
    ./java/org/apache/drill/exec/ExecConstants.java
DRILL-7326: Support repeated lists for CTAS parquet format

closes #1844

    • -2
    • +105
    ./codegen/templates/ParquetOutputRecordWriter.java
  1. … 2 more files in changeset.
DRILL-7350: Move RowSet related classes from test folder

  1. … 278 more files in changeset.
DRILL-7338: REST API calls to Drill fail due to insufficient heap memory

This PR allows for the 85% threshold to be customizable with a value of 0 meant for disabling.

closes #1837

    • -0
    • +2
    ./java/org/apache/drill/exec/ExecConstants.java
DRILL-4517: Support reading empty Parquet files

1. Modified flat and complex parquet readers to output schema only when requested number of records to read is 0. In this case readers are not initialized to improve performance.

2. Allowed reading requested number of rows instead of all rows in the row group (DRILL-6528).

3. Fixed issue with nulls number determination in the row group (fixed IsPredicate#isAllNulls method).

4. Allowed reading empty parquet files via adding empty / fake row group.

5. General refactoring and unit tests.

6. Parquet tests categorization.

closes #1839

  1. … 34 more files in changeset.