asterixdb

Clone Tools
  • last updated 20 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][FUN] Introduce IEvaluatorContext

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Introduce IEvaluatorContext - a context for evaluators

that is available both at runtime and during constant

folding at compile time

- IEvaluatorContext provides access to IHyracksTaskContext

which is only available at runtime. At compile time this

accessor returns null

- Instantiate evaluators with IEvaluatorContext

instead of IHyracksTaskContext

Change-Id: Iff90c7739e46d6602fcd0609e67f6a8cd9714ca5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3481

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 675 more files in changeset.
[ASTERIXDB-2607][RT][*DB] Fix detecting duplicate fields in record construction

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Fix detecting duplicate field names in record construction.

Change-Id: Ib11647cee4e6dd07f04b9e91ce03cb72f293bcb2

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3479

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[ASTERIXDB-2575][RT][FUN] Remove usages of ComparisonHelper

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Remove usages of ComparisonHelper and switch to logical or physical

comparators.

- updated RecordReplace test cases that used to throw an exception

when comparing complex types.

- cleaned up interval classes.

- fixed getStartOffset() in AIntervalPointable.

- removed ComparisonHelper

Change-Id: Ib2a05f35c752e1d2ecfdbabbf5d303ea73c7c9db

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3470

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE] Add documentation for bitwise functions

Add Bitwise functions document

Add Bitwise functions to SQL++ ToC

Add Bitwise functions to POM

Update examples to match other builtin functions

Include other corrections

Edits after review of patch base 2

Change-Id: I17a119b12c6e23d5e2d22f2159cd1ce00b9be5cf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3471

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

    • -0
    • +653
    /asterixdb/asterix-doc/src/main/markdown/builtins/15_bitwise.md
[NO ISSUE][COMP] Add support for compiler warnings

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Add support for compiler warnings during parsing,

AST rewriting and query optimization phases

- SQL++ parser emits warnings for unknown hints in

relational expression, between expression,

groupby clause and function call.

- Optimizer emits warning if hash group by hint cannot

be applied because there's no serializable aggregate

- Added testcases for these new warnings

Change-Id: Ic3c1e98c183cd214eea3e4fee24b2b7c46366b52

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3476

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 24 more files in changeset.
Merge commit '0561d10' from stabilization-f69489

Change-Id: I18115329ce7ab3501e7fcc9c6dc06d0e87c97688

[NO ISSUE] Document ROUND function

Add round() 2-args version documentation

Edits after review of patch 1

Change-Id: Id9087e61a11f643cb8b5ee881c35901a737bd4a4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3472

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

[ASTERIXDB-2597] Load UDFs via HTTP

- POST existing UDF format to /admin/udf/$DATAVERSE/$LIBNAME

- DELETE against that URL to remove UDFs

Change-Id: I6be9fef54c010bdb32f5c78af9b973f9843f442f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3386

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@uci.edu>

  1. … 23 more files in changeset.
[NO ISSUE][COMP] Option to disable DisjunctivePredicateToJoinRule

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Added compiler option "rewrite_or_as_join" that

disables DisjunctivePredicateToJoinRule

set rewrite_or_as_join "false";

Default value is 'true' (the rule is enabled)

Change-Id: Ifbde19b7371a351d13ac2b05efa70a42eddbae7b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3468

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 13 more files in changeset.
[NO ISSUE][REPL] Suspend Dataset Checkpointing on Replica Sync

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Before synchronizing replicas, stop datasets checkpointing to

prevent new files from being generated due to async IO operations

triggered by checkpointing.

- Instead of sync'ing current files to replicas then scheduling a flush

and sync'ing any newly generated files, just flush datasets before

the initial sync then sync all the files in one go.

Change-Id: I058fd48bc0fb89a1e16448ce516c3410bb4d681d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3469

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Merge commit 'fa6ce67' from stabilization-f69489

Change-Id: I01e1810f1c44d9ecaf569dd22577c33e8702c682

[NO ISSUE] Reorganize OVER clause documentation

- Move OVER clause into Query doc

- Add link to window function calls from Expressions

- Update links to OVER clause

- Update ToCs with new location of OVER clause

- Standardize IDs

- Correct capitalization for admonition headings

- Correct indentation in Window Function doc

- Separate ToCs for SQL++ and AQL builtins

Change-Id: I683d024c56fcc55d67e1f87eec5494781bbcdede

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3464

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +34
    /asterixdb/asterix-doc/src/main/markdown/builtins/0_toc_aql.md
    • -0
    • +35
    /asterixdb/asterix-doc/src/main/markdown/builtins/0_toc_sqlpp.md
[NO ISSUE][COMP] Fix variable handling in Intersect operator

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Create separate lists for output compare and

extra variables in Intersect logical operator

- Align accessor method for input extra variables

with the one for input compare variables

- Remove getInputVariables() from Intersect operator

because these variables are already provided by

getInputCompareVariables() and getInputExtraVariables()

Change-Id: I4f436566e743d7e908a72bfa502c138ae7b99c6c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3460

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE] Correct markup for window function documentation

Correct indentation for code and follow-on paragraphs in bullets.

More descriptive aliases in LEAD and LAG examples.

Change-Id: I34627d2b50b18d4e429e43807161b85eeab9e730

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3452

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[ASTERIXDB-2598][RT] Add Support For Runtime Warnings

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Add the ability to add runtime warnings per task

and return the generated warnings as part of the

task profile on task completion.

- On successful job completion, aggregate warnings

from all task profiles of a job.

- Return the generated warnings in the query service

response as an array of "warnings" each with a code,

which is currently hard-coded to 1, and a message.

- Fix propagating source location to scalar aggregate

functions.

- Add a flag in test cases definition to indicate whether

or not to check for expected warnings and default it to

false.

- Generate warnings when min/max functions encounter

incomparable type or unsupported input.

- Add support in test framework to extract warnings

along with extracting the result field.

- Add support in test framework to validate generated

and expected warnings.

- Add test cases for min/max generated warnings.

Change-Id: I52fa5b807799487d62e67a8861068e1547aa629a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3451

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 19 more files in changeset.
[ASTERIXDB-2593][FUN] TPC-DS always parallelize + gen all tables

- user model changes: yes

- user can call the tpcds_datagen() by passing only the scaling

factor, and that will automatically generate all the tables.

- storage format changes: no

- interface changes: no

Details:

- Added support to a second version of the tpcds_datagen()

function to take only a single parameter that will result in

generating the data for all the tables in one go. The user

now can generate the data for a single table at a time, or

all the tables in one go.

- Overridden the behavior for activating the parallelism.

Before, the library wouldn't activate parallelism unless

the tables are big, and the number of data generated per

table is over 1,000,000. With this change, the parallelism

is always activated, regardless of the table size or the

data size being generated.

- Added a new test, TPCExecutionTest, to execute the long

tests for the TPC. Some of the TPC tests take longer than

5 minutes to finish and could result in high usage of

disk space.

Change-Id: Iff199b0c533d22bcae1caf5057788b257ba4e486

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3437

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 6 more files in changeset.
[NO ISSUE][COMP] Stop reusing variables of Intersect operator

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Intersect operator's input variables should not be reused as

its output variables (fixed IntroduceSelectAccessMethodRule

and IntroduceLSMComponentFilterRule)

- Remove HeuristicOptimizer.isHyracksOp() and updated

ExtractCommonOperatorsRule to use isMicroOperator() instead

- When copying Intersect operator OperatorDeepCopyVisitor now

properly handles its two kinds input variables

- Clear additional state in IntroduceSelectAccessMethodRule.clear()

and OptimizableOperatorSubTree.reset()

- Added testcases for index intersection

Change-Id: I551819b828450760797f6b29af02aad4e124646c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3450

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 14 more files in changeset.
[NO ISSUE] Document window functions.

Add new window function document.

Add new window clause (OVER clause) document.

Update Query document:

- update list of aggregate functions,

- update list of syntactic sugar functions.

Update Aggregate SQL Function document:

- add link for DISTINCT keyword,

- add link for window clause,

- add link for SQL standard functions.

Add extra blank line if file ends with indented code.

Add OVER to reserved keywords.

Update Functions ToC.

Update Builtins POM.

Updates after comments on patch set 1.

Data format for RANGE boundary / ordering expression.

Fixed typos.

Change-Id: I52d6e97a27c2fa51208810c6ac3d98cb21a0e2b1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3448

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +1307
    /asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md
    • -0
    • +345
    /asterixdb/asterix-doc/src/main/markdown/builtins/15_over.md
[NO ISSUE][FUN] Allow frame in RATIO_TO_REPORT()

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support frame specification in RATIO_TO_REPORT()

window function call

Change-Id: Ibc3686bebaf791aa84ef34d8fd143e53edc7856a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3449

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE] Fix error message thrown by ATypeHierarchy

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Align type mismatch error message thrown by ATypeHierarchy

with the one produced by TypeMismatchException

Change-Id: I830e93056d18123610b933a0e36fd1b54c6e140b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3441

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE] Increase Result Set TTL to 30 mins

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Some tests (like TPC-DS) take a long time to complete,

this would result in a timeout of the result set and failing

the test. This change increase the TTL for the result set.

Change-Id: I352924a865a2bd93f7254afaa0855e2caa715e39

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3447

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][REPL] Wait For Dataset IO Before Replica Sync

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Add API in DatasetLifecycleManager to wait for IO on datasets

matching a replication strategy.

- Before synchronizing the files on a replica, wait for any

on-going IO operations on replicated datasets to make sure

the set of files won't change while the replica is being

synchronized (e.g. a merge operation won't delete a file

that we wanted to send to a replica).

Change-Id: I01ed5c9379cf7ae249faeef624d5226ea699cf22

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3446

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[NO ISSUE][MTD] Fix Reading Dataset Compression From Dataset Record

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fix reading the dataset compression scheme by reading its

value from the compression record rather than the dataset record.

Change-Id: I3bdb1f64143fed43dc9eb37cf8a2fadbfd37dfde

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3445

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Wail Alkowaileet <wael.y.k@gmail.com>

[NO ISSUE][OTH] Use Request Stats When Printing Results on NC

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- When printing a result on an NC, use the stats object

of the original request rather than the object received

from the CC as part of the execute statement response

message. This is done because the metrics returned to the

user are generated from the stats object of the request.

- Add metrics test case to sqlpp test suite to test returning

metrics from NCQueryServiceServlet.

Change-Id: I54c3b3e72cfb0c2499a95bfc0f514dd5d6774293

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3444

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE][FUN] Allow ORDER BY in RATIO_TO_REPORT()

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support ORDER BY specification in RATIO_TO_REPORT()

window function call

Change-Id: I031b3eff1aee8be12f1943d39f5f1c640476e4e8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3442

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE][DASH] Plan Format, Flat Nested Objects on Table

- user model changes: no

- storage format changes: no

- interface changes: no

- Plan Format: JSON | STRING

- Flat Nested Objects

- Supporting offline fonts

Change-Id: I7a27a5576ae21b6fda440bfc281d25e62638515c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2936

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 37 more files in changeset.
[NO ISSUE][OTH] Skip Calling Job Result Callback For Unknown Jobs

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Skip calling the job result callback on a job's completion

when the job's result record is not found. This can happen

if a job's execution time exceeds the result's TTL in which

case we remove the job's result reference.

Change-Id: I7ba09da4292213b63d2396d21969329e86634c06

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3439

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

[NO ISSUE][COMP] Do not inline non-functional LET clauses

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- When inlining LET clauses in LET ... SELECT ...

skip those that contain non-functional expressions

Change-Id: I3740745e2e8c8a0bb11aa7908e68c682dd9a5553

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3436

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE][FUN] round() remove unnecessary Math.abs()

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Removed unnecessary Math.abs().

Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3438

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[ASTERIXDB-2584][FUN] Support rounding digit for round()

- user model changes: yes

- user can pass optional 2nd argument to round() function

to specify the digit to round to.

- storage format changes: no

- interface changes: no

Details:

- Added new descriptor for 2-arguments version of round().

- Converted evaluator class to named class, now used by both

round() descriptors.

- Added test cases for 2-arguments version and invalid cases.

Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3433

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 6 more files in changeset.