Clone
Abdullah Alamoudi <bamousaa@gmail.com>
committed
on 24 Aug 17
[ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup
- user model changes: no
- storage format changes: no
- interface changes… Show more
[ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup

- user model changes: no

- storage format changes: no

- interface changes: yes

 --IJobManager.cancel now takes a callback

details:

- Job cancellation now completes only after the job cleanup work

 has completed and not merely when the abort tasks are executed.

- The NCQueryServiceServlet actively cancels requests that passes

 5 minutes.

- Cancellation of timedout jobs is not done through the Http API

 but through message broker.

- Typically, requests might timeout when the servers are

 overloaded. When that is the case, there is a high chance http

 requests are to be rejected including requests to cancel

 previously submitted queries. This is the reason for using

 Message broker for this task.

- ExecuteStatementRequest used to execute the statement in

 a different executor thread even though it is itself is being

 executed in an executor thread and is not blocking anyone.

 This was fixed as well.

Change-Id: I14b4bbd512cc88e489254d8bf82edba0fd3a3db5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1961

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Show less

master + 5 more