Clone
Murtadha Makki Al Hubail
committed
on 20 Nov 17
[NO ISSUE][TX] Make TxnLogFile Close Idempotent
- user model changes: no
- storage format changes: no
- interface changes: yes
Renamed ILo… Show more
[NO ISSUE][TX] Make TxnLogFile Close Idempotent

- user model changes: no

- storage format changes: no

- interface changes: yes

 Renamed ILogReader.initializeScan to setPosition and added

 javadocs.

Details:

Currently there is an explicit check that the file channel

of a TxnLogFile is open before closing it. However, the

channel could be closed due to interrupts and therefore

we should remove the explicit check and always try to close

it. However, we should always decrement the TxnLogFile

references counter even if the channel is not open since

that TxnLogFile is not accessed anymore.

Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2165

Reviewed-by: Till Westmann <tillw@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Show less

master + 3 more