Clone Tools
  • last updated 20 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "[NO ISSUE][RT] Profiling fixes"

This reverts commit c775dd9d2c01a66b9f2da8447c75400bac6ddf90.

Reason for revert: makes CB test hang now?

Change-Id: I64a67157d2485741edb7cc2890ae80ab84c70ee5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4803

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 1 more file in changeset.
Merge branch 'gerrit/mad-hatter'

Change-Id: If1c03edce783ccd249d90383da938132ae654886

  1. … 3 more files in changeset.
Merge branch 'gerrit/stabilization-f69489'

Change-Id: Ic49fc22902c43b4043b207351ee0dd9e4a9232d7

[NO ISSUE][NET] Utilize unresolved NC reg address

Follow on change to https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4643

which correctly consumes the unresolved NC registration addresses

made available in the previous change.

Change-Id: I316a37cc92da2f4bbb8990a3f0a43dd36095c47f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4683

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Merge branch 'gerrit/stabilization-f69489'

Change-Id: I5b75e79a5dbe74314fec8b9ef7734a792ca5731c

  1. … 2 more files in changeset.
[NO ISSUE][NET] Use unresolved address on NC reg

When NCs are configured with a public cluster address, this address

should not be resolved on the NC but rather on the CC. Depending on

the network configuration, the public address may resolve differently

on the CC.

This change maintains backwards compatibility with old NCs or CCs

Change-Id: I8fb2a40a8407c985eb174d09c2b7bb59949812f2

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4643

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2688][HYR] Fix use of a Hyracks task across join stages

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

In hash join, a task from the build stage is being used in the probe stage.

This is a problem since such tasks have already finished and notified the CC they are done.

One observed issue is related to issuing a warning in the probe phase where some warnings are

not reported because they are issued to tasks that have finished (the way this happened is that

a comparator was created in the build phase using the build-phase task. Then, this comparator

was used in the probe phase and issued a warning).

- make IHyracksJobletContext extend IHyracksCommonContext so that it is also a frame manager context

- make activites of join operators use the joblet context instead of the task context for acquiring buffers

- create the probe-to-build comparator in the probe phase so that the right task is used in the comparator

Change-Id: I38a4a779b9620494f15606162f0f1e9487fd0984

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4563

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Michael Blow <mblow@apache.org>

[NO ISSUE][NET] Ensure Channel Was Not Recycled Before Adding Credit

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Before attempting to add credit to an existing channel,

ensure the channel slot was not recycled and reused by a

new channel. Without this, some additional credit might

erroneously be added to the new channel.

Change-Id: I0a5ec70ad4c2568477fac9eb98c030fc3d8b1ce9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4623

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Contrib: Michael Blow <mblow@apache.org>

[ASTERIXDB-2687][RT] Issue a warning when incomparable types are compared

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Issue a warning when NULL was returned as the result of a comparison

of 2 incomparable types.

- added error/warning code 49

- refactored dot format plans generator

- removed some AQL tests that are already covered in SQL++ tests

Change-Id: Iad3127e4db775315817a7819feea6aa12e4de2ea

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4464

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 38 more files in changeset.
[NO ISSUE][TEST] Canonicalize file outputs in test framework

Change-Id: Ib707c5426d2f5b9f8b285e19a2eacddc091ce57a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4463

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 2 more files in changeset.
Merge branch 'gerrit/stabilization-f69489' into 'gerrit/mad-hatter'

Change-Id: I17edb6b03563ac527bcad39f93193067ee42a33d

  1. … 1 more file in changeset.
[ASTERIXDB-2686][RT] Delete run files eagerly

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Delete run files eagerly.

Change-Id: Idc780b44b0554bf36e2378700aae1b38b8e57353

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4403

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 6 more files in changeset.
[NO ISSUE][HYR] Add FunctionalInterface annotation

Change-Id: I7cdc0ac896ef9e856742e86eabcf77edf490e469

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4383

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

[ASTERIXDB-2680][FUN] Add support to regexp_matches() and regexp_split()

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Added support to regexp_matches().

- Added support to regexp_split().

- Added test cases for regexp_matches().

- Added test cases for regexp_split().

- Changed behavior of UTF8CharSequence when

subSequence is called with start = end, originally

it returns a null char[] array which causes an NPE,

now it returns an empty char[].

Change-Id: Iccf5ba14f5c8b8cf4bcd6dd6e412bb515d68dd74

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4243

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 36 more files in changeset.
[NO ISSUE][RT] Profiling fixes

- Fix profile serialization for profiles > 64kb in size

- Break deadlock for OperatorNodePushables that keep initialize() open

and call downstream operators that block until other operators have

initialized (e.g. Intersect).

Change-Id: I87ec970eaf2d5db76e7bfaa60be9190efb1a70ae

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4263

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Sandeep Gupta <Sandeep.gupta@couchbase.com>

  1. … 1 more file in changeset.
[NO ISSUE] Make MetadataProvider extensible

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Allow product extensions to provide custom

implementation of MetadataProvider

- Modify 'async-deferred' testcases to

request 'Clean-JSON' output

Change-Id: I485073e6a9ec7e36083da6f50a8df63a37b2668b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4224

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 35 more files in changeset.
[NO ISSUE][RT] Fail Fast When Interrupted on Frame Write Attempt

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Before writing a frame to the next operator, check the thread

interrupted status and fail fast if the thread is interrupted.

This ensures that queries that were aborted will fail as soon

as they attempt to write a frame.

Change-Id: If4f154f11305e2f8286e0707b5b3adec905633a4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4203

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

[NO ISSUE] Support multipart dataverse names

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Support dataverse names that consist of multiple parts

- Introduce DataverseName class and adopt it throughout the system

- Add testcases for multipart dataverse names

Change-Id: I1313b2dc0e8df6a9b0ded48dea122afc3ba5dbe7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4004

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 282 more files in changeset.
Merge branch 'gerrit/stabilization-f69489' into 'gerrit/mad-hatter'

Change-Id: I831c9c7c37ecf757ebaa707be5c394105302da13

  1. … 10 more files in changeset.
[NO ISSUE] Update dependencies

Change-Id: I7c668c680057344c7f83c600a2e9adff43a2fefc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4063

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 11 more files in changeset.
[ASTERIXDB-2672][API] Change the valid values for "format" request parameter

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Allowed values for "format" request parameter: json, csv, adm.

- Recognizable format values in "Accept":

application/x-adm

application/json

application/json;lossless=true/false

text/csv

text/csv;header=present/absent

Test framework changes:

- ResultExtractor: if the OutputFormat is json/lossless-json, print the "result"

field of the response similar to how adm would be printed, one json value

per line (and using same spacing).

- Changed some queries that use "EXPLAIN SELECT..." and specify OutputFormat as JSON.

The queries extension is ".plans.sqlpp". "param optimized-logical-plan:string=true"

is specified in those queries to print the logical plan in the "plans" field of

the response.

- added "// compareunorderedarray=true" for test quries that use .regexjson to compare

one json value against another where the order of elements in a json array is not

deterministic.

- TestExecutor: OutputFormat.LOSSLESS_JSON & OutputFormat.CSV_HEADER formats are set

in the "Accept". Otherwise, the desired format is set in the "format" request

parameter as usual.

- TestHelper: changed "equalJson()" to allow comparing json array in two modes.

- Removed some test cases that used to set mime types in the "format" request parameter

since now it's not allowed to do so.

Change-Id: Ie3c7a35446322c2d97679e7e724b9778e2a4ba83

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4043

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 32 more files in changeset.
[NO ISSUE][NET] Split delivery of messages and exceptions

- user model changes: no

- storage format changes: no

- interface changes: yes

Change-Id: I5a97e1eb1e2a3ec207591b3d5b8b7f1949a80fbc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4025

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][STO] Force Checkpoints/Index Metadata Files to Disk

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Ensure the system checkpoint file is forced to disk.

- Ensure index metadata files and checkpoints are forced

to disk.

Change-Id: I27ab8ed39e23760b514640d77532a1dc24a97992

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3943

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 3 more files in changeset.
[ASTERIXDB-2659][API] validate request parameters

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Return 400 BAD request for invalid request parameters.

- Changes in specifying the output format:

HEADER "Accept": application/json;lossless=<BOOLEAN>, text/csv;header=absent/present, application/x-adm

Request parameter "format": csv, json (and above mime types)

- when format is supplied in "Accept", only validate value of attribute if the mime is one of the above

and the attribute name is one of the above (header & lossless).

Change-Id: Ia89fa3179cc36a73fe950f41eab1f0a9d17a541c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3767

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

  1. … 80 more files in changeset.
[NO ISSUE][NET] Exclude Warn Logs When No Buffer Factory is Used

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Do not warn about recycled partial frames when no buffer

factory is set in FullFrameChannelReadInterface as those

are valid cases that use a single frame to perform the

complete operation.

Change-Id: I80251c529eb15ee22d01c320883418ea80272c2c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3824

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[NO ISSUE][HYR][STO] Remove unnecessary serialization support

Change-Id: I1f3932005cac33fef5096af4a772b401ad0a7fd1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3803

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][STO] Persist Bloom Filter Existence in Index Metadata

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- To clearly identify whether an index has a bloom filter or

not for BTree indexes, persist this information in the index's

metadata stored on each NC.

- For backward compatibility, when reading an index's metadata that

was created before adding the hasBloomFilter field, default its

value based on whether or not the index is a primary key index.

- Remove unused special readObject from LSMBTreeLocalResource.

Change-Id: Icec570d490987de401c036790ee9567238a60301

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3804

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 6 more files in changeset.
[NO ISSUE][RT] Report Disk IO Per Operator

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Do not collect per thread stats when runtime

profiling is disabled.

- Include per operator disk IO in task profile.

- Remove aggregated disk IO count from the query

response metrics.

- Adapt test cases.

Change-Id: Iced174ae5d4fa9ca13f597325cbb66ff80819e71

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3783

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Murtadha Hubail <mhubail@apache.org>

  1. … 17 more files in changeset.
[NO ISSUE][OTH] Eliminate Object Creation on Thread Stats Lookup

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Use the thread object for thread stats lookup

rather than the thread id to avoid boxed objects

creation on stats lookup.

Change-Id: I5b8b26be9d3439889e21cf097ea86c413e973e1d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3763

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2656] Remove frame constraint in HHJ probe

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

During the probe phase, we should not have the 1-frame

limit for spilled partitions. It wastes the memory and

leads to flushing small objects directly to the disk as

a large object.

Change-Id: I7580ecbe7db36d018348cd82d3864ca6c2ff439d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3703

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>