Clone Tools
  • last updated 14 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][OTH] Move Network Tracing Logs to Trace Level

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Iebc13ff6cb7b3c9086c19597ec982061672a891f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2848

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

  1. … 9 more files in changeset.
[NO ISSUE][NET] Set Handle State on Connect Failure

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Update the handle state to CLOSED when

the handle is closed after failure to

connect attempt.

Change-Id: I866ba42f5433e1d9d312b6c0ab19296cad4d20f3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2838

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE] Allow MetadataProvider config to store non String values

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- In many cases, we would like to associate a value with a key

in MetadataProvider to be accessed during the compilation

of jobs. However, currently, there is no place to store

such values, so we ended up storing them in the config

map.

- The config map is a <String, String> map and so, we would

write our values as a string and then parse them when needed.

- To avoid this, and to avoid introducing a new map, we simply

change the config stored in MetadataProvider from <String,String>

to <String, Object>.

Change-Id: I55b392ad199d74b0f3cffdc38b54593b12ec1a06

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2795

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

  1. … 23 more files in changeset.
[NO ISSUE][OTH] Remove Unused Interfaces

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Remove unused interfaces.

Change-Id: I966cdf028d08ac74ec60d3922ce97130221da68f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2635

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 13 more files in changeset.
[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Refactor IPCConnectionManager.

- Halt on IPC message serialization failures.

- Ensure channels and handles are closed on connection

failures.

- Remove IPCHandle unneeded CONNECT_FAILED state.

- Fix RegisterNodeWork failure handling.

- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2617

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -138
    • +183
    ./impl/IPCConnectionManager.java
  1. … 9 more files in changeset.
[NO ISSUE] stop awaiting IPC connect on state == CLOSED

Change-Id: I0dc67100cfcb827d54abfc8b0f0d358bf6e02aeb

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2434

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

[NO ISSUE][NET] Networking Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Set keep alive and no TCP delay options

on socket channels.

- Cancel key and close IPC handle on failed

read/writes to avoid getting the same failures

with every NetworkThread loop.

Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2418

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -43
    • +67
    ./impl/IPCConnectionManager.java
  1. … 6 more files in changeset.
[NO ISSUE][CLUS] Synchronize restoration of IPC connection

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- When an IPC connection is dead, then only a single sender

will revive the connection.

Change-Id: I1ec58d7fbc96d7352882e6588ef2ce12dc66511e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2397

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2256] Reformat sources using code format template

Change-Id: I4faa141c1a8c9700d5e9ac50b839acc9d1eede73

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2310

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -2
    • +2
    ./impl/JavaSerializationBasedPayloadSerializerDeserializer.java
  1. … 982 more files in changeset.
[NO ISSUE] Enable RPC to reconnect IPC handles

Change-Id: Ieea8ebedc58dbfd65dbc1cb13721eeb83b6a475a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2289

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 1 more file in changeset.
[NO ISSUE] Address comments in ReconnectingIPCHandle

Change-Id: I916939f3419cdc6983253b4f6d8b46756fa13e69

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2287

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

Tested-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE] Refactor IPC reconnect logic to be usable by all IPC connections

Change-Id: I2430510b22f936b89879df98322ef51ec87c6da6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2284

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -0
    • +36
    ./api/IIPCEventListener.java
    • -0
    • +28
    ./impl/NoOpIPCEventListener.java
    • -0
    • +83
    ./impl/ReconnectingIPCHandle.java
  1. … 11 more files in changeset.
[ASTERIXDB-1564][CONF] Consistently Use Log4j2

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Replace java.util.logging by Log4j2.

- Excluded classes due to their tests:

- IoUtil

- Tracer

Change-Id: Ic137571292f45de1f1994c61d328b97185012197

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2226

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -14
    • +13
    ./impl/IPCConnectionManager.java
  1. … 389 more files in changeset.
[NO ISSUE][HYR] Avoid ClassCastException in processIncomingMessages

If an error occurs while in state of CONNECT_RECEIVED, a

ClassCastException would occur attempting to cast the exception to a

InetSocketAddress

Change-Id: Ie738cede8e0a6ec98857505f8b27624b77c34256

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2094

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

- Generate & send NC heartbeats in their own thread to prevent starvation

/ scheduling issues

- Fix retries on IPC connections

- Don't spin on heartbeat send failure

Change-Id: Ieae21b1596013a699f27975fb21894244c536395

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2060

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

Tested-by: Murtadha Hubail <mhubail@apache.org>

    • -15
    • +12
    ./impl/IPCConnectionManager.java
  1. … 5 more files in changeset.
[NO ISSUE][RT] Abort CC jobs on first time registration

- user model changes: no

- storage format changes: no

- interface changes: yes

- application context is in charge of providing and renewing cc client

connection.

details:

- This change allows revival of cc if it gets killed.

- Jobs that were started by this cc are aborted and cleaned up on all ncs

upon first time registration.

- client connections are repaired on ncs when dead connection

is detected.

Change-Id: If755b7131bdc91790ed28be66f0c61b51f28c2fa

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2026

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

  1. … 28 more files in changeset.
[ASTERIXDB-2008][CLUS] Only add pending removal if node known

[ASTERIXDB-2023][ING] Introduce Enums instead of using bytes

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Only nodes which are known to cluster manager are added

to the list of nodes pending removal. Other nodes are ignored

- Enums introduced:

- ActiveEvent.Kind

- ActivePartitionMessage.Event

- Remove AdapterRuntimeManager

- Remove AdapterExecutor

Change-Id: I7044896559798426c04a3f46861bc5335b25d140

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1921

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 102 more files in changeset.
Extensible exception handling in QueryServiceServlet

Change-Id: If8037a97f3d0b0febb8caf68e099f1fd24e0ac49

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1836

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <hubailmor@gmail.com>

  1. … 10 more files in changeset.
Re-register NC with CC on reestablished IPCHandle

In case of failed NC -> CC IPCHandle due to CC crash/restart, the NC

needs to re-register with the CC in order to rejoin the cluster, as the

CC ignore heartbeats from unregistered nodes.

- Improve toString on IPCHandle

- Add tests for killing & restarting CC / NCs to NCServiceExecutionIT

- Retrigger NCService on detected dead node

- Ensure jobIds are not reused on CC restart

- NCService shouldn't truncate NC log

Change-Id: I6f93ca9ab37e56e02bafcdecd1e2d0cf664faef6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1830

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 23 more files in changeset.
Attempt to reconnect IPCHandle on connection failure

IPCHandles can become invalid due to network interruption or node

crash/restart. Automatically retry connection in event of attempt

to use disconnected handle.

Change-Id: I069dcd59898021054462c8213fb623df2deec598

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1828

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 6 more files in changeset.
Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of

managix option names

- Normalized command line -vs- ini file configuration parameter names

- Eliminated unused parameters

- Ini validation

- Migrate *DB parameters out of [app] and into nc / cc sections as

appropriate

- Eliminate [app] section. Cluster-wide configuration lives in [common]

- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1487

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 174 more files in changeset.
Handle error conditions in the /query/status API

Change-Id: I30176c5c70dcc5f7f6605ad79dd0e41967373d9c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1522

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 15 more files in changeset.
Extract NodeControllerIPCI out of NodeControllerService

Change-Id: I9e7f160dfa7418cd29693a990fa17d80a14e5841

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1324

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

  1. … 2 more files in changeset.
Windows 10 Logs Constant Exceptions On CC/NC Death

- Backoff delays on IPC Listener Thread exceptions; use logger instead of

printStackTrace()

Change-Id: Iec7a3ce23ab99d04b0fc0e0f832cce1a461e2df8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1309

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -14
    • +34
    ./impl/IPCConnectionManager.java
Move Hyracks to subfolder

    • -0
    • +35
    ./api/IIPCHandle.java
    • -0
    • +70
    ./api/IPCPerformanceCounters.java
    • -0
    • +31
    ./api/IPayloadSerializerDeserializer.java
    • -0
    • +23
    ./api/IResponseCallback.java
    • -0
    • +102
    ./api/RPCInterface.java
    • -0
    • +39
    ./exceptions/IPCException.java
    • -0
    • +28
    ./impl/HandleState.java
    • -0
    • +347
    ./impl/IPCConnectionManager.java
    • -0
    • +195
    ./impl/IPCHandle.java
    • -0
    • +105
    ./impl/IPCSystem.java
    • -0
    • +71
    ./impl/JavaSerializationBasedPayloadSerializerDeserializer.java
    • -0
    • +131
    ./impl/Message.java
  1. … 4415 more files in changeset.