Clone Tools
  • last updated 15 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][NET] Split delivery of messages and exceptions

- user model changes: no

- storage format changes: no

- interface changes: yes

Change-Id: I5a97e1eb1e2a3ec207591b3d5b8b7f1949a80fbc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4025

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 4 more files in changeset.
[ASTERIXDB-2597] Load UDFs via HTTP

- POST existing UDF format to /admin/udf/$DATAVERSE/$LIBNAME

- DELETE against that URL to remove UDFs

Change-Id: I6be9fef54c010bdb32f5c78af9b973f9843f442f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3386

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@uci.edu>

    • -2
    • +4
    ./impl/HyracksClientInterfaceRemoteProxy.java
  1. … 36 more files in changeset.
Merge commit '963a544' from 'stabilization-f69489' to 'master'

Change-Id: Iedb57cd217d3115b94d13761d8779e81293003da

  1. … 6 more files in changeset.
[NO ISSUE][NET] Do Not Track Incoming IPC Connections Handles

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Incoming IPC connections use a random port every time

they are established even if they are coming from the

same remote node. We should not track any incoming

connections handles as the IPCConnectionManager only

needs to keep track of out-going connections to avoid

establishing multiple out-going connections to the same

destination.

- Unregister IPC handles from IPCConnectionManager when

they are closed.

Change-Id: I8e2328c3baf4d208bc9f4de7ce6c8d49ac7d4a61

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3291

Reviewed-by: Michael Blow <mblow@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[NO ISSUE] Apply / enforce java import order

The process-sources target will now sort imports as well as

format source code; the source-format job will likewise verify

import order in addition to source code format

Change-Id: I55d976c4df10d9919c6a25683be2a3e3304e65d9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3288

Integration-Tests: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -1
    • +1
    ./impl/HyracksClientInterfaceRemoteProxy.java
    • -1
    • +1
    ./sockets/PlainSocketChannelFactory.java
  1. … 621 more files in changeset.
[ASTERIXDB-2490][NET] Allow Private Key Entries With Password

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Currently, it is assumed that private key entries will always

have a blank password. This change changes that by using the

keystore passed password as the private key entry password.

- Ensure trust store password property is set to to allow the

usage of password protected trust stores.

- Fix NCConfig keyStorePath/trustStorePath setter to set the

values for the current node.

- Update test cases private key entries to have password.

Change-Id: I204aa31006c6d3db65909248e55dd901029887fe

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3239

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -1
    • +2
    ./security/NetworkSecurityManager.java
  1. … 7 more files in changeset.
Merge commit '04aebfe' from 'stabilization-f69489' into 'master'

Change-Id: I2d6ed58a6f11efff839bacab4bbe552d92eb9371

[NO ISSUE][HYR] Binary compatibility enhancements

Infrastructure & changes to enable binary compatibility with 0.9.4

Change-Id: I77d4919be4853d9afe9b0137861cff3b1d751e20

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3128

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -464
    • +0
    ./impl/HyracksClientInterfaceFunctions.java
    • -1
    • +2
    ./impl/HyracksClientInterfaceRemoteProxy.java
    • -9
    • +15
    ./impl/JavaSerializationBasedPayloadSerializerDeserializer.java
  1. … 30 more files in changeset.
[NO ISSUE][NET] Catch All Network Unexpected Exceptions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Any case of any unexpected exception during

IPC network operations, close the connection

to allow it to be reestablished.

Change-Id: I57db83faa1d1ecbc4702ca06e64e21fedb186313

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3132

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2490][NET] Support Encrypted RMI Connections

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Use RMIServer/ClientFactory in metadata node RMI connections

to support both unencrypted and encrypted sockets.

- Add config getter to network security manager.

Change-Id: I11577b7d26d8002d4182255fee0dd769945ca389

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3093

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -0
    • +8
    ./security/NetworkSecurityManager.java
  1. … 6 more files in changeset.
[ASTERIXDB-2490][NET] Support Encrypted Replication Connections

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Use SocketChannelFactory in replication connections

to support both unencrypted and encrypted sockets.

- Add SSL replication test cases.

- Make SslSocketChannel close idempotent.

- Ensure FlushDatasetOperatorDescriptor waits for all

on-going dataset IO.

Change-Id: I9657624a5d54d4966357651efb671f3d8f0cb304

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3092

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 15 more files in changeset.
[ASTERIXDB-2490][NET] Support Encrypted Multiplexed Connections

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Use SocketChannelFactory in multiplex connections

to support both unencrypted and encrypted sockets.

- Adapt TCPEndpoint to socket channels that require

handshake.

- Adapt test cases to API changes.

Change-Id: I9cbed93c162018bad17923d50d4987011cbba16c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3071

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 17 more files in changeset.
[ASTERIXDB-2490][NET] Support Encrypted IPC Connections

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Add CC/NC options to support SSL connections.

- Add APIS to support secured connections.

- Support encrypted connections for CC/NC IPCs.

- Add keys/certificates for testing.

- Add SqlppExecutionTest with SSL connections enabled.

- Sort imports.

Change-Id: I7007a9be25287a94c5936d440355cfedb8e032b9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3052

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -16
    • +65
    ./impl/IPCConnectionManager.java
    • -0
    • +72
    ./security/NetworkSecurityConfig.java
    • -0
    • +115
    ./security/NetworkSecurityManager.java
    • -0
    • +79
    ./sockets/PlainSocketChannel.java
    • -0
    • +39
    ./sockets/PlainSocketChannelFactory.java
    • -0
    • +173
    ./sockets/SslHandshake.java
    • -0
    • +251
    ./sockets/SslSocketChannel.java
    • -0
    • +50
    ./sockets/SslSocketChannelFactory.java
  1. … 44 more files in changeset.
[NO ISSUE][OTH] Fix hyracks-api Dependences

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Ensure hyracks-api module depends only on hyracks-util. This way

new APIs can be added to hyracks-api and used on all other modules

without facing cyclic dependency issues.

Change-Id: I7f4329b3dad99c256fb2e10a7863aaca41990ce0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3047

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -0
    • +464
    ./impl/HyracksClientInterfaceFunctions.java
    • -0
    • +202
    ./impl/HyracksClientInterfaceRemoteProxy.java
    • -0
    • +482
    ./impl/HyracksConnection.java
  1. … 45 more files in changeset.
[NO ISSUE][NET] Avoid Sleeping The Network Thread on Failures

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- We currently sleep the networking thread incrementally with

every failure. This sleep was added to avoid CPU spinning

back when failures on pending networking operations were not

handled properly which led to processing the same networking

message that caused the failure over and over. This sleep is

not needed anymore since every failed read/write/send/connect

network operations will not be attempted again.

Change-Id: I9f7ddc088868f8cf4d0a15ec5349021af8ccae36

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2978

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[NO ISSUE][OTH] Move Network Tracing Logs to Trace Level

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Iebc13ff6cb7b3c9086c19597ec982061672a891f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2848

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

  1. … 9 more files in changeset.
[NO ISSUE][NET] Set Handle State on Connect Failure

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Update the handle state to CLOSED when

the handle is closed after failure to

connect attempt.

Change-Id: I866ba42f5433e1d9d312b6c0ab19296cad4d20f3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2838

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE] Allow MetadataProvider config to store non String values

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- In many cases, we would like to associate a value with a key

in MetadataProvider to be accessed during the compilation

of jobs. However, currently, there is no place to store

such values, so we ended up storing them in the config

map.

- The config map is a <String, String> map and so, we would

write our values as a string and then parse them when needed.

- To avoid this, and to avoid introducing a new map, we simply

change the config stored in MetadataProvider from <String,String>

to <String, Object>.

Change-Id: I55b392ad199d74b0f3cffdc38b54593b12ec1a06

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2795

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

  1. … 23 more files in changeset.
[NO ISSUE][OTH] Remove Unused Interfaces

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Remove unused interfaces.

Change-Id: I966cdf028d08ac74ec60d3922ce97130221da68f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2635

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 13 more files in changeset.
[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Refactor IPCConnectionManager.

- Halt on IPC message serialization failures.

- Ensure channels and handles are closed on connection

failures.

- Remove IPCHandle unneeded CONNECT_FAILED state.

- Fix RegisterNodeWork failure handling.

- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2617

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -138
    • +183
    ./impl/IPCConnectionManager.java
  1. … 9 more files in changeset.
[NO ISSUE] stop awaiting IPC connect on state == CLOSED

Change-Id: I0dc67100cfcb827d54abfc8b0f0d358bf6e02aeb

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2434

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

[NO ISSUE][NET] Networking Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Set keep alive and no TCP delay options

on socket channels.

- Cancel key and close IPC handle on failed

read/writes to avoid getting the same failures

with every NetworkThread loop.

Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2418

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -43
    • +67
    ./impl/IPCConnectionManager.java
  1. … 6 more files in changeset.
[NO ISSUE][CLUS] Synchronize restoration of IPC connection

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- When an IPC connection is dead, then only a single sender

will revive the connection.

Change-Id: I1ec58d7fbc96d7352882e6588ef2ce12dc66511e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2397

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2256] Reformat sources using code format template

Change-Id: I4faa141c1a8c9700d5e9ac50b839acc9d1eede73

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2310

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -2
    • +2
    ./impl/JavaSerializationBasedPayloadSerializerDeserializer.java
  1. … 982 more files in changeset.
[NO ISSUE] Enable RPC to reconnect IPC handles

Change-Id: Ieea8ebedc58dbfd65dbc1cb13721eeb83b6a475a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2289

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 1 more file in changeset.
[NO ISSUE] Address comments in ReconnectingIPCHandle

Change-Id: I916939f3419cdc6983253b4f6d8b46756fa13e69

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2287

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

Tested-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE] Refactor IPC reconnect logic to be usable by all IPC connections

Change-Id: I2430510b22f936b89879df98322ef51ec87c6da6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2284

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -0
    • +36
    ./api/IIPCEventListener.java
    • -0
    • +28
    ./impl/NoOpIPCEventListener.java
    • -0
    • +83
    ./impl/ReconnectingIPCHandle.java
  1. … 11 more files in changeset.
[ASTERIXDB-1564][CONF] Consistently Use Log4j2

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Replace java.util.logging by Log4j2.

- Excluded classes due to their tests:

- IoUtil

- Tracer

Change-Id: Ic137571292f45de1f1994c61d328b97185012197

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2226

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -14
    • +13
    ./impl/IPCConnectionManager.java
  1. … 389 more files in changeset.
[NO ISSUE][HYR] Avoid ClassCastException in processIncomingMessages

If an error occurs while in state of CONNECT_RECEIVED, a

ClassCastException would occur attempting to cast the exception to a

InetSocketAddress

Change-Id: Ie738cede8e0a6ec98857505f8b27624b77c34256

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2094

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[ASTERIXDB-1076][HYR] Generate heartbeats in their own thread

- Generate & send NC heartbeats in their own thread to prevent starvation

/ scheduling issues

- Fix retries on IPC connections

- Don't spin on heartbeat send failure

Change-Id: Ieae21b1596013a699f27975fb21894244c536395

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2060

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

Tested-by: Murtadha Hubail <mhubail@apache.org>

    • -15
    • +12
    ./impl/IPCConnectionManager.java
  1. … 5 more files in changeset.