Clone Tools
  • last updated 15 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2672][API] Change the valid values for "format" request parameter

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Allowed values for "format" request parameter: json, csv, adm.

- Recognizable format values in "Accept":

application/x-adm

application/json

application/json;lossless=true/false

text/csv

text/csv;header=present/absent

Test framework changes:

- ResultExtractor: if the OutputFormat is json/lossless-json, print the "result"

field of the response similar to how adm would be printed, one json value

per line (and using same spacing).

- Changed some queries that use "EXPLAIN SELECT..." and specify OutputFormat as JSON.

The queries extension is ".plans.sqlpp". "param optimized-logical-plan:string=true"

is specified in those queries to print the logical plan in the "plans" field of

the response.

- added "// compareunorderedarray=true" for test quries that use .regexjson to compare

one json value against another where the order of elements in a json array is not

deterministic.

- TestExecutor: OutputFormat.LOSSLESS_JSON & OutputFormat.CSV_HEADER formats are set

in the "Accept". Otherwise, the desired format is set in the "format" request

parameter as usual.

- TestHelper: changed "equalJson()" to allow comparing json array in two modes.

- Removed some test cases that used to set mime types in the "format" request parameter

since now it's not allowed to do so.

Change-Id: Ie3c7a35446322c2d97679e7e724b9778e2a4ba83

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4043

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 32 more files in changeset.
[ASTERIXDB-2659][API] validate request parameters

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Return 400 BAD request for invalid request parameters.

- Changes in specifying the output format:

HEADER "Accept": application/json;lossless=<BOOLEAN>, text/csv;header=absent/present, application/x-adm

Request parameter "format": csv, json (and above mime types)

- when format is supplied in "Accept", only validate value of attribute if the mime is one of the above

and the attribute name is one of the above (header & lossless).

Change-Id: Ia89fa3179cc36a73fe950f41eab1f0a9d17a541c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3767

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

  1. … 80 more files in changeset.
[NO ISSUE][API] Add ability to identify secure servlet requests

Change-Id: Ia693e29a47b513a63fdce80383da90ba165c28d6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3603

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 6 more files in changeset.
Merge commit 'ac5b498' from 'stabilization-f69489' into 'master'

Change-Id: Iaf16894f0628189e3d2de685f2b3f132c65baff3

  1. … 4 more files in changeset.
[NO ISSUE][HTTP] Character encoding fixes

- Support alternate charset for application/x-www-form-urlencoded requests

- Use a random charset in TestExecutor for each query request

Change-Id: I4a982f7c6c34bb32652c1bdd9b546780a2d967d0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3265

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 3 more files in changeset.
Merge commit '5543132' from 'stabilization-f69489' into 'master'

Change-Id: Ic0e77df94ecea518e19b55edb90a2fe8157cac21

  1. … 12 more files in changeset.
[NO ISSUE] Handle Accept-Charset in QueryResultApiServlet

- exercise non-UTF8 Accept-Charset in TestExecutor

- remove double-buffering on http responses

- minor refactoring / cleanup

Change-Id: I8f37eb684bf2457e5ff451bf5c8fbca742d531f2

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3191

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 24 more files in changeset.
Merge commit '6312edf' from 'stabilization-f69489' into 'master'

Change-Id: I6f2daa3ab112d8cb9210ed94db812ac1743bce58

  1. … 11 more files in changeset.
[NO ISSUE][HTTP] Character encoding fixes

- honor Accept-Charset on response

- honor request encoding on requests

Change-Id: I3c066e2ce190c0f271fa1c421ccff657bedb5a44

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3183

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 34 more files in changeset.
[NO ISSUE][OTH] Add Remote Address to IServletRequest

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Add the remote address to IServletRequest.

- Set remote address in request reference.

Change-Id: Iab4a0b4d26e82a4d1b9ce134c0dab2f1ae94d0c6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3172

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 6 more files in changeset.
[NO ISSUE][OTH] Do Not Close Client Connection After Failure

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Currently, after sending some failure responses (e.g. after

servlet not found), the client connection is closed even if

the connection was supposed to be kept alive. This change

ensures that we do not close the client connection -- if keep

alive is requested -- which allows the client to submit another

request using the same connection.

- Ensure a full http response is sent to the client in case of

a failure and not only the response header.

- Refactor logic to set connection header.

Change-Id: Id0fce2c860eec97f3d368ee42f25dbdfc9dc0ff9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3006

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 4 more files in changeset.
[ASTERIXDB-2397][*DB] Enable build on Java 10

(cherry picked from commit aebe2c55ef738c3649113c16c7e247804c4ce8e2)

Change-Id: I6e6fef52cd0bf195941918a71073844eb9d4df74

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2702

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 8 more files in changeset.
[ASTERIXDB-2397][*DB] Enable build on Java 10

Change-Id: I5ceccc0d3b0d5c508f4777d3cde5753099661322

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2696

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 8 more files in changeset.
[NO ISSUE][API] QueryServiceServlet HTTP API Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Default NC timeout to Long.MAX.

- Accept signature as parameter and default its

value to true and its returned value to {"*":"*"}.

- Accept "json" as a synonym for "application/json" format.

Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2636

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 2 more files in changeset.
[ASTERIXDB-1564][CONF] Consistently Use Log4j2

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Replace java.util.logging by Log4j2.

- Excluded classes due to their tests:

- IoUtil

- Tracer

Change-Id: Ic137571292f45de1f1994c61d328b97185012197

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2226

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 390 more files in changeset.
[ASTERIXDB-1973][OTR] Add Optional Parameters in Query Compilation

- user model changes: no

- storage format changes: no

- interface changes:

Introduce IRequestParameters to encapsulate request parameters

and use it in IStatementExecutor#compileAndExecute and

IExtensionStatement#handle.

Details:

- Introduce IRequestParameters and its default implementation.

- Add optional parameters supplier in QueryServiceServlet.

Change-Id: Ie918f4d3f8dae41d07536041c591c59946a077f4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1867

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 14 more files in changeset.
[NO ISSUE][OTH] Improve Http Server

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Log estimated input memory budget

- Ensure all allocated input memory buffers are 4K. This reduces

the chance of memory allocation to go beyond budget. This also

allows input and output to share buffers of this size since

it is the size of choice for reading and writing.

- Reject requests that go beyond server capacity before reading

them which reduces wasted resources.

- Allow configurations of number of bosses and workers for an

Http web manager.

- Push the limit further in Http server tests through:

-- Increase the size of the single request to ~100KB.

-- Increase the number of rejected requests.

Change-Id: I7adcd59047805dc384e1c119191eff995c6e9a7a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1991

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 7 more files in changeset.
[NO ISSUE][HYR][*DB][HTTP][TEST] Minor refactoring / test functionality

Adds ability to indicate which status code(s) to accept for an HTTP

request, instead of just 200.

Change-Id: I1f134d7874cc7de712e60911e89dac446c5c2cfd

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1948

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 2 more files in changeset.
[ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config null value handling

- handle null config values when marshall/unmarshalling

- support non-post x-www-form-urlencoded directly

- don't assume POSTs are x-www-form-urlencoded

- add support to TestExecutor for POST/PUT form-urlencoded parameters

Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1911

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 14 more files in changeset.
Enable Adding Nodes to Running *DB Cluster

Also ability to configure unique partition ids without having access to

complete cluster topology

Change-Id: If978442a95687c00ef78c89ed1b4440f5e308b99

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1785

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 23 more files in changeset.
Map *.ico files to the image/x-icon media type

Change-Id: Icc72b0df40b4cad2083d9832318bdaac85161250

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1617

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

ASTERIXDB-1786: Remove servlet/jetty dependency

Change-Id: Id72b394fa967dd130c0df7e813812e3c6b985c84

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1527

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 31 more files in changeset.
ASTERIXDB-1804: support more HTTP verbs

- add verb-based routing to AbstractServlet.handle (subclasses implement

verb-specific methods like get, post, ...)

- move construction logic for IServletRequests from HttpUtil to request

classes

- remove verb-checking from HttpServerHandler

Change-Id: I2d14ce9c3c34d345fe71a44518b1e95b79c37dab

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1516

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 6 more files in changeset.
Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1486

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 28 more files in changeset.