Clone Tools
  • last updated 22 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2672][API] Change the valid values for "format" request parameter

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Allowed values for "format" request parameter: json, csv, adm.

- Recognizable format values in "Accept":

application/x-adm

application/json

application/json;lossless=true/false

text/csv

text/csv;header=present/absent

Test framework changes:

- ResultExtractor: if the OutputFormat is json/lossless-json, print the "result"

field of the response similar to how adm would be printed, one json value

per line (and using same spacing).

- Changed some queries that use "EXPLAIN SELECT..." and specify OutputFormat as JSON.

The queries extension is ".plans.sqlpp". "param optimized-logical-plan:string=true"

is specified in those queries to print the logical plan in the "plans" field of

the response.

- added "// compareunorderedarray=true" for test quries that use .regexjson to compare

one json value against another where the order of elements in a json array is not

deterministic.

- TestExecutor: OutputFormat.LOSSLESS_JSON & OutputFormat.CSV_HEADER formats are set

in the "Accept". Otherwise, the desired format is set in the "format" request

parameter as usual.

- TestHelper: changed "equalJson()" to allow comparing json array in two modes.

- Removed some test cases that used to set mime types in the "format" request parameter

since now it's not allowed to do so.

Change-Id: Ie3c7a35446322c2d97679e7e724b9778e2a4ba83

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4043

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 32 more files in changeset.
[ASTERIXDB-2659][API] validate request parameters

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Return 400 BAD request for invalid request parameters.

- Changes in specifying the output format:

HEADER "Accept": application/json;lossless=<BOOLEAN>, text/csv;header=absent/present, application/x-adm

Request parameter "format": csv, json (and above mime types)

- when format is supplied in "Accept", only validate value of attribute if the mime is one of the above

and the attribute name is one of the above (header & lossless).

Change-Id: Ia89fa3179cc36a73fe950f41eab1f0a9d17a541c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3767

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

  1. … 80 more files in changeset.
[NO ISSUE][API] Add ability to identify secure servlet requests

Change-Id: Ia693e29a47b513a63fdce80383da90ba165c28d6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3603

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -4
    • +5
    ./http/server/FormUrlEncodedRequest.java
  1. … 1 more file in changeset.
[NO ISSUE][OTH] Ensure HttpServer Channel is Initialized

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Ensure the HttpServer channel is initialized when stopping

the server to avoid NPE.

Change-Id: I5b7403e80f6118f99be46d166c6cfbee8d4305ac

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3389

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE] Fix logging for ncservice-based tests

Change-Id: Id264aede0f62558ad6e34355047c623a1d594692

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3311

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@uci.edu>

  1. … 34 more files in changeset.
[NO ISSUE] Apply / enforce java import order

The process-sources target will now sort imports as well as

format source code; the source-format job will likewise verify

import order in addition to source code format

Change-Id: I55d976c4df10d9919c6a25683be2a3e3304e65d9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3288

Integration-Tests: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -1
    • +1
    ./http/server/FormUrlEncodedRequest.java
    • -1
    • +1
    ./http/server/HttpRequestAggregator.java
    • -3
    • +0
    ./http/server/HttpServerInitializer.java
  1. … 619 more files in changeset.
Merge commit 'ac5b498' from 'stabilization-f69489' into 'master'

Change-Id: Iaf16894f0628189e3d2de685f2b3f132c65baff3

    • -63
    • +13
    ./http/server/FormUrlEncodedRequest.java
  1. … 3 more files in changeset.
[NO ISSUE][HTTP] Character encoding fixes

- Support alternate charset for application/x-www-form-urlencoded requests

- Use a random charset in TestExecutor for each query request

Change-Id: I4a982f7c6c34bb32652c1bdd9b546780a2d967d0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3265

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -62
    • +12
    ./http/server/FormUrlEncodedRequest.java
  1. … 2 more files in changeset.
[NO ISSUE][OTH] Allow Binding HTTP Server to Specific Address

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Allow binding HTTP server to specific network address

rather than always defaulting it to all network interfaces.

Change-Id: Ie4b6c66502aacf8e0564cc3c6e2fd20c4efac385

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3260

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 2 more files in changeset.
Merge commit '5543132' from 'stabilization-f69489' into 'master'

Change-Id: Ic0e77df94ecea518e19b55edb90a2fe8157cac21

    • -11
    • +19
    ./http/server/utils/HttpUtil.java
  1. … 10 more files in changeset.
[NO ISSUE] Handle Accept-Charset in QueryResultApiServlet

- exercise non-UTF8 Accept-Charset in TestExecutor

- remove double-buffering on http responses

- minor refactoring / cleanup

Change-Id: I8f37eb684bf2457e5ff451bf5c8fbca742d531f2

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3191

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Michael Blow <mblow@apache.org>

    • -11
    • +19
    ./http/server/utils/HttpUtil.java
  1. … 22 more files in changeset.
Merge commit '6312edf' from 'stabilization-f69489' into 'master'

Change-Id: I6f2daa3ab112d8cb9210ed94db812ac1743bce58

  1. … 9 more files in changeset.
[NO ISSUE][HTTP] Character encoding fixes

- honor Accept-Charset on response

- honor request encoding on requests

Change-Id: I3c066e2ce190c0f271fa1c421ccff657bedb5a44

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3183

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 32 more files in changeset.
[NO ISSUE][OTH] Add Remote Address to IServletRequest

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Add the remote address to IServletRequest.

- Set remote address in request reference.

Change-Id: Iab4a0b4d26e82a4d1b9ce134c0dab2f1ae94d0c6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3172

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -5
    • +9
    ./http/server/FormUrlEncodedRequest.java
  1. … 2 more files in changeset.
[ASTERIXDB-2475][OTH] Reject HTTP Pipelined Requests

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- If a client sends multiple requests on the same connection

before reading the response of each request (i.e. pipelined

requests), the request will be rejected and the connection

will be closed.

- Add test case.

- Fix typo in method name.

Change-Id: I67c370d4d37a3e267b30e13333714605b07b7515

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3021

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Ian Maxon <imaxon@apache.org>

    • -19
    • +62
    ./http/server/HttpServerHandler.java
  1. … 2 more files in changeset.
[NO ISSUE][OTH] Do Not Close Client Connection After Failure

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Currently, after sending some failure responses (e.g. after

servlet not found), the client connection is closed even if

the connection was supposed to be kept alive. This change

ensures that we do not close the client connection -- if keep

alive is requested -- which allows the client to submit another

request using the same connection.

- Ensure a full http response is sent to the client in case of

a failure and not only the response header.

- Refactor logic to set connection header.

Change-Id: Id0fce2c860eec97f3d368ee42f25dbdfc9dc0ff9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3006

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -7
    • +15
    ./http/server/HttpServerHandler.java
  1. … 1 more file in changeset.
[NO ISSUE] Don't close Keep-Alive connections on non-200/401

Change-Id: Ia39f8f9030be5a738a71de4c336a98e326ee896f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2972

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[NO ISSUE][OTH] Log directory tweak, minor perf tweaks

Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2910

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 2 more files in changeset.
[NO ISSUE][OTH] Avoid NPE on response w/o content-length

Change-Id: Ifac2a5098f3c70348b20b2859d5d2fdddb3d8579

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2902

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

[NO ISSUE][HTTP] Fix buffer leak in HttpServer

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Prior to this change, cancelled requests before

they start leak request and response buffers.

- After this change, we distinguish between cancellation

of requests before they start or after and release resources

accordingly.

Change-Id: I9a34142e87158385152fa0a11be39abced307fcc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2901

Reviewed-by: Michael Blow <mblow@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -1
    • +21
    ./http/server/HttpRequestHandler.java
[ASTERIXDB-2017][API] Access logs, log rotation

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Common Log Format (httpd) style logs for each servlet access.

- Log rotation by default in asterix-server package, rather than

console logging with no rotation

Change-Id: I9a8d76bec308b2fdb20c33370fc9e58a154ba968

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1915

Reviewed-by: Michael Blow <mblow@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -0
    • +135
    ./http/server/CLFLogger.java
    • -0
    • +4
    ./http/server/HttpServerInitializer.java
  1. … 17 more files in changeset.
[NO ISSUE][OTH] Add Request Getter to HttpRequestHandler

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: I65c384449b7532a05fd89a80d6c9567320d53fba

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2847

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

[NO ISSUE] Improve logging for Http server

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Reduce logging level for failures in HttpServerHandler.

- Log as an error failures during active jobs.

Change-Id: I7474a93e869df1cbf5dbb00d16acbe2d4bfaa6e0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2834

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 1 more file in changeset.
[NO ISSUE][CONF] Add Configuration For Max Http Request Size

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Add configuration for max http request size and default

it to 50 MB.

- Close client connection if request exceeds max size.

- Add test case for large request.

Change-Id: I11153490fc022d3a94b5b6f7dc3e20204fb105a0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2826

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

    • -0
    • +80
    ./http/server/HttpRequestAggregator.java
    • -0
    • +78
    ./http/server/HttpServerConfig.java
    • -0
    • +91
    ./http/server/HttpServerConfigBuilder.java
    • -9
    • +14
    ./http/server/HttpServerInitializer.java
  1. … 10 more files in changeset.
[ASTERIXDB-2397][*DB] Enable build on Java 10

(cherry picked from commit aebe2c55ef738c3649113c16c7e247804c4ce8e2)

Change-Id: I6e6fef52cd0bf195941918a71073844eb9d4df74

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2702

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

  1. … 8 more files in changeset.
[ASTERIXDB-2397][*DB] Enable build on Java 10

Change-Id: I5ceccc0d3b0d5c508f4777d3cde5753099661322

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2696

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 8 more files in changeset.
[NO ISSUE][OTH] Make Http Channel Initializer Extensible

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Make Http channel initializer extensible.

- Move to latest netty stable release.

Change-Id: I64f737f2da709df75baec1e8a500fd4abdde5a52

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2649

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 2 more files in changeset.
[NO ISSUE][API] QueryServiceServlet HTTP API Improvements

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Default NC timeout to Long.MAX.

- Accept signature as parameter and default its

value to true and its returned value to {"*":"*"}.

- Accept "json" as a synonym for "application/json" format.

Change-Id: Ibe77eb8ad08a19ed1f11ffdb63f4379819ca43c8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2636

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 2 more files in changeset.
[NO ISSUE][OTR] More Descriptive Method Name

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Use more description method name for channel

writability changes in ChunkedNettyOutputStream.

Change-Id: Ie231e16cbd78e8f4cee8ea994478c66e1146401f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2601

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[ASTERIXDB-2361][HYR] Memory Leak Due to Netty Close Listeners

- user model changes: no

- storage format changes: no

- interface changes:

- add IServletResponse.notifyChannelInactive()

Change-Id: I40156538d62a3c06b9ccc14338c3f554921a12b8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2579

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -8
    • +22
    ./http/server/HttpServerHandler.java