Clone Tools
  • last updated 11 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2689][FUN] Make numeric functions return NULL on invalid arguments p2

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Make numeric functions return NULL on invalid arguments.

round(num), round(num, num), trunc(num, num), round-half-to-even(num, num).

- added warning to round() function

- extracted evaluators of trunc() and round-half-to-even() to a common evaluator

- renamed checkWarnOrSetInteger() to setInteger()

Change-Id: I1ccef0740d64cce3ada8b60d3a699748e7ef8776

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4704

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -6
    • +4
    ./AbstractBitMultipleValuesEvaluator.java
    • -3
    • +2
    ./AbstractBitSingleValueEvaluator.java
    • -9
    • +7
    ./AbstractBitValuePositionEvaluator.java
    • -11
    • +8
    ./BitValuePositionFlagEvaluator.java
  1. … 31 more files in changeset.
[NO ISSUE] Address serialVersionUID issues

- add missing serialVersionUIDs where applicable

- add @SuppressWarnings("serial") for serializable types which are never

actually serialized

Change-Id: Ic38d33b8020c3261bda4ebb0b273b26c40fef26f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4523

Reviewed-by: Michael Blow <mblow@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -0
    • +1
    ./BitShiftWithRotateFlagDescriptor.java
    • -0
    • +1
    ./BitShiftWithoutRotateFlagDescriptor.java
    • -0
    • +1
    ./BitTestWithoutAllFlagDescriptor.java
    • -0
    • +1
    ./IsBitSetWithoutAllFlagDescriptor.java
  1. … 7 more files in changeset.
[NO ISSUE][FUN] Clean up of warn utility method

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

clean up of warnTypeMismatch methods to avoid confusion

betweent the two methods.

Change-Id: I7ae7c85fa3cc549cfd622f179f36486e016d9643

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3581

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -2
    • +2
    ./AbstractBitMultipleValuesEvaluator.java
    • -1
    • +1
    ./AbstractBitSingleValueEvaluator.java
    • -2
    • +2
    ./AbstractBitValuePositionEvaluator.java
  1. … 9 more files in changeset.
[ASTERIXDB-2634][COMP][RT] String functions to return NULL on mismatch

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Make string functions return NULL on mismatch instead of raising

an exception and issue a warning.

- consolitated ExceptionUtil from org.apache.asterix.runtime.exceptions

into org.apache.asterix.om.exceptions.

- AbstractStringTypeComputer does not check arguments type now

and does not throw mismatch exception.

Change-Id: I51db8ae6ba301757c45c41cfd02bd2b083436970

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3562

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +5
    ./AbstractBitMultipleValuesEvaluator.java
    • -1
    • +3
    ./AbstractBitSingleValueEvaluator.java
    • -4
    • +7
    ./AbstractBitValuePositionEvaluator.java
  1. … 40 more files in changeset.
[ASTERIXDB-2631][COMP][RT] Limit number of reported warnings

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

Limit number of reported warnings.

- added a new compiler property "COMPILER.RUNTIME.WARNINGS"

with default value set to 0.

- updated Stat class to have a field for the count of runtime

warnings.

- updated few classes to propagate the warnings limit number

to Hyracks Task class.

- added new Option to parse unsigned long values.

- TaskProfile has a field for the count.

- updated TestExecutor to allow specifying parameters in

the body of the POST method.

Change-Id: Ie8756f1b9dcb7bbce92bd77692490fbada9a2482

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3535

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -12
    • +2
    ./AbstractBitMultipleValuesEvaluator.java
    • -11
    • +1
    ./AbstractBitSingleValueEvaluator.java
    • -20
    • +9
    ./AbstractBitValuePositionEvaluator.java
    • -21
    • +10
    ./BitValuePositionFlagEvaluator.java
  1. … 53 more files in changeset.
[ASTERIXDB-2619][FUN] Add extra test cases for bitwise functions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Added test cases based on reading data from dataset to ensure

the function performs properly on subsequent calls, and ensure

it works properly if it doesn't go through the constant folding

rule.

- Fixed an issue in the bitcount function which was resulting in

Serialization Exception when calling the function with fields

rather than constants.

- Fixed an issue with bittest and isbitset which was resulting in

wrong value in some cases due to not reseting the monitoring of

allSet check flag.

Change-Id: Ie1d8e4f8594843f98e7a1cf8a2da4b0106597ae8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3514

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 62 more files in changeset.
[ASTERIXDB-2603][FUN] Add compile/runtime warnings for bitwise functions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Added compile/runtime warnings for bitwise functions.

- Added a new error code to represent values out of acceptable

range.

Change-Id: I9ada529d91d8fdc881447e8b4cf17fc8e71aa87f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3504

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Hussain Towaileb <hussainht@gmail.com>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -0
    • +16
    ./AbstractBitMultipleValuesEvaluator.java
    • -1
    • +16
    ./AbstractBitSingleValueEvaluator.java
    • -1
    • +32
    ./AbstractBitValuePositionEvaluator.java
    • -1
    • +34
    ./BitValuePositionFlagEvaluator.java
  1. … 3 more files in changeset.
[NO ISSUE][FUN] Introduce IEvaluatorContext

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Introduce IEvaluatorContext - a context for evaluators

that is available both at runtime and during constant

folding at compile time

- IEvaluatorContext provides access to IHyracksTaskContext

which is only available at runtime. At compile time this

accessor returns null

- Instantiate evaluators with IEvaluatorContext

instead of IHyracksTaskContext

Change-Id: Iff90c7739e46d6602fcd0609e67f6a8cd9714ca5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3481

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./AbstractBitMultipleValuesEvaluator.java
    • -2
    • +2
    ./AbstractBitSingleValueEvaluator.java
    • -2
    • +2
    ./AbstractBitValuePositionEvaluator.java
    • -2
    • +2
    ./BitShiftWithRotateFlagDescriptor.java
    • -2
    • +2
    ./BitShiftWithoutRotateFlagDescriptor.java
    • -2
    • +2
    ./BitTestWithoutAllFlagDescriptor.java
  1. … 675 more files in changeset.
[ASTERIXDB-2562][FUN] Add support for bitwise functions

- user model changes: yes

Added AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET

and COUNT bitwise functions.

- storage format changes: no

- interface changes: no

Details:

- Introduced the AND, OR, XOR, NOT, SET, CLEAR, SHIFT, TEST, ISSET

and COUNT bitwise functions.

- Added test cases.

Change-Id: I70a6376d6ca12da55eeff88fa0b1c85f970ef8e6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3377

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +142
    ./AbstractBitMultipleValuesEvaluator.java
    • -0
    • +92
    ./AbstractBitSingleValueEvaluator.java
    • -0
    • +227
    ./AbstractBitValuePositionEvaluator.java
    • -0
    • +59
    ./BitAndDescriptor.java
    • -0
    • +59
    ./BitClearDescriptor.java
    • -0
    • +76
    ./BitCountDescriptor.java
    • -0
    • +75
    ./BitNotDescriptor.java
    • -0
    • +59
    ./BitOrDescriptor.java
    • -0
    • +59
    ./BitSetDescriptor.java
    • -0
    • +53
    ./BitShiftWithRotateFlagDescriptor.java
    • -0
    • +53
    ./BitShiftWithoutRotateFlagDescriptor.java
    • -0
    • +53
    ./BitTestWithAllFlagDescriptor.java
    • -0
    • +53
    ./BitTestWithoutAllFlagDescriptor.java
    • -0
    • +171
    ./BitValueCountFlagEvaluator.java
    • -0
    • +275
    ./BitValuePositionFlagEvaluator.java
  1. … 52 more files in changeset.