Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][SQLPP] Support dataset synonyms

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Add CREATE / DROP SYNONYM statements to SQL++

- Follow synonyms when resolving dataset references

in SELECT, INSERT, UPSERT, DELETE, LOAD statements

- Add metadata dataset for synonyms: Metadata.Synonym

- Add documentation and tests

Change-Id: Idf806914664205fb186ee3da8b0cebf234266f37

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4484

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -0
    • +85
    ./SqlppSynonymRewriteVisitor.java
  1. … 66 more files in changeset.
[NO ISSUE] Support multipart dataverse names

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Support dataverse names that consist of multiple parts

- Introduce DataverseName class and adopt it throughout the system

- Add testcases for multipart dataverse names

Change-Id: I1313b2dc0e8df6a9b0ded48dea122afc3ba5dbe7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4004

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 282 more files in changeset.
[ASTERIXDB-2648][COMP] Fix dataset order in broadcast hint

- user model changes: yes

- storage format changes: no

- interface changes: no

details:

- Provides hash-bcast hint to replace bcast hint which makes

broadcast join consistent with other types of joins for choosing

the broadcasting dataset based on dataset order in FROM clause.

- Chooses the build dataset to get broadcast based on the order

in the FROM clause not the WHERE clause (which was the case for

bcast hint).

Change-Id: I505fc8e0bc32c760ae0471c6b302bbfd8499be4a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3566

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 51 more files in changeset.
[NO ISSUE][COMP] Emit warning for cross product

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Emit warning for a cross product join

Change-Id: Icd2b27f23517842fc532db7741ee60e8da737082

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3512

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 6 more files in changeset.
[NO ISSUE][COMP] Do not inline non-functional LET clauses

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- When inlining LET clauses in LET ... SELECT ...

skip those that contain non-functional expressions

Change-Id: I3740745e2e8c8a0bb11aa7908e68c682dd9a5553

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3436

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +44
    ./CheckNonFunctionalExpressionVisitor.java
    • -0
    • +328
    ./base/AbstractSqlppContainsExpressionVisitor.java
  1. … 8 more files in changeset.
[NO ISSUE][FUN] Support FROM LAST in NTH_VALUE()

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support FROM FIRST / FROM LAST modifiers in window

function NTH_VALUE() with FROM FIRST being the default

- Minor cleanup of SQL++ grammar

- Update JavaCC version to 6.1.2

Change-Id: Iceac579bd5a3e651bcd7707e324148690e020cf5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3419

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -4
    • +5
    ./SqlppCloneAndSubstituteVariablesVisitor.java
  1. … 16 more files in changeset.
[NO ISSUE][FUN] Support IGNORE NULLS in window functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support IGNORE NULLS / RESPECT NULLS modifiers in window

  functions LEAD(), LAG(), FIRST_VALUE(), LAST_VALUE(), NTH_VALUE()

  (RESPECT NULLS is the default)

- Add testcases for each function

- Fix CollectionMemberResultType and PushAggregateIntoNestedSubplanRule

  to handle remaining non-list arguments

Change-Id: I400c9c95bac9159efa17fca4e97047fd089eb931

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3407

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -1
    • +1
    ./SqlppCloneAndSubstituteVariablesVisitor.java
  1. … 49 more files in changeset.
[ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Resolution" rule

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Variables introduced by LET clauses should not be

considered by "Single Variable Resolution" rule

- In INSERT/UPSERT statements with RETURNING expression

the automatically introduced variable should be named

as the target dataset

- Refactor VariableCheckAndRewriteVisitor and

other code related to name resolution

- Added testcases and updated documentation

Change-Id: I9b9f70a1671378f5216ec4e30416d4d67c3df089

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3322

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -50
    • +67
    ./CheckDatasetOnlyResolutionVisitor.java
    • -12
    • +39
    ./base/AbstractSqlppExpressionScopingVisitor.java
    • -14
    • +14
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 54 more files in changeset.
Merge commit '153b2ce970' from 'stabilization-f69489'

Change-Id: I5b0d2756d839b0bc2e7c59723306921e698a7630

  1. … 6 more files in changeset.
[ASTERIXDB-2537][COMP] Incorrect free variables for QuantifiedExpression

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Variables bound by a QuantifiedExpression should be excluded

when computing free variables for that expression

Change-Id: If5d0470b0742baa24e3d383bc4aa617a4c6fdd99

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3306

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 6 more files in changeset.
[NO ISSUE] Apply / enforce java import order

The process-sources target will now sort imports as well as

format source code; the source-format job will likewise verify

import order in addition to source code format

Change-Id: I55d976c4df10d9919c6a25683be2a3e3304e65d9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3288

Integration-Tests: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -1
    • +1
    ./CheckDatasetOnlyResolutionVisitor.java
    • -1
    • +1
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 619 more files in changeset.
[ASTERIXDB-2511][COMP] Refactor LET/WHERE clauses into a single list

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Consolidate LET and WHERE clauses into a single list in the SelectBlock

Change-Id: I9265dfc3adb9ef4d5eb963b0aa4d39c2ad0cc068

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3118

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -30
    • +17
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -16
    • +8
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 22 more files in changeset.
[ASTERIXDB-2505][COMP] Consolidate window operators rule

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Add optimizer rules that merge two window operators into one

- Improve existing optimizer rules to handle window operators

- Add tests for distinct aggregate in window operator

Change-Id: I5d0739d604d09f5445237d4fa3d56a2af8126bd7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3107

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 53 more files in changeset.
[ASTERIXDB-2488][COMP] Support aggregate window functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Implement aggregate window functions:

agg_func() OVER (frame_var AS)? (PARTITION BY ... ORDER BY ... frame_spec)

- Where agg_func is a SQL/SQL++ aggregate function

- Fix percent_rank() to always return 0 for the first tuple

- Fix ntile() to handle NULL argument

- Log query after each rewrite rule in SqlppQueryRewriter

- Implement toString() for ADayTimeDuration, fix it for AYearMonthDuration

- Add seek() method to RunFileReader

Change-Id: If0f71118a04c2dbd3462070673d52e67f076b7e1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3049

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -12
    • +30
    ./CheckSql92AggregateVisitor.java
    • -9
    • +22
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -0
    • +17
    ./base/AbstractSqlppExpressionScopingVisitor.java
    • -7
    • +29
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 846 more files in changeset.
[ASTERIXDB-2476][COMP] Array slicing parser syntax

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Added slice parser syntax. [list][start:end], the syntax accepts

end expression as an optional argument, the expression can be

written as [list][start:].

- Added slice parser test cases.

Change-Id: Ie83283bfd0a04257b59b573de3dab6b3e47de1bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3046

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +6
    ./CheckDatasetOnlyResolutionVisitor.java
    • -0
    • +13
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 30 more files in changeset.
[NO ISSUE] Fix subqueries for IndexAccessor syntax

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fixed subqueries for IndexAccessor syntax.

- Added test cases for function and subquery calls as arguments.

Change-Id: Iba16c6c04a526aec117ca3adcb168cdd4ba916a8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3091

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 7 more files in changeset.
[ASTERIXDB-2466][FUN] Implement window functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Implement window functions with SQL syntax:

function() OVER ((PARTITION BY expr1, expr2, ...)? ORDER BY exprA, exprB, ...)

- Where supported functions are:

ROW_NUMBER(), RANK(), DENSE_RANK(), PERCENT_RANK(), NTILE()

Change-Id: Ia28af8773cb11049c38d440c51b9c3cd1ed2bab4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3002

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +6
    ./CheckDatasetOnlyResolutionVisitor.java
    • -0
    • +17
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -0
    • +11
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 157 more files in changeset.
[ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Introduce LET clauses for column alias expressions

instead of inlining them into ORDER BY/LIMIT clauses

- Fix incorrect visitor used in SubstituteGroupbyExpressionWithVariableVisitor

for rewriting LET clauses after GROUP BY

Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2905

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

    • -4
    • +9
    ./SqlppSubstituteExpressionVisitor.java
  1. … 43 more files in changeset.
[NO ISSUE][OTH] Remove Unused Imports

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Iafff39073d0fedaff74a26ef7e3260008a79ff0c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2893

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

    • -1
    • +0
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 67 more files in changeset.
[ASTERIXDB-2408][COMP] Avoid infinite recursion when inlining column aliases

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Ib8a7017a068660d570e78a25c4211908e299d6db

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2741

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +4
    ./SqlppSubstituteExpressionVisitor.java
  1. … 3 more files in changeset.
[NO-ISSUE][COMP] Copy hint when replicate OperatorExpr

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

The hints are not copied over when Copy or Clone OperatorExpr.

Change-Id: I5eef37e525b7d1bec842e3488d8b63f88ddc05ea

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2722

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 2 more files in changeset.
[ASTERIXDB-2401][SQLPP] Support parameterized queries

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Support statement parameters: named ($name) and positional ($1 or ?)

- Enhance query service API to accept these parameters in the request

- Remove [?] index accessor from SQL++ grammar because it conflicts

with positional parameters ([0] can be used instead)

- Add testcases for parameterized queries

Change-Id: Ia612f731cd2370fccd54c4796bd9787fbea16766

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2707

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 103 more files in changeset.
[ASTERIXDB-2394][COMP] Align VarCounter in query rewritting

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Currently, before we do certain language rewritings, we take a snapshot

of the var counter in the context and pass it to the rewriter. This

works fine in most of the cases, but it can fail when the rewriter

introduces new variables. This will cause different variables map to the

same variable id. Although this error may be fixed by another

ScopingVisitor, the compiler could fail if there is no more visitor down

in the rewriting workflow.

Change-Id: I8ea1ee7de140d6556af03f07a5ec7bc278b011ba

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2673

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -2
    • +1
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 30 more files in changeset.
[ASTERIXDB-2393][COMP][RT] Add source location to error messages

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Add source locations to compiler and runtime error messages

- Add source location enforcement to the test framework

and enable it for SqlppExecutionTest

Change-Id: Ie279ce345d1edcb5dea8e55cdb0233151c7bfd66

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2659

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -18
    • +37
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -22
    • +29
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 676 more files in changeset.
[ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support SELECT variable.* in SQL++

- Include variables defined by LET clauses in the

output record created by SELECT *

- Add object_concat() function

- Add tests for these new features

- Fail testcase if its source directory is missing

- Fix testcases that did not run previously because

their source directories were incorrectly specified

Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2394

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./SqlppCloneAndSubstituteVariablesVisitor.java
  1. … 137 more files in changeset.
[ASTERIXDB-2244][RT] Implement micro union-all operator

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- implement support for binary micro operators in subplans

- implement micro union-all operator

- fix free variables visitor

Change-Id: I11be926f175889978c144dd4483ec565d3d86e2d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2277

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

Integration-Tests: Till Westmann <tillw@apache.org>

Tested-by: Till Westmann <tillw@apache.org>

  1. … 41 more files in changeset.
[ASTERIXDB-2256] Reformat sources using code format template

Change-Id: I4faa141c1a8c9700d5e9ac50b839acc9d1eede73

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2310

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -5
    • +4
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 984 more files in changeset.
[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Improved name resolution rules

- Resolve field access to the nearest variable in scope

instead of raising compile-time error

- Do not rely on type information when resolving names

- Cleanup group variable handling in GroupBy clause,

no longer use ‘with’ map for it

- Fix ByNameToByIndexFieldAccessRule to use type environment

of its input operator when analyzing its expression

- Fix ExternalGroupByPOperator to use input schema of its

aggregate function when generating runtime for that function

- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2207

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -2
    • +2
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -21
    • +17
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 309 more files in changeset.
[NO ISSUE][COMP] Expression cleanup

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove unused IndependentSubquery expression

- Make all expressions extend AbstractExpression

- Cleanup QueryPrintVisitor and subclasses

Change-Id: Ib5f9f06b313cde52033b59c1bf74a38b7e22588a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2164

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -6
    • +0
    ./CheckDatasetOnlyResolutionVisitor.java
    • -9
    • +0
    ./SqlppCloneAndSubstituteVariablesVisitor.java
    • -13
    • +0
    ./base/AbstractSqlppExpressionScopingVisitor.java
    • -7
    • +0
    ./base/AbstractSqlppSimpleExpressionVisitor.java
  1. … 24 more files in changeset.
[NO ISSUE][COMP] Function references cleanup

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

    • -5
    • +2
    ./base/AbstractSqlppExpressionScopingVisitor.java
  1. … 1582 more files in changeset.