Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][FUN] Fix type inference and casting in UDFs

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

The current UDF framework handles the argument types in a sloppy way. It

takes in the arguments and reads them as the expected data types in the

configuration. This could cause exception at runtime when passing in

arguments with unexpected datatypes. When setting the arguments, it did

a type casting for numeric values only to make sure the int64 from query

interface can be evaluated properly. However, this is not robust enough.

This patch fixes the type inference for UDFs during the complation time.

The ExternalTypeComputer is refactored to return defined data type, and

meanwhile checks the argument data types. Also, the

IntroduceDynamicTypeCastForExternalFunctionRule is modified to cover the

type castings for data types besides record type.

Change-Id: I40506fcca3cd8f14bbd6412359683433256c4c1f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3270

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Xikui Wang <xkkwww@gmail.com>

  1. … 31 more files in changeset.
[ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds

- user model changes: no

- storage format changes: no

- interface changes: no

LET is not necessary for applying functions to data feeds. We could

inline the function calls when constructing the pipeline query.

Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3072

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 10 more files in changeset.
[NO ISSUE][FUN] Add more data types for external library

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

1. Added more types for external library.

2. Added test case for data types.

3. Fixed minor bug where the parameter type is not trimmed in UDF.

Change-Id: I6ce73e791533b0617074536e0d841242d9e0ee31

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2871

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 12 more files in changeset.
[NO ISSUE] User-defined Function Documentation update

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

1. Updated the UDF documentation to be consisten with current master.

2. Cleaned default UDF package to remove useless UDFs.

3. Added the example in documentation as a test case for IT.

4. Reorganized the documentation to keep up with the new structure.

5. Minor changes to other documentation pages to keep style consistent.

Change-Id: I17b1b4d639ca38689298ce88145257e794eb90e1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2804

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 27 more files in changeset.
[ASTERIXDB-2148][FUN] Add init parameter for external UDF

- user model changes: no

- storage format changes: no

- interface changes: yes

Added parameters to LibraryFunction in library.xsd.

Details:

By enabling init function in external UDF, a user can reuse the same UDF

implementation with different paramters. One example can be to reuse the

same Machine Learning algorithm with different model files by assigning

different file paths to the UDF parameter.

Change-Id: I567ce0bcac288267595b2565e53fea61e16fbd65

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2107

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 35 more files in changeset.
Fix uniontype compatibility issue in TweetParser

1. Fix compatibility issue of UnionType in TweetParser.

2. Add unit test for TweetParser, covering missing attribute record

filtering.

Change-Id: Id7e316d20f929236b3fa17618bb8f87d28ac7efc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1786

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Steven Jacobs <sjaco002@ucr.edu>

  1. … 3 more files in changeset.
ASTERIXDB-1881, ASTERIXDB-1882

1. Fix ASTERIXDB-1882, add Kermit license for ICanEatGlass.txt

2. Partial fix for ASTERIXDB-1881:

a. beer sample files removed

b. related tests commented out pending replacement test data

Change-Id: I3597dce962e3c640206671fcca9d4b9f9f5dd791

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1676

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

  1. … 13 more files in changeset.
AsterixDB Rat Execution Audit & Fixes

Change-Id: I3d771c5b63eaef4b6a0b4da769039ed5bca17736

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1609

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -134
    • +0
    ./classad-with-temporals.classads
    • -0
    • +1106
    ./classad/August16-20-long.txt
    • -0
    • +134
    ./classad/classad-with-temporals.classads
    • -0
    • +364
    ./classad/functional_tests.txt
    • -0
    • +12869
    ./classad/jobads.new
    • -0
    • +1106
    ./classad/jobads.old
    • -0
    • +22732
    ./classad/jobads.txt
    • -0
    • +1
    ./classad/results/classad-with-temporals.adm
    • -0
    • +684032
    ./classad/testdata.txt
    • -0
    • +365
    ./classad/tests.txt
    • -0
    • +207
    ./data/countriesCapitals.properties
  1. … 479 more files in changeset.
Fix for ASTERIXDB-1738: Change feed fails to delete record with meta PK

Change-Id: I5ce8d9c69f96593ee305cfad4b44e486c9f1d6cc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1351

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 8 more files in changeset.
ASTERIXDB-1478: fix the utf8 reader.

1. Fix the ASTERIXDB-1478.

2. Add the utf8 testCases.

Change-Id: Idb302dc604fcd71811de550d3d4bd727c81a13ee

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1077

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

  1. … 7 more files in changeset.
Update adm.grammar and printers for double/float

adm.grammar was not accepting suffixed doubles. This was breaking

a lot of round-trip ADM cases. I also changed the default print for

float and double to not have a suffix, because this makes the output

very odd (NaNd, NaNf, -Infinityf). The print mode for integers

has also been changed to omit the suffix, but, similarly the old

format is still accepted.

Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770

Reviewed-on: https://asterix-gerrit.ics.uci.edu/932

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <michael.blow@couchbase.com>

  1. … 500 more files in changeset.
Fix Decoding of byte[] Records

Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/951

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -0
    • +149
    ./ICanEatGlass.txt
  1. … 3 more files in changeset.
ASTERIXDB-1470 Fix escapes in String values in ClassAd Parser

Change-Id: Id6e4e25263c5a6f0efe26773da7c3b8fcf7e2427

Reviewed-on: https://asterix-gerrit.ics.uci.edu/915

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <michael.blow@couchbase.com>

  1. … 3 more files in changeset.
Normalize XML Whitespace

Normalize whitespace in project XML files (e.g. pom.xml), to two-spaces

per indentation level.

Cleanup rewriter error messages for user-defined functions

Change-Id: Ic06e3ff4431508d878e0cc614fbf957887a3c682

Reviewed-on: https://asterix-gerrit.ics.uci.edu/836

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

  1. … 167 more files in changeset.
Move merged files

    • -0
    • +134
    ./classad-with-temporals.classads
    • -0
    • +1
    ./results/classad-with-temporals.adm
  1. … 162 more files in changeset.