org

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Previously, we would still attempt to write through the network

in case an ingestion task is interrupted.

- The goal was to try and get as much data in as possible but in

the case where the cluster was in a bad state, this could

lead to hanging threads.

- After this change, each record reader must implement the stop

method correctly to allow for graceful stop while interrupts

will always mean abort the task and return as soon as possible.

Change-Id: I6119617d133fb161a48b39f9812ec79e0189975b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2428

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Move the IO threads from BufferCache to IOManager to cover all

IO uses that go through the IOManager.

Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2417

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Previously, the SplitOperatorDescriptor didn't follow the

IFrameWriter protocol in case of failure which lead to having

some open resources after the job.

- This caused so many failures in Cancellation tests.

- This change also increases the rate of cancellation during the

cancellation tests to ensure that similar problems are found.

Change-Id: I3166895589e1ab7355d689397f676f7da5c9809f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2399

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface changes: yes

- IIndexCursor.close() is now idempotent and can be called on

a closed cursor.

- IIndexCursor.destroy() is now idempotent and can be called

on a destroyed cursor.

- Add IIndexAccessor.destroy() letting the accessor know it is

safe to destroy its reusable cursors and operation contexts.

- Add IIndexOperationContext.destroy() letting the context

know that the user is done with it and allow it to release

resources

details:

- Previously, implementations of the IIndexCursor interface

didn't enforce the interface contract. This change enforces

the contract for all the implementations.

- With the enforcement of the contract, all the users of the

cursors are expected to follow and enforce the expected lifecycle.

- Test cases were added.

Change-Id: I98a7a8b931eb24dbe11bf2bdc61b754ca28ebdf9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2324

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Change-Id: I4faa141c1a8c9700d5e9ac50b839acc9d1eede73

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2310

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: yes

- replace IIndexCursor.reset with close

- replace IIndexCursor.close with destroy

Details:

- This change is the first step towards fixing the behavior

of implementors/callers of the IIndexCursor interface

- In this change, we simply rename the reset -> close

and close -> destroy and we write down the javadocs

explaining the semantics of the interface.

- LSM Index Cursors don't implements ITreeIndexCursor

anymore.

Change-Id: I64cf8c0a5473268bdfd71fd560ee6b3bff219ce9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2238

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

To be consistent with the other JSON-like syntax in defining

configurations, CREATE FEED will change to use JSON object instead of

key-value pairs. Also, the <USING> adapter_name syntax is removed. The

adapter name becomes as part of the configuration. After this change,

the feed configuration are specified as:

<CREATE> <FEED> testFeed <WITH> {

"adapter-name" : "localfs",

"path" : "localhost://../../../../../tweets.json",

"format" : "adm",

"type-name" : "typeTweet"

};

This patch also fixes two minor mistakes when drop feed and adapter in

Metadata.

Change-Id: I2dfb0fdf74d28ae0c45dafcf6babb624bd8b2149

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2209

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: yes

Some functions can be datasources

- storage format changes: no

- interface changes: yes

- Add IDatasourceFunction: A function that is also a datasource

- Add IFunctionToDataSourceTransformer: transform an unnest

function into a datascan during compilation

Details:

- Currently, functions are location agnostic and are run on

parameters that are either passed through them during compile

time or runtime.

- An exception to this is the dataset function which has

an associated location constraints running on the nodes

which host the dataset.

- In this change, we introduce a general framework that allows

creation of new functions similar to the dataset function.

- Such functions are called datasource Functions.

- A datasource function takes constant parameters and run on

a set of partitions similar to the dataset function.

- The first example of such functions is the DatasetResources

function.

- The DatasetResources function takes two parameters, a dataverse

and a dataset. It is then run on all nodes and returns a set

of dataset resources.

- Test cases are added for this function.

Change-Id: Ibcf807ac713a21e8f4d59868525467386e801303

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2216

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Tested-by: abdullah alamoudi <bamousaa@gmail.com>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Replace java.util.logging by Log4j2.

- Excluded classes due to their tests:

- IoUtil

- Tracer

Change-Id: Ic137571292f45de1f1994c61d328b97185012197

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2226

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Delete managix installer method and all dependencies

- Remove xml-based configuration

Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2155

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Ia6f67c6370da80f19e6a51b957009816805b6428

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2205

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Contrib: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: yes

- Make IDataParserFactory.setRecordType()

to throw AsterixException

- Remove unused throws exception from

IAsterixListBuilder.reset()

Details:

- 4X faster than the current ADM parser.

- Uses lower number of temporary buffers.

- Parse GeoJSON geometry objects if defined

only for POINT, LINE and POLYGON.

- Parse temporal values from strings if defined

only for DATE, TIME, DATETIME.

Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2076

Reviewed-by: Michael Blow <mblow@apache.org>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Eliminate the need to read the storage root dir name

from cluster properties and use a fixed name (storage).

- Eliminate the need to maintain root_metadata file.

Change-Id: I4e9772e9da10cff33f11353610788ba541a35571

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2182

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface changes: replace AsterixException on signatures

Details:

This change is the first step towards removing AsterixException from

all interfaces.

Change-Id: I3e858576f39f671cbf5eb14adc7a22aab1335faf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2135

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

Change-Id: Icf10b6df0fdc006675d8f0da6fd06d50200c6b6a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2098

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Current the result from UDF doesn't have type check. It's possible to

write data into result frame with a different datatype. This will cause

unpredicted behavior when reading the data. Also, to keep things

simpler, when return data type is not valid, we throw exception instead

of return null.

Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2082

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Steven Jacobs <sjaco002@ucr.edu>

- user model changes: no

- storage format changes: no

- interface changes: yes

Trace categories in the ITracer interface are represented by long

values where each bit represents a category.

Introduce ITraceCategoryRegistry, an interface for a registry/mapping

from Strings to bit positions representing categories.

- add simple tests for Tracer and TraceCategoryRegistry

Change-Id: I3f26ae988d3786ef4ddb17e8fe78f911e7e628f1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2087

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

Current implementation of feed uses handcraft AQL queries for creating

feed pipeline. This causes a lot of issues and does not support SQL++

very well. Also, there is an overhead for parsing the query everytime.

In this patch, it's replaced with compiled statement in SQL++ which

provides support for attaching UDF to feed as well.

Details:

1. Remove SubscribeFeedStatement.

2. Remove SubscribeFeed related query compilation code, and reuse the

upsert dataflow.

3. Added SQL++ User Defined Function support for feed, including adding

multiple functions to one feed.

4. Related test cases added.

5. Change the default behavior of feed to be upsert instead of upsert.

'insert-feed' option is provided for experiment uses.

6. This patch also fixes several feed related bugs: [ASTERIXDB-2085]

[ASTERIXDB-2124].

Change-Id: I0ae5a837613780a4d2c90c98139fdc6d5e040cc9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2059

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Trace the ingestion performance at store side

Change-Id: I80f41429d23cb46385e6672bfd59715249c3b7ba

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2074

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

- Remove unused ActiveRuntimeManager

- Rename StatsRequestMessage -> ActiveStatsRequestMessage

- Add ActiveManager API to return all active runtimes

- Interrupt running HTTP requests after 5s upon shutdown

- Log thread dump when HTTP requests do not complete after interruption

Change-Id: I79249f7cd42496d6679eb9b0acbe8cda1892f9d3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2021

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Previously, we create the cluster state manager using the

singleton pattern.

- After this change, cluster state manager is created

as part of the cc application start.

- To access the cluster state manager after this change,

the cc application context is used.

Change-Id: Id6532245033ac4c6f6aa9f193539944eecb832f7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1944

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: yes

-IActiveEntityEventSubscriber.sync() does not throw failure anymore

and caller is responsible for checking for failures.

details:

- Previously, certain kinds of failures are sometimes thrown

and sometimes not when syncing a subscriber. This lead to

confusions and bugs. After this change, the caller to sync

is responsible for checking for failures.

Change-Id: I85146028be70f4631d1ef2696489a4624bf23ad4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1986

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

1. Add connection size check for start feed statement.

2. Remove useless/unassigned variable in RSS feed.

Change-Id: Ic6715b3983ee8a0bb042ef5f34f30381c99466da

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1963

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Failures that happen in feed while reading from external

sources allows ingestion pipeline to close gracefully

pushing parsed records in the frame forward before

failing.

- There was an assumption that when hasNext() or next()

are being called on a data reader and we fail, then

the failure didn't affect the integrity of the pipeline.

- This assumption is incorrect as hasNext() and next()

can themselves flush the pipeline and if the failure

happened during the flush call, the pipeline must be

failed.

Change-Id: Ib9be729088bd94338ef2353333eaea34ba3da99f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1968

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- The abort feed message stops the reader and wait for the

dataflow controller to signal end of life.

- If the reader returns true to stop but the dataflow controller

never signal ends, it can get stuck.

- This change adds a timeout after which, the task thread is

interrupted.

Change-Id: If609a8343767ee7a80689a58af35a1b3fca2964b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1964

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[ASTERIXDB-2023][ING] Introduce Enums instead of using bytes

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Only nodes which are known to cluster manager are added

to the list of nodes pending removal. Other nodes are ignored

- Enums introduced:

- ActiveEvent.Kind

- ActivePartitionMessage.Event

- Remove AdapterRuntimeManager

- Remove AdapterExecutor

Change-Id: I7044896559798426c04a3f46861bc5335b25d140

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1921

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: wait for completion only returns

when the entity becomes inactive.

- storage format changes: no

- interface changes:

01) Introduce:

IMetadataLockManager for entity locking.

IActiveNotificationHandler for handling active events.

IRetryPolicy for recovery of failed active jobs.

IActiveEntityController for controlling active entities.

02) IJobLifecycleListener.notifyJobFinish now passes the

JobStatus and Exceptions.

03) IActiveEntityEventsListener.isActive() returns true,

if entity is active, false otherwise.

04) IActiveEntityEventsListener.unregister() removes the

listener upon entity deletion.

05) IActiveEntityEventsListener.getJobFailure() returns

the job failure if the entity is in a failed state.

06) IStatementExecutor.getComponentProvider() returns

the storage component provider.

07) IStatementExecutor.getApplicationContext() returns

the application context.

08) IMetadataManager.upsertEntity to perfrom metadata

entities' upsert operations.

09) IMetadataNode.upsertEntity to perfrom metadata

entities' upsert operations

10) ICcApplicationContext.getMetadataLockManager() returns

the lock manger.

11) ICcApplicationContext.getClusterStateManager() returns

the cluster state manager.

details:

- Starting and stopping of active entities now go through

their listeners rather than having the listener indicating

active entity and not having it indicating inactive entity.

This facilitates suspend/resume operations of long running

active jobs for the sake of DDL operations or topology

changes.

- Unit tests for the vast majority of code paths and

different possible scenarios have been added.

Change-Id: Ifeac8c73e6bad39a13663b84a52121356e3c6b40

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1875

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1901

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

Change-Id: Ia8dd896f6abe34532f2cce70a4fc7632d7a21910

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1886

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>