Clone Tools
  • last updated 19 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2760][COMP] Improve function call resolution

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Refactor function call resolution and perform it earlier,

before GROUP BY expressions are substituted

- Consolidate gby-expr testcases into a single one

- Introduce QueryTranslator.handleDeclareFunctionStatement()

- Rename existing SqlppCaseExpressionVisitor to

SqlppCaseAggregateExtractionVisitor

- Move CASE expression rewriting code from

SqlppBuiltinFunctionRewriteVisitor into a separate visitor:

SqlppCaseExpressionVisitor

- Remove function name normalization code from SqlppAstPrintVisitor

and updated existing reference results

Change-Id: I527ffbff487b8534f66ca27d48788e96c65aec9b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/7264

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -1
    • +1
    ./ngram-edit-distance-inline/ngram-edit-distance-inline.4.ast
    • -1
    • +1
    ./ngram-edit-distance/ngram-edit-distance.4.ast
    • -3
    • +3
    ./ngram-jaccard-inline/ngram-jaccard-inline.4.ast
    • -3
    • +3
    ./olist-edit-distance-inline/olist-edit-distance-inline.4.ast
    • -3
    • +3
    ./olist-edit-distance/olist-edit-distance.4.ast
    • -3
    • +3
    ./olist-jaccard-inline/olist-jaccard-inline.4.ast
    • -3
    • +3
    ./ulist-jaccard-inline/ulist-jaccard-inline.4.ast
    • -3
    • +3
    ./word-jaccard-inline/word-jaccard-inline.4.ast
  1. … 1151 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./ngram-edit-distance-inline/ngram-edit-distance-inline.4.ast
    • -2
    • +2
    ./ngram-edit-distance/ngram-edit-distance.4.ast
    • -2
    • +2
    ./ngram-jaccard-inline/ngram-jaccard-inline.4.ast
    • -2
    • +2
    ./olist-edit-distance-inline/olist-edit-distance-inline.4.ast
    • -2
    • +2
    ./olist-edit-distance/olist-edit-distance.4.ast
    • -2
    • +2
    ./olist-jaccard-inline/olist-jaccard-inline.4.ast
    • -2
    • +2
    ./ulist-jaccard-inline/ulist-jaccard-inline.4.ast
    • -2
    • +2
    ./word-jaccard-inline/word-jaccard-inline.4.ast
  1. … 1505 more files in changeset.
[NO ISSUE][COMP] Function references cleanup

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

    • -2
    • +2
    ./ngram-edit-distance-inline/ngram-edit-distance-inline.4.ast
    • -2
    • +2
    ./ngram-edit-distance/ngram-edit-distance.4.ast
    • -2
    • +2
    ./ngram-jaccard-inline/ngram-jaccard-inline.4.ast
    • -2
    • +2
    ./olist-edit-distance-inline/olist-edit-distance-inline.4.ast
    • -2
    • +2
    ./olist-edit-distance/olist-edit-distance.4.ast
    • -2
    • +2
    ./olist-jaccard-inline/olist-jaccard-inline.4.ast
    • -2
    • +2
    ./ulist-jaccard-inline/ulist-jaccard-inline.4.ast
    • -2
    • +2
    ./word-jaccard-inline/word-jaccard-inline.4.ast
  1. … 1572 more files in changeset.
ASTERIXDB-1539: add aliases for several builtin types and builtin functions.

- tinyint for int8;

- smallint for int16;

- integer(or, int) for int32;

- bigint for int64;

- year_month_duration for year-month-duration;

- day_time_duration for day-time-duration;

- timestamp for datetime;

- double precision for double;

int8, int16, int32, int64, year-month-duration and day-time-duration

is going to be deprecated.

In addition, it

- converts underscores to hypens for SQL++ functions;

- uses "array_" prefix for builtin aggregation functions.

Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1199

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -4
    • +4
    ./ngram-edit-distance-inline/ngram-edit-distance-inline.1.ast
    • -4
    • +4
    ./ngram-edit-distance/ngram-edit-distance.1.ast
    • -2
    • +2
    ./ngram-jaccard-inline/ngram-jaccard-inline.1.ast
    • -4
    • +4
    ./olist-edit-distance-inline/olist-edit-distance-inline.1.ast
    • -4
    • +4
    ./olist-edit-distance/olist-edit-distance.1.ast
    • -4
    • +4
    ./olist-jaccard-inline/olist-jaccard-inline.1.ast
    • -4
    • +4
    ./ulist-jaccard-inline/ulist-jaccard-inline.1.ast
    • -2
    • +2
    ./word-jaccard-inline/word-jaccard-inline.1.ast
  1. … 3550 more files in changeset.
ASTERIXDB-1383: reduce the number of lines for "AS".

Change-Id: Ic655bf25701f33230787d175b78bedc489909cb0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/822

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -4
    • +2
    ./ngram-edit-distance-inline/ngram-edit-distance-inline.4.ast
    • -4
    • +2
    ./ngram-edit-distance/ngram-edit-distance.4.ast
    • -4
    • +2
    ./ngram-jaccard-inline/ngram-jaccard-inline.4.ast
    • -4
    • +2
    ./olist-edit-distance-inline/olist-edit-distance-inline.4.ast
    • -4
    • +2
    ./olist-edit-distance/olist-edit-distance.4.ast
    • -4
    • +2
    ./olist-jaccard-inline/olist-jaccard-inline.4.ast
    • -4
    • +2
    ./ulist-jaccard-inline/ulist-jaccard-inline.4.ast
    • -4
    • +2
    ./word-jaccard-inline/word-jaccard-inline.4.ast
  1. … 1708 more files in changeset.