Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2760][COMP] Improve function call resolution

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Refactor function call resolution and perform it earlier,

before GROUP BY expressions are substituted

- Consolidate gby-expr testcases into a single one

- Introduce QueryTranslator.handleDeclareFunctionStatement()

- Rename existing SqlppCaseExpressionVisitor to

SqlppCaseAggregateExtractionVisitor

- Move CASE expression rewriting code from

SqlppBuiltinFunctionRewriteVisitor into a separate visitor:

SqlppCaseExpressionVisitor

- Remove function name normalization code from SqlppAstPrintVisitor

and updated existing reference results

Change-Id: I527ffbff487b8534f66ca27d48788e96c65aec9b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/7264

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -1
    • +1
    ./insert-with-autogenerated-pk_adm_01/insert-with-autogenerated-pk_adm_01.3.ast
    • -1
    • +1
    ./insert-with-autogenerated-pk_adm_02/insert-with-autogenerated-pk_adm_02.3.ast
    • -1
    • +1
    ./insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_adm_01/load-with-autogenerated-pk_adm_01.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_adm_02/load-with-autogenerated-pk_adm_01.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_adm_03/load-with-autogenerated-pk_adm_03.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_adm_04/load-with-autogenerated-pk_adm_04.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_csv_01/load-with-autogenerated-pk_csv_01.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_csv_02/load-with-autogenerated-pk_csv_02.3.ast
    • -1
    • +1
    ./load-with-autogenerated-pk_txt_01/load-with-autogenerated-pk_txt_01.3.ast
    • -1
    • +1
    ./load-with-ngram-index-open/load-with-ngram-index-open.3.ast
    • -1
    • +1
    ./load-with-ngram-index/load-with-ngram-index.3.ast
    • -2
    • +2
    ./load-with-rtree-index-open/load-with-rtree-index-open.3.ast
    • -2
    • +2
    ./load-with-rtree-index/load-with-rtree-index.3.ast
    • -3
    • +3
    ./load-with-word-index-open/load-with-word-index-open.3.ast
  1. … 1148 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./compact-dataset-and-its-indexes/compact-dataset-and-its-indexes.5.ast
    • -1
    • +1
    ./delete-from-loaded-dataset-with-index/delete-from-loaded-dataset-with-index.5.ast
    • -1
    • +1
    ./delete-from-loaded-dataset/delete-from-loaded-dataset.3.ast
    • -1
    • +1
    ./delete-multi-statement/delete-multi-statement.3.ast
    • -1
    • +1
    ./delete-syntax-change/delete-syntax-change.3.ast
    • -1
    • +1
    ./empty-load-with-index/empty-load-with-index.3.ast
    • -1
    • +1
    ./insert-and-scan-dataset/insert-and-scan-dataset.3.ast
    • -1
    • +1
    ./insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.ast
    • -1
    • +1
    ./insert-into-empty-dataset-with-index/insert-into-empty-dataset-with-index.3.ast
    • -1
    • +1
    ./insert-into-empty-dataset/insert-into-empty-dataset.3.ast
    • -1
    • +1
    ./insert-into-loaded-dataset-with-index_01/insert-into-loaded-dataset-with-index_01.5.ast
    • -1
    • +1
    ./insert-into-loaded-dataset-with-index_02/insert-into-loaded-dataset-with-index_02.5.ast
    • -1
    • +1
    ./insert-into-loaded-dataset_01/insert-into-loaded-dataset_01.3.ast
    • -1
    • +1
    ./insert-into-loaded-dataset_02/insert-into-loaded-dataset_02.3.ast
  1. … 1502 more files in changeset.
[NO ISSUE][COMP] Function references cleanup

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

    • -1
    • +1
    ./compact-dataset-and-its-indexes/compact-dataset-and-its-indexes.5.ast
    • -1
    • +1
    ./create-drop-cltype/create-drop-cltype.3.ast
    • -1
    • +1
    ./create-drop-opntype/create-drop-opntype.3.ast
    • -1
    • +1
    ./delete-from-loaded-dataset-with-index/delete-from-loaded-dataset-with-index.5.ast
    • -1
    • +1
    ./delete-from-loaded-dataset/delete-from-loaded-dataset.3.ast
    • -1
    • +1
    ./delete-multi-statement/delete-multi-statement.3.ast
    • -1
    • +1
    ./delete-syntax-change/delete-syntax-change.3.ast
    • -1
    • +1
    ./drop-empty-secondary-indexes/drop-empty-secondary-indexes.3.ast
    • -1
    • +1
    ./empty-load-with-index/empty-load-with-index.3.ast
    • -1
    • +1
    ./insert-and-scan-dataset-with-index/insert-and-scan-dataset-with-index.3.ast
    • -1
    • +1
    ./insert-and-scan-dataset/insert-and-scan-dataset.3.ast
    • -1
    • +1
    ./insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.ast
    • -1
    • +1
    ./insert-into-empty-dataset-with-index/insert-into-empty-dataset-with-index.3.ast
    • -1
    • +1
    ./insert-into-empty-dataset/insert-into-empty-dataset.3.ast
  1. … 1569 more files in changeset.
[ASTERIXDB-2078][SQL] DISTINCT modifier for aggregate functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Adds support for DISTINCT modifier in aggregate functions:

AGG(DISTINCT expr), ARRAY_AGG(DISTINCT expr), COLL_AGG(DISTINCT expr)

where AGG = COUNT | SUM | AVG | MIN | MAX

Change-Id: I52772349cbcbfc68a3a1ff261d610871ca38748d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1987

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 361 more files in changeset.
ASTERIXDB-1539: add aliases for several builtin types and builtin functions.

- tinyint for int8;

- smallint for int16;

- integer(or, int) for int32;

- bigint for int64;

- year_month_duration for year-month-duration;

- day_time_duration for day-time-duration;

- timestamp for datetime;

- double precision for double;

int8, int16, int32, int64, year-month-duration and day-time-duration

is going to be deprecated.

In addition, it

- converts underscores to hypens for SQL++ functions;

- uses "array_" prefix for builtin aggregation functions.

Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1199

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -5
    • +5
    ./compact-dataset-and-its-indexes/compact-dataset-and-its-indexes.1.ast
    • -2
    • +2
    ./create-drop-cltype/create-drop-cltype.1.ast
    • -2
    • +2
    ./create-drop-opntype/create-drop-opntype.1.ast
    • -5
    • +5
    ./delete-from-loaded-dataset-with-index/delete-from-loaded-dataset-with-index.1.ast
    • -5
    • +5
    ./delete-from-loaded-dataset/delete-from-loaded-dataset.1.ast
    • -20
    • +20
    ./delete-multi-statement/delete-multi-statement.1.ast
    • -5
    • +5
    ./delete-syntax-change/delete-syntax-change.1.ast
    • -1
    • +1
    ./drop-empty-secondary-indexes/drop-empty-secondary-indexes.1.ast
    • -4
    • +4
    ./empty-load-with-index/empty-load-with-index.1.ast
    • -2
    • +2
    ./insert-and-scan-dataset-with-index/insert-and-scan-dataset-with-index.1.ast
    • -1
    • +1
    ./insert-and-scan-dataset/insert-and-scan-dataset.1.ast
    • -1
    • +1
    ./insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.1.ast
    • -1
    • +1
    ./insert-duplicated-keys/insert-duplicated-keys.1.ast
    • -3
    • +3
    ./insert-into-empty-dataset-with-index/insert-into-empty-dataset-with-index.1.ast
  1. … 3547 more files in changeset.
ASTERIXDB-1383: reduce the number of lines for "AS".

Change-Id: Ic655bf25701f33230787d175b78bedc489909cb0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/822

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +1
    ./compact-dataset-and-its-indexes/compact-dataset-and-its-indexes.5.ast
    • -2
    • +1
    ./create-drop-cltype/create-drop-cltype.3.ast
    • -2
    • +1
    ./create-drop-opntype/create-drop-opntype.3.ast
    • -2
    • +1
    ./delete-from-loaded-dataset-with-index/delete-from-loaded-dataset-with-index.5.ast
    • -2
    • +1
    ./delete-from-loaded-dataset/delete-from-loaded-dataset.3.ast
    • -2
    • +1
    ./delete-multi-statement/delete-multi-statement.3.ast
    • -2
    • +1
    ./delete-syntax-change/delete-syntax-change.3.ast
    • -2
    • +1
    ./drop-empty-secondary-indexes/drop-empty-secondary-indexes.3.ast
    • -2
    • +1
    ./empty-load-with-index/empty-load-with-index.3.ast
    • -2
    • +1
    ./insert-and-scan-dataset-with-index/insert-and-scan-dataset-with-index.3.ast
    • -2
    • +1
    ./insert-and-scan-dataset/insert-and-scan-dataset.3.ast
    • -2
    • +1
    ./insert-and-scan-joined-datasets/insert-and-scan-joined-datasets.3.ast
    • -2
    • +1
    ./insert-into-empty-dataset-with-index/insert-into-empty-dataset-with-index.3.ast
    • -2
    • +1
    ./insert-into-empty-dataset/insert-into-empty-dataset.3.ast
  1. … 1705 more files in changeset.