Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE][FUN] Remove unused scalar aggregates

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove unused function definitions for scalar global/local

aggregate functions

- Cleanup testcases for avg function

- Removed unused testcases

Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3429

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +37
    ./avg_double/avg_double.4.ast
    • -1
    • +1
    ./avg_double_null/avg_double_null.1.ast
    • -0
    • +1
    ./avg_double_null/avg_double_null.2.ast
    • -0
    • +36
    ./avg_double_null/avg_double_null.4.ast
    • -11
    • +27
    ./avg_empty_01/avg_empty_01.3.ast
    • -0
    • +37
    ./avg_float/avg_float.4.ast
    • -13
    • +0
    ./avg_float_null/avg_float_nu.1.ast
  1. … 329 more files in changeset.
[NO ISSUE][FUN] Remove AST tests for statistical functions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove AST tests for statistical functions

Change-Id: Ided329f38df568a32d2e8bca8f6125c23c04a07b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3279

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

    • -2
    • +0
    ./kurtosis_double/kurtosis_double.1.ast
    • -19
    • +0
    ./kurtosis_double/kurtosis_double.3.ast
    • -13
    • +0
    ./kurtosis_double_null/kurtosis_double_null.1.ast
    • -23
    • +0
    ./kurtosis_double_null/kurtosis_double_null.3.ast
    • -0
    • +0
    ./kurtosis_empty_01/kurtosis_empty_01.1.ast
    • -24
    • +0
    ./kurtosis_empty_01/kurtosis_empty_01.3.ast
    • -8
    • +0
    ./kurtosis_empty_02/kurtosis_empty_02.1.ast
    • -19
    • +0
    ./kurtosis_empty_02/kurtosis_empty_02.3.ast
    • -24
    • +0
    ./kurtosis_float/kurtosis_float.3.ast
    • -13
    • +0
    ./kurtosis_float_null/kurtosis_float_null.1.ast
    • -23
    • +0
    ./kurtosis_float_null/kurtosis_float_null.3.ast
    • -24
    • +0
    ./kurtosis_int16/kurtosis_int16.3.ast
    • -13
    • +0
    ./kurtosis_int16_null/kurtosis_int16_null.1.ast
  1. … 610 more files in changeset.
[ASTERIXDB-2459][FUN] Add skewness and kurtosis aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add skewness and kurtosis function and test cases

2. Add skewness and kurtosis distinct functions

3. Add documentation for skewness and kurtosis

4. Cleaned up some files related to the stddev and var tests cases

5. Change stddev() to stddev_samp() and var() to var_samp()

Change-Id: Iae0d7fc9d5ab3676b23b27ad62a730598221d8a5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3037

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -4
    • +56
    ./agg_null_rec_1/agg_null_rec_1.3.ast
    • -4
    • +42
    ./agg_number_rec/agg_number_rec.3.ast
    • -0
    • +2
    ./kurtosis_double/kurtosis_double.1.ast
    • -0
    • +19
    ./kurtosis_double/kurtosis_double.3.ast
    • -0
    • +13
    ./kurtosis_double_null/kurtosis_double_null.1.ast
    • -0
    • +23
    ./kurtosis_double_null/kurtosis_double_null.3.ast
    • -0
    • +0
    ./kurtosis_empty_01/kurtosis_empty_01.1.ast
    • -0
    • +24
    ./kurtosis_empty_01/kurtosis_empty_01.3.ast
    • -0
    • +8
    ./kurtosis_empty_02/kurtosis_empty_02.1.ast
    • -0
    • +19
    ./kurtosis_empty_02/kurtosis_empty_02.3.ast
    • -0
    • +0
    ./kurtosis_float/kurtosis_float.1.ast
    • -0
    • +24
    ./kurtosis_float/kurtosis_float.3.ast
  1. … 1330 more files in changeset.
[ASTERIXDB-2460][FUN] Fix sum() overflow bug

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Fixed the sum() overflow problem. Now the sum() function will

return either bigint or double based on the input types.

- Added sum() aggregate local, intermediate and global classes.

Currently, it is using the same class for the three steps and

checking the type using an if statement. Although the three

steps all have a very similar behavior, having them in split

classes makes it cleaner and easier to read and maintain in the

future.

- Added sum() aggregate local, intermediate and global for serialized

classes.

- Added sum() and serial sum() test cases and modified test cases

to cause the reported overflow issue.

- Added sum() and serial sum() test cases that cause a

Long.MAX_VALUE type overflow.

- Valid data type check is now part of the sum calculation to

avoid redundant steps.

Change-Id: I987417770b3bfbda6af29a27acc8c96dc8a99eb8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3012

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 172 more files in changeset.
[ASTERIXDB-2459][FUN] Add var() and var_pop() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add variance and variance population aggregation function and test cases

2. Add var() and var_pop() distinct functions

3. Add documentation for var() and var_pop()

4. Removed some empty tests cases from parser tests

Change-Id: If736c94146f1d6ee4dfa46a67737b1abd29c8e2d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3004

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -1
    • +52
    ./agg_null_rec_1/agg_null_rec_1.3.ast
    • -0
    • +38
    ./agg_number_rec/agg_number_rec.3.ast
    • -0
    • +0
    ./scalar_var/scalar_var.1.ast
    • -0
    • +222
    ./scalar_var/scalar_var.3.ast
    • -0
    • +0
    ./scalar_var_empty/scalar_var_empty.1.ast
    • -0
    • +27
    ./scalar_var_empty/scalar_var_empty.3.ast
    • -0
    • +0
    ./scalar_var_null/scalar_var_null.1.ast
    • -0
    • +234
    ./scalar_var_null/scalar_var_null.3.ast
    • -0
    • +9
    ./serial_var_double/serial_var_double.1.ast
    • -0
    • +1
    ./serial_var_double/serial_var_double.2.ast
    • -0
    • +54
    ./serial_var_double/serial_var_double.3.ast
    • -0
    • +9
    ./serial_var_double_null/serial_var_double_null.1.ast
  1. … 488 more files in changeset.
[ASTERIXDB-2459][FUN] Add sttdev_pop() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add stddev_pop aggregation function and test cases

2. Add stddev and stddev_pop distinct functions

3. Fix some stddev test case comments

4. Add documentation for stddev_pop

Change-Id: I1732d8d70eba26e12a6e68d0e0c621491ed6b3ae

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2997

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +26
    ./agg_null_rec_1/agg_null_rec_1.3.ast
    • -0
    • +19
    ./agg_number_rec/agg_number_rec.3.ast
    • -102
    • +219
    ./scalar_stddev/scalar_stddev.3.ast
    • -5
    • +25
    ./scalar_stddev_empty/scalar_stddev_empty.3.ast
    • -108
    • +231
    ./scalar_stddev_null/scalar_stddev_null.3.ast
    • -0
    • +14
    ./serial_stddev_double/serial_stddev_double.3.ast
    • -0
    • +14
    ./serial_stddev_double_null/serial_stddev_double_null.3.ast
    • -0
    • +14
    ./serial_stddev_empty/serial_stddev_empty.3.ast
    • -0
    • +14
    ./serial_stddev_float/serial_stddev_float.3.ast
    • -0
    • +14
    ./serial_stddev_float_null/serial_stddev_float_null.3.ast
    • -0
    • +14
    ./serial_stddev_int16/serial_stddev_int16.3.ast
    • -0
    • +14
    ./serial_stddev_int16_null/serial_stddev_int16_null.3.ast
  1. … 295 more files in changeset.
[ASTERIXDB-2459][FUN] Add sttdev() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Added stddev aggregation function and test cases

2. Added stddev to documentation and fixed some typos

3. Added serializable aggregate optimizer test

4. Change IncompatibleTypeException in aggregates to be deterministic

commit 26edb576f55a3d2308996f054a58ad43ab910f9b

Author: James Fang <jfang003@ucr.edu>

Date: Fri Oct 5 15:10:37 2018 -0700

Change-Id: Ia709669a9d20358f11ad28f453ae8ad8551f6334

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2990

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +27
    ./agg_null_rec_1/agg_null_rec_1.3.ast
    • -0
    • +19
    ./agg_number_rec/agg_number_rec.3.ast
    • -0
    • +0
    ./scalar_stddev/scalar_stddev.1.ast
    • -0
    • +105
    ./scalar_stddev/scalar_stddev.3.ast
    • -0
    • +0
    ./scalar_stddev_empty/scalar_stddev_empty.1.ast
    • -0
    • +7
    ./scalar_stddev_empty/scalar_stddev_empty.3.ast
    • -0
    • +0
    ./scalar_stddev_null/scalar_stddev_null.1.ast
    • -0
    • +111
    ./scalar_stddev_null/scalar_stddev_null.3.ast
    • -0
    • +9
    ./serial_stddev_double/serial_stddev_double.1.ast
    • -0
    • +1
    ./serial_stddev_double/serial_stddev_double.2.ast
    • -0
    • +40
    ./serial_stddev_double/serial_stddev_double.3.ast
    • -0
    • +9
    ./serial_stddev_double_null/serial_stddev_double_null.1.ast
  1. … 457 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./avg_double_null/avg_double_null.3.ast
    • -2
    • +2
    ./issue531_string_min_max/issue531_string_min_max.3.ast
  1. … 1502 more files in changeset.
[NO ISSUE][COMP] Function references cleanup

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

    • -1
    • +1
    ./avg_double_null/avg_double_null.3.ast
    • -2
    • +2
    ./issue531_string_min_max/issue531_string_min_max.3.ast
  1. … 1569 more files in changeset.
[ASTERIXDB-2078][SQL] DISTINCT modifier for aggregate functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Adds support for DISTINCT modifier in aggregate functions:

AGG(DISTINCT expr), ARRAY_AGG(DISTINCT expr), COLL_AGG(DISTINCT expr)

where AGG = COUNT | SUM | AVG | MIN | MAX

Change-Id: I52772349cbcbfc68a3a1ff261d610871ca38748d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1987

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./avg_double_null/avg_double_null.3.ast
  1. … 347 more files in changeset.
ASTERIXDB-1539: add aliases for several builtin types and builtin functions.

- tinyint for int8;

- smallint for int16;

- integer(or, int) for int32;

- bigint for int64;

- year_month_duration for year-month-duration;

- day_time_duration for day-time-duration;

- timestamp for datetime;

- double precision for double;

int8, int16, int32, int64, year-month-duration and day-time-duration

is going to be deprecated.

In addition, it

- converts underscores to hypens for SQL++ functions;

- uses "array_" prefix for builtin aggregation functions.

Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1199

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -5
    • +5
    ./avg_double_null/avg_double_null.1.ast
    • -1
    • +1
    ./issue531_string_min_max/issue531_string_min_max.1.ast
  1. … 3547 more files in changeset.
Add IS (NOT) NULL/MISSING/UNKOWN.

Change-Id: I7e4008d97f0d3a92816b90492dd8c887b05bac27

Reviewed-on: https://asterix-gerrit.ics.uci.edu/963

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -3
    • +2
    ./sum_null-with-pred/sum_null-with-pred.3.ast
  1. … 43 more files in changeset.
ASTERIXDB-1383: reduce the number of lines for "AS".

Change-Id: Ic655bf25701f33230787d175b78bedc489909cb0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/822

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -18
    • +9
    ./agg_null_rec_1/agg_null_rec_1.3.ast
    • -10
    • +5
    ./agg_number_rec/agg_number_rec.3.ast
    • -2
    • +1
    ./avg_double_null/avg_double_null.3.ast
  1. … 1705 more files in changeset.