Clone Tools
  • last updated 21 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2633][FUN] Fix LIKE to regex translation

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: I6138f62fdcd60bcc641f662d1fdb05b46dafbebf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3558

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 4 more files in changeset.
[ASTERIXDB-2626][*DB] Ignore dup fields in record construction, issue warning

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

Change the current behavior of throwing exceptions on duplicates fields

on a record to just picking one and return a warning when possible.

- added source location for auto generated name expressions.

- removed duplicate test cases from AQL test suite since SQL++ alraedy has it.

- updated test cases that used to throw exception on duplicate fields.

- updated an AST test case to reflect the new behaviour of picking one field.

- clean-ups in testsuite_sqlpp:

moved flwor let33 test case to its proper group.

moved ObjectsQueries, GeoQueries xml references up to where other xml refs.

Change-Id: I2d773b194f0e0f35720bb3fd63f1997239800762

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3519

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 53 more files in changeset.
[NO ISSUE][COMP] Option to disable DisjunctivePredicateToJoinRule

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Added compiler option "rewrite_or_as_join" that

disables DisjunctivePredicateToJoinRule

set rewrite_or_as_join "false";

Default value is 'true' (the rule is enabled)

Change-Id: Ifbde19b7371a351d13ac2b05efa70a42eddbae7b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3468

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 23 more files in changeset.
[NO ISSUE][FUN] Remove unused scalar aggregates

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove unused function definitions for scalar global/local

aggregate functions

- Cleanup testcases for avg function

- Removed unused testcases

Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3429

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +37
    ./aggregate-sql/avg_double/avg_double.4.ast
    • -0
    • +13
    ./aggregate-sql/avg_float/avg_float.1.ast
    • -0
    • +1
    ./aggregate-sql/avg_float/avg_float.2.ast
    • -11
    • +15
    ./aggregate-sql/avg_float/avg_float.3.ast
    • -0
    • +37
    ./aggregate-sql/avg_float/avg_float.4.ast
  1. … 329 more files in changeset.
[NO ISSUE][COMP] Change plan printing for window operators

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Print window operators as 'window-aggregate' in the query plan

- Add testcase for a window function call used in WHERE clause,

and a negative testcase

- Implement reset() for LogicalOperatorPrettyPrintVisitorJson

- Make IOptimizationContext.getPrettyPrintVisitor() return

AbstractLogicalOperatorPrettyPrintVisitor

Change-Id: I1446238a7c550abf618a72650c2a811fbc4dd710

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3397

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +48
    ./window/misc_01/misc_01.9.ast
  1. … 11 more files in changeset.
[ASTERIXDB-2545][COMP] Compiler error with window function call

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fixed compiler error when window function call

contains several aggregate functions

Change-Id: Iea946be7f9988bcf991566e4fea9e7a3565b3eaf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3344

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +26
    ./window/misc_01/misc_01.8.ast
  1. … 4 more files in changeset.
[NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- VariableCheckAndRewriteVisitor should create FieldAccessor

expressions when resolving identifiers as field accessors.

Currently it produces an internal function call in these cases.

FieldAccessor expressions will be converted into internal

function calls later by LangExpressionToPlanTranslator.

Change-Id: Icaab2a29f787439eebd67e44aa6a9e92df422a98

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3343

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

  1. … 31 more files in changeset.
[NO ISSUE][FUN] Remove AST tests for statistical functions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove AST tests for statistical functions

Change-Id: Ided329f38df568a32d2e8bca8f6125c23c04a07b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3279

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 610 more files in changeset.
[ASTERIXDB-2459][FUN] Add skewness and kurtosis aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add skewness and kurtosis function and test cases

2. Add skewness and kurtosis distinct functions

3. Add documentation for skewness and kurtosis

4. Cleaned up some files related to the stddev and var tests cases

5. Change stddev() to stddev_samp() and var() to var_samp()

Change-Id: Iae0d7fc9d5ab3676b23b27ad62a730598221d8a5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3037

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -8
    • +46
    ./aggregate-sql/agg_null/agg_null.3.ast
  1. … 1330 more files in changeset.
[ASTERIXDB-2519][COMP] Fix compiler error with range predicate

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fix compiler error (Could not infer type for variable ...)

when non-constant expressions are used in the range predicate

Change-Id: I8896e6c0743dcd5b608ebd5a5f25d3077047c789

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3187

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +67
    ./index-selection/range-search/range-search.5.ast
  1. … 5 more files in changeset.
[ASTERIXDB-2511][COMP] Refactor LET/WHERE clauses into a single list

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Consolidate LET and WHERE clauses into a single list in the SelectBlock

Change-Id: I9265dfc3adb9ef4d5eb963b0aa4d39c2ad0cc068

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3118

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 27 more files in changeset.
[ASTERIXDB-2505][COMP] Consolidate window operators rule

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Add optimizer rules that merge two window operators into one

- Improve existing optimizer rules to handle window operators

- Add tests for distinct aggregate in window operator

Change-Id: I5d0739d604d09f5445237d4fa3d56a2af8126bd7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3107

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +58
    ./window/misc_01/misc_01.7.ast
  1. … 53 more files in changeset.
[ASTERIXDB-2488][COMP] Support aggregate window functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Implement aggregate window functions:

agg_func() OVER (frame_var AS)? (PARTITION BY ... ORDER BY ... frame_spec)

- Where agg_func is a SQL/SQL++ aggregate function

- Fix percent_rank() to always return 0 for the first tuple

- Fix ntile() to handle NULL argument

- Log query after each rewrite rule in SqlppQueryRewriter

- Implement toString() for ADayTimeDuration, fix it for AYearMonthDuration

- Add seek() method to RunFileReader

Change-Id: If0f71118a04c2dbd3462070673d52e67f076b7e1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3049

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

    • -0
    • +7
    ./window/misc_01/misc_01.1.ast
    • -0
    • +2
    ./window/misc_01/misc_01.2.ast
    • -0
    • +209
    ./window/misc_01/misc_01.3.ast
    • -0
    • +45
    ./window/misc_01/misc_01.4.ast
    • -0
    • +77
    ./window/misc_01/misc_01.5.ast
    • -0
    • +50
    ./window/misc_01/misc_01.6.ast
  1. … 849 more files in changeset.
[ASTERIXDB-2422][STO] Introduce compressed storage

- user model changes: yes

- Add new configuration in the with-caluse to enable compression

- Add new nc configuration in the config file

- storage format changes: yes

- Pages of the primary index can be compressed

- Add a companion file (Look Aside File) with the compressed index

- Allow optional values in the LocalResource

- Add compression information in Metadata.Dataset

- interface changes: yes

- ICCApplicationContext:

- Add getCompressionManager()

- IBufferCache:

- Add getCompressedFileWriter(int fileId)

- ICachedPageInternal:

- Add setCompressedPageOffset(long offset)

- Add getCompressedPageOffset()

- Add setCompressedPageSize(int size)

- Add getCompressedPageSize()

Details:

- Add new integration test for this patch

- Fix ASTERIXDB-2464

- Add ddl-with-clause type validator

Additional details in the design document:

https://cwiki.apache.org/confluence/display/ASTERIXDB/Compression+in+AsterixDB

Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2857

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 189 more files in changeset.
[ASTERIXDB-2460][FUN] Fix sum() overflow bug

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Fixed the sum() overflow problem. Now the sum() function will

return either bigint or double based on the input types.

- Added sum() aggregate local, intermediate and global classes.

Currently, it is using the same class for the three steps and

checking the type using an if statement. Although the three

steps all have a very similar behavior, having them in split

classes makes it cleaner and easier to read and maintain in the

future.

- Added sum() aggregate local, intermediate and global for serialized

classes.

- Added sum() and serial sum() test cases and modified test cases

to cause the reported overflow issue.

- Added sum() and serial sum() test cases that cause a

Long.MAX_VALUE type overflow.

- Valid data type check is now part of the sum calculation to

avoid redundant steps.

Change-Id: I987417770b3bfbda6af29a27acc8c96dc8a99eb8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3012

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -3
    • +3
    ./aggregate-sql/sum_int8/sum_int8.3.ast
  1. … 171 more files in changeset.
[ASTERIXDB-2459][FUN] Add var() and var_pop() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add variance and variance population aggregation function and test cases

2. Add var() and var_pop() distinct functions

3. Add documentation for var() and var_pop()

4. Removed some empty tests cases from parser tests

Change-Id: If736c94146f1d6ee4dfa46a67737b1abd29c8e2d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3004

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +38
    ./aggregate-sql/agg_null/agg_null.3.ast
    • -0
    • +0
    ./aggregate-sql/scalar_var/scalar_var.1.ast
    • -0
    • +222
    ./aggregate-sql/scalar_var/scalar_var.3.ast
    • -0
    • +234
    ./aggregate-sql/scalar_var_null/scalar_var_null.3.ast
  1. … 488 more files in changeset.
[ASTERIXDB-2459][FUN] Add sttdev_pop() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add stddev_pop aggregation function and test cases

2. Add stddev and stddev_pop distinct functions

3. Fix some stddev test case comments

4. Add documentation for stddev_pop

Change-Id: I1732d8d70eba26e12a6e68d0e0c621491ed6b3ae

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2997

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +19
    ./aggregate-sql/agg_null/agg_null.3.ast
  1. … 295 more files in changeset.
[ASTERIXDB-2286][COMP][FUN][HYR] Parallel Sort Optimization

- user model changes: yes

- storage format changes: no

- interface changes: yes

details:

- new plan for sort operation which includes sampling and

replicating the stream of data to be sorted. Sort-merge connector

is removed from the plan. The sorted result now is in multiple partitions.

- new optimization rule to check whether full parallel sort is applicable.

- new Forward operator to read the replicated sort input stream and

to receive the ouput of the sampling.

- new sequential merge connector to merge a globally ordered result residing

in multiple partitions (in addition to the connector's partition computer).

- "asterix-lang-aql/pom.xml" is changed as a result of refactoring

code related to the range map handling.

- new private sampling function to generate the range map object

(local & global functions) & their type computers.

user model changes:

- new compiler property is added to enable and disable parallel sort.

interface changes:

- "ILogicalOperatorVisitor.java" includes Forward Operator.

- "ITuplePartitionComputer.java" includes initialize() to enable partitioner

to do some initialization. FieldRangePartitionComputerFactory uses it to

pick a range map.

- "ITuplePartitionComputerFactory.java". createPartitioner() is changed to

createPartitioner(IHyracksTaskContext hyracksTaskContext). Context is needed

for transferring the range map throught the context.

Change-Id: I73e128029a46f45e6b68c23dfb9310d5de10582f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2393

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +5
    ./misc/prefix-search/prefix-search.3.ast
    • -0
    • +10
    ./misc/stable_sort/stable_sort.3.ast
  1. … 355 more files in changeset.
[ASTERIXDB-2459][FUN] Add sttdev() aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Added stddev aggregation function and test cases

2. Added stddev to documentation and fixed some typos

3. Added serializable aggregate optimizer test

4. Change IncompatibleTypeException in aggregates to be deterministic

commit 26edb576f55a3d2308996f054a58ad43ab910f9b

Author: James Fang <jfang003@ucr.edu>

Date: Fri Oct 5 15:10:37 2018 -0700

Change-Id: Ia709669a9d20358f11ad28f453ae8ad8551f6334

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2990

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +19
    ./aggregate-sql/agg_null/agg_null.3.ast
    • -0
    • +105
    ./aggregate-sql/scalar_stddev/scalar_stddev.3.ast
  1. … 457 more files in changeset.
[ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- substring() should return NULL if starting offset is out of bounds

for given string or length is negative

Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2914

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +8
    ./string/substring2-4/substring2-4.3.ast
  1. … 17 more files in changeset.
[ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Introduce LET clauses for column alias expressions

instead of inlining them into ORDER BY/LIMIT clauses

- Fix incorrect visitor used in SubstituteGroupbyExpressionWithVariableVisitor

for rewriting LET clauses after GROUP BY

Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2905

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Contrib: Till Westmann <tillw@apache.org>

  1. … 41 more files in changeset.
[ASTERIXDB-2423][RT] Division by zero should return NULL

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Make DIV, /, MOD operators return NULL if the divisor is 0

- Add test case for if_inf() function

Change-Id: If2a45e842b840f721435b0715945a209e55b9dd4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2813

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +11
    ./numeric/divide_float/divide_float.1.ast
    • -4
    • +15
    ./numeric/divide_int16/divide_int16.1.ast
    • -4
    • +15
    ./numeric/divide_int16/divide_int16.2.ast
    • -4
    • +15
    ./numeric/divide_int32/divide_int32.1.ast
    • -4
    • +15
    ./numeric/divide_int32/divide_int32.2.ast
    • -4
    • +15
    ./numeric/divide_int64/divide_int64.1.ast
    • -4
    • +15
    ./numeric/divide_int64/divide_int64.2.ast
    • -4
    • +15
    ./numeric/divide_int8/divide_int8.1.ast
    • -4
    • +15
    ./numeric/divide_int8/divide_int8.2.ast
  1. … 45 more files in changeset.
[ASTERIXDB-2401][SQLPP] Support parameterized queries

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Support statement parameters: named ($name) and positional ($1 or ?)

- Enhance query service API to accept these parameters in the request

- Remove [?] index accessor from SQL++ grammar because it conflicts

with positional parameters ([0] can be used instead)

- Add testcases for parameterized queries

Change-Id: Ia612f731cd2370fccd54c4796bd9787fbea16766

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2707

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 98 more files in changeset.
[ASTERIXDB-2378][SQL] Add “DIV”, “MOD”, change “/“ for integers

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Make "/" operator return double if both operands are integers

- Add "DIV" operator which is the same as "/" except that

it returns integer if both operands are integers

(as "/" did before this change)

- Add "MOD" operator which is an alias for "%" operator

- Remove "IDIV" operator from the grammar

Change-Id: I7c6b0704ce60a03dd3c10e1c75cb9761acc56536

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2630

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +107
    ./numeric/divide_int16/divide_int16.2.ast
    • -0
    • +107
    ./numeric/divide_int32/divide_int32.2.ast
    • -0
    • +107
    ./numeric/divide_int64/divide_int64.2.ast
    • -0
    • +107
    ./numeric/divide_int8/divide_int8.2.ast
  1. … 37 more files in changeset.
[ASTERIXDB-2376][FUN] Negative offset for substring()

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support negative offset as an argument to substring()

(that means: count from the end of the string)

Change-Id: I849c38819ea2df2c203fd1d794c6b0b3a0eca9d1

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2626

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./string/substring2-4/substring2-4.3.ast
  1. … 11 more files in changeset.
[ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support SELECT variable.* in SQL++

- Include variables defined by LET clauses in the

output record created by SELECT *

- Add object_concat() function

- Add tests for these new features

- Fail testcase if its source directory is missing

- Fix testcases that did not run previously because

their source directories were incorrectly specified

Change-Id: I058dc0f45072a1398f6431e0c73ce680c4d8cdc7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2394

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

  1. … 126 more files in changeset.
[ASTERIXDB-2272][FUN] Count character positions from 0

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Count character positions in strings, binary from 0 instead of 1

- Affects following built-in functions:

position(), regexp_position(), substr()/subtring(),

sub_binary(), find-binary()

- Introduce new configuration property “compiler.stringoffset”

for backward compatibility

compiler.stringoffset = 0 - count from 0 (new default)

compiler.stringoffset = 1 - count from 1 (backwards-compatible setting)

Change-Id: Icdb2c241983d5f592b2695ef16eae9951518d7fd

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2342

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -1
    • +1
    ./string/substring2-1/substring2-1.3.ast
    • -1
    • +1
    ./string/substring2-3/substring2-3.3.ast
    • -1
    • +1
    ./string/substring_01/substring_01.3.ast
    • -2
    • +2
    ./tpch/query-issue562/query-issue562.3.ast
  1. … 95 more files in changeset.
[ASTERIXDB-2181][FUN] Check whether a function is usable at creation

Verify rewrite step on a function before allowing creation

Add negative tests for bad function declarations

Change-Id: I262b8cfd29117c18f452973fed147696b83f1249

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2242

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -1
    • +0
    ./user-defined-functions/udf26/udf26.1.ast
    • -0
    • +0
    ./user-defined-functions/udf26/udf26.2.ast
    • -7
    • +0
    ./user-defined-functions/udf26/udf26.3.ast
  1. … 39 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./aggregate-sql/issue395/issue395.3.ast
  1. … 1502 more files in changeset.
[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Improved name resolution rules

- Resolve field access to the nearest variable in scope

instead of raising compile-time error

- Do not rely on type information when resolving names

- Cleanup group variable handling in GroupBy clause,

no longer use ‘with’ map for it

- Fix ByNameToByIndexFieldAccessRule to use type environment

of its input operator when analyzing its expression

- Fix ExternalGroupByPOperator to use input schema of its

aggregate function when generating runtime for that function

- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2207

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -6
    • +3
    ./fuzzyjoin/dblp-1_2.1.1/dblp-1_2.3.ast
    • -16
    • +5
    ./fuzzyjoin/dblp-2.1_5.3.1/dblp-2.3.ast
    • -10
    • +3
    ./fuzzyjoin/dblp-2_4/dblp-2_4.3.ast
    • -11
    • +3
    ./fuzzyjoin/dblp-2_5.1/dblp-2_5.3.ast
    • -11
    • +3
    ./fuzzyjoin/dblp-2_5.2/dblp-2_5.3.ast
    • -11
    • +3
    ./fuzzyjoin/dblp-2_5.3.1/dblp-2_5.3.ast
    • -11
    • +3
    ./fuzzyjoin/dblp-2_5.3/dblp-2_5.3.ast
  1. … 300 more files in changeset.