Clone Tools
  • last updated 18 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Resolution" rule

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Variables introduced by LET clauses should not be

considered by "Single Variable Resolution" rule

- In INSERT/UPSERT statements with RETURNING expression

the automatically introduced variable should be named

as the target dataset

- Refactor VariableCheckAndRewriteVisitor and

other code related to name resolution

- Added testcases and updated documentation

Change-Id: I9b9f70a1671378f5216ec4e30416d4d67c3df089

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3322

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +31
    ./field_accessor_1/field_accessor_1.1.ddl.sqlpp
    • -0
    • +24
    ./field_accessor_1/field_accessor_1.2.update.sqlpp
    • -0
    • +27
    ./field_accessor_1/field_accessor_1.3.query.sqlpp
    • -0
    • +28
    ./field_accessor_1/field_accessor_1.4.query.sqlpp
    • -0
    • +27
    ./field_accessor_1/field_accessor_1.5.query.sqlpp
    • -0
    • +24
    ./field_accessor_1/field_accessor_1.6.query.sqlpp
    • -0
    • +29
    ./field_accessor_1/field_accessor_1.7.query.sqlpp
    • -0
    • +26
    ./field_accessor_1/field_accessor_1.8.query.sqlpp
    • -0
    • +31
    ./field_accessor_2_negative/field_accessor_2_negative.1.ddl.sqlpp
    • -0
    • +36
    ./field_accessor_2_negative/field_accessor_2_negative.2.update.sqlpp
    • -0
    • +26
    ./field_accessor_2_negative/field_accessor_2_negative.3.query.sqlpp
    • -0
    • +26
    ./field_accessor_2_negative/field_accessor_2_negative.4.query.sqlpp
    • -0
    • +26
    ./field_accessor_2_negative/field_accessor_2_negative.5.query.sqlpp
    • -0
    • +26
    ./field_accessor_2_negative/field_accessor_2_negative.6.query.sqlpp
    • -0
    • +26
    ./field_accessor_2_negative/field_accessor_2_negative.7.query.sqlpp
  1. … 42 more files in changeset.
[ASTERIXDB-2399][SQL][FUN] Rename COLL_ aggregate functions

Rename to COLL_ functions to use the prefix STRICT_ to reduce the

confusion about which functions implement a strict NULL handling.

Change-Id: I5c103dbe7fa42bf5c4e2bfa53592b2041084aa8f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2691

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -1
    • +1
    ./fullyqualified2/fullyqualified2.3.query.sqlpp
  1. … 279 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +33
    ./function_dataverse/function_dataverse.1.ddl.sqlpp
    • -0
    • +23
    ./function_dataverse/function_dataverse.2.update.sqlpp
    • -0
    • +22
    ./function_dataverse/function_dataverse.3.query.sqlpp
    • -0
    • +21
    ./function_dataverse/function_dataverse.4.ddl.sqlpp
    • -0
    • +22
    ./function_dataverse/function_dataverse.5.query.sqlpp
  1. … 1512 more files in changeset.
[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Improved name resolution rules

- Resolve field access to the nearest variable in scope

instead of raising compile-time error

- Do not rely on type information when resolving names

- Cleanup group variable handling in GroupBy clause,

no longer use ‘with’ map for it

- Fix ByNameToByIndexFieldAccessRule to use type environment

of its input operator when analyzing its expression

- Fix ExternalGroupByPOperator to use input schema of its

aggregate function when generating runtime for that function

- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2207

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -1
    • +2
    ./conflict-fields-dataset/conflict-fields-dataset.3.query.sqlpp
    • -0
    • +28
    ./groupby_rename_with_sugar/groupby_rename_with_sugar.1.ddl.sqlpp
    • -0
    • +26
    ./groupby_rename_with_sugar/groupby_rename_with_sugar.2.update.sqlpp
    • -0
    • +25
    ./groupby_rename_with_sugar/groupby_rename_with_sugar.3.query.sqlpp
    • -0
    • +35
    ./order_1/order_1.1.ddl.sqlpp
    • -0
    • +29
    ./order_1/order_1.2.update.sqlpp
    • -0
    • +24
    ./order_1/order_1.3.query.sqlpp
  1. … 308 more files in changeset.
[ASTERIXDB-2050][SQL] Enforce a Semicolon After Each SQL++ Statement

- user model changes: a semicolon must be added after

every SQL++ statement.

- storage format changes: no

- interface changes: no

Details:

- Enforce a semicolon after each SQL++ statement.

- Adapt existing SQL++ test cases to new model.

Change-Id: I27e9e8fde5ff867ab569c8d443ba1522738046e3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1954

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./fullyqualified/fullyqualified.4.ddl.sqlpp
    • -1
    • +1
    ./fullyqualified2/fullyqualified2.4.ddl.sqlpp
  1. … 2076 more files in changeset.
ASTERIXDB-1650: fix undefined variable reference resolution.

The order of resolving a reference to an undefined variable is:

-- If the reference to an undefined variable is the binding expression for FROM/JOIN/UNNEST/Quantifier,

then it can only be resolved to a dataset;

-- Otherwise, it is firstly resolved as a field-access. If the system couldn't find a candidate

field access, it is then resolved to a dataset.

Change-Id: I24e4c1b38e53c97380cfb3e2e9b61cdd05fe7002

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1408

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +31
    ./conflict-field-dataset-from/conflict-field-dataset-from.1.ddl.sqlpp
    • -0
    • +24
    ./conflict-field-dataset-from/conflict-field-dataset-from.2.update.sqlpp
    • -0
    • +25
    ./conflict-field-dataset-from/conflict-field-dataset-from.3.query.sqlpp
    • -0
    • +31
    ./conflict-field-dataset-fromterm/conflict-field-dataset-fromterm.1.ddl.sqlpp
    • -0
    • +24
    ./conflict-field-dataset-fromterm/conflict-field-dataset-fromterm.2.update.sqlpp
    • -0
    • +25
    ./conflict-field-dataset-fromterm/conflict-field-dataset-fromterm.3.query.sqlpp
    • -0
    • +31
    ./conflict-field-dataset-join/conflict-field-dataset-join.1.ddl.sqlpp
    • -0
    • +24
    ./conflict-field-dataset-join/conflict-field-dataset-join.2.update.sqlpp
    • -0
    • +25
    ./conflict-field-dataset-join/conflict-field-dataset-join.3.query.sqlpp
    • -0
    • +31
    ./conflict-field-dataset-quantifier/conflict-field-dataset-quantifier.1.ddl.sqlpp
    • -0
    • +24
    ./conflict-field-dataset-quantifier/conflict-field-dataset-quantifier.2.update.sqlpp
    • -0
    • +25
    ./conflict-field-dataset-quantifier/conflict-field-dataset-quantifier.3.query.sqlpp
    • -0
    • +31
    ./conflict-field-dataset-unnest/conflict-field-dataset-unnest.1.ddl.sqlpp
    • -0
    • +24
    ./conflict-field-dataset-unnest/conflict-field-dataset-unnest.2.update.sqlpp
    • -0
    • +25
    ./conflict-field-dataset-unnest/conflict-field-dataset-unnest.3.query.sqlpp
  1. … 72 more files in changeset.