Clone Tools
  • last updated 16 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2687][RT] Issue a warning when incomparable types are compared

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Issue a warning when NULL was returned as the result of a comparison

of 2 incomparable types.

- added error/warning code 49

- refactored dot format plans generator

- removed some AQL tests that are already covered in SQL++ tests

Change-Id: Iad3127e4db775315817a7819feea6aa12e4de2ea

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4464

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +27
    ./incomparable_types/incomparable_types.001.ddl.sqlpp
    • -0
    • +24
    ./incomparable_types/incomparable_types.002.update.sqlpp
    • -0
    • +26
    ./incomparable_types/incomparable_types.003.query.sqlpp
    • -0
    • +26
    ./incomparable_types/incomparable_types.004.query.sqlpp
    • -0
    • +20
    ./incomparable_types/incomparable_types.005.ddl.sqlpp
  1. … 35 more files in changeset.
[NO ISSUE][TEST] Translated old aql tests to sqlpp

-user model changes: no

-storage format changes: no

-interface changes: no

Details:

-Translated old aql tests to sqlpp and added them to queries_sqlpp

-Added new translated tests to testsuite_sqlpp.xml

Change-Id: Id73f4603898f95ccb05352ab5bc2fb193e421126

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/3946

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@uci.edu>

    • -0
    • +44
    ./circle-point/circle-point.1.ddl.sqlpp
    • -0
    • +28
    ./circle-point/circle-point.2.update.sqlpp
    • -0
    • +27
    ./circle-point/circle-point.3.query.sqlpp
    • -0
    • +26
    ./circle-point/circle-point.4.query.sqlpp
    • -0
    • +26
    ./circle-point/circle-point.5.query.sqlpp
    • -0
    • +24
    ./circle-point/circle-point.6.query.sqlpp
  1. … 256 more files in changeset.
[ASTERIXDB-2516][RT] add support for record deep comparison

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Add support for record deep comparison.

- modified LogicalComplexBinaryComparator to allow record comparison

- added test cases for record comparison

- modified PointableAllocator to allow freeing record visitable pointables

Change-Id: I3e8bfbb014b86295749e980d123b0d3edf079beb

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3222

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

    • -0
    • +29
    ./records/records.001.ddl.sqlpp
    • -0
    • +54
    ./records/records.002.update.sqlpp
    • -0
    • +48
    ./records/records.003.query.sqlpp
    • -0
    • +34
    ./records/records.004.query.sqlpp
    • -0
    • +29
    ./records/records.005.query.sqlpp
    • -0
    • +26
    ./records/records.006.query.sqlpp
    • -0
    • +25
    ./records/records.007.query.sqlpp
    • -0
    • +25
    ./records/records.008.query.sqlpp
    • -0
    • +27
    ./records/records.009.query.sqlpp
    • -0
    • +25
    ./records/records.010.query.sqlpp
    • -0
    • +25
    ./records/records.011.query.sqlpp
    • -0
    • +25
    ./records/records.012.query.sqlpp
    • -0
    • +20
    ./records/records.013.ddl.sqlpp
  1. … 27 more files in changeset.
[ASTERIXDB-2516][RT] add support for array deep comparison

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

Add support for array deep comparison.

- modified LogicalComplexBinaryComparator.java to allow array comparison

- added test cases for array comparison

- changed interface IObjectPool.java to allow freeing a specific object

Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3173

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Michael Blow <mblow@apache.org>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +28
    ./arrays/arrays.001.ddl.sqlpp
    • -0
    • +46
    ./arrays/arrays.002.update.sqlpp
    • -0
    • +58
    ./arrays/arrays.003.query.sqlpp
    • -0
    • +64
    ./arrays/arrays.004.query.sqlpp
    • -0
    • +63
    ./arrays/arrays.005.query.sqlpp
    • -0
    • +40
    ./arrays/arrays.006.query.sqlpp
    • -0
    • +63
    ./arrays/arrays.007.query.sqlpp
    • -0
    • +28
    ./arrays/arrays.008.query.sqlpp
    • -0
    • +27
    ./arrays/arrays.009.query.sqlpp
    • -0
    • +28
    ./arrays/arrays.010.query.sqlpp
    • -0
    • +28
    ./arrays/arrays.011.query.sqlpp
    • -0
    • +28
    ./arrays/arrays.012.query.sqlpp
    • -0
    • +28
    ./arrays/arrays.013.query.sqlpp
    • -0
    • +27
    ./arrays/arrays.014.query.sqlpp
    • -0
    • +27
    ./arrays/arrays.015.query.sqlpp
  1. … 37 more files in changeset.
[ASTERIXDB-2375][RT] Evaluate constant experession in SELECT only once

- user model changes: none

- storage format changes: none

- interface changes: new method added to ComparisonHelper to handle

cached value.

Currently, in datascan case, the constant value is evaluated on per

tuple bases. We could cache the value to avoid the deserialization of

the constant value each time.

Change-Id: Iae4e78928da2bd63b2984b3624b88baed9b7cd73

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2621

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +37
    ./secondary_idx_lookup/secondary_idx_lookup.1.ddl.sqlpp
    • -0
    • +22
    ./secondary_idx_lookup/secondary_idx_lookup.2.query.sqlpp
    • -0
    • +22
    ./secondary_idx_lookup/secondary_idx_lookup.3.query.sqlpp
    • -0
    • +22
    ./secondary_idx_lookup/secondary_idx_lookup.4.query.sqlpp
    • -0
    • +21
    ./secondary_idx_lookup/secondary_idx_lookup.5.query.sqlpp
    • -0
    • +20
    ./secondary_idx_lookup/secondary_idx_lookup.6.update.sqlpp
  1. … 22 more files in changeset.
[ASTERIXDB-2371][FUN] Implement conditional functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Implement the following conditional functions:

null_if(), missing_if(), nan_if(), posinf_if(), neginf_if()

Change-Id: I5399cae1a225b1881d67b87541e46a9d4fe158ec

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2616

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +29
    ./missingif/missingif.1.query.sqlpp
    • -0
    • +24
    ./missingif/missingif.2.query.sqlpp
    • -0
    • +29
    ./nanif/nanif.1.query.sqlpp
    • -0
    • +24
    ./nanif/nanif.2.query.sqlpp
    • -0
    • +29
    ./neginfif/neginfif.1.query.sqlpp
    • -0
    • +24
    ./neginfif/neginfif.2.query.sqlpp
    • -0
    • +29
    ./nullif/nullif.1.query.sqlpp
    • -0
    • +24
    ./nullif/nullif.2.query.sqlpp
    • -0
    • +29
    ./posinfif/posinfif.1.query.sqlpp
    • -0
    • +24
    ./posinfif/posinfif.2.query.sqlpp
  1. … 32 more files in changeset.
[ASTERIXDB-2050][SQL] Enforce a Semicolon After Each SQL++ Statement

- user model changes: a semicolon must be added after

every SQL++ statement.

- storage format changes: no

- interface changes: no

Details:

- Enforce a semicolon after each SQL++ statement.

- Adapt existing SQL++ test cases to new model.

Change-Id: I27e9e8fde5ff867ab569c8d443ba1522738046e3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1954

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./datetime_range/datetime_range.1.ddl.sqlpp
    • -1
    • +1
    ./datetime_range_between/datetime_range_between.1.ddl.sqlpp
  1. … 2076 more files in changeset.
Fix the operator precedence of LIKE.

Change-Id: I0cd4e2910d4055efa6f2d2a6de8b1ef8f67275e5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1456

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -0
    • +20
    ./like/like.1.query.sqlpp
  1. … 3 more files in changeset.
ASTERIXDB-1539: add aliases for several builtin types and builtin functions.

- tinyint for int8;

- smallint for int16;

- integer(or, int) for int32;

- bigint for int64;

- year_month_duration for year-month-duration;

- day_time_duration for day-time-duration;

- timestamp for datetime;

- double precision for double;

int8, int16, int32, int64, year-month-duration and day-time-duration

is going to be deprecated.

In addition, it

- converts underscores to hypens for SQL++ functions;

- uses "array_" prefix for builtin aggregation functions.

Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1199

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -2
    • +2
    ./datetime_range/datetime_range.1.ddl.sqlpp
    • -2
    • +2
    ./datetime_range_between/datetime_range_between.1.ddl.sqlpp
    • -1
    • +1
    ./day_time_duration_order/day_time_duration_order.1.ddl.sqlpp
    • -1
    • +1
    ./day_time_duration_order/day_time_duration_order.2.update.sqlpp
    • -5
    • +5
    ./day_time_duration_order/day_time_duration_order.3.query.sqlpp
    • -1
    • +1
    ./int16_missing/int16_missing.1.query.sqlpp
    • -1
    • +1
    ./int32_missing/int32_missing.1.query.sqlpp
    • -1
    • +2
    ./int64_missing/int64_missing.1.query.sqlpp
  1. … 3547 more files in changeset.
ASTERIXDB-1652: fix dataverse.function(...) to check the existence of the dataverse.

Change-Id: I7779db56f540fdd645bb85c769baeaa37f620a0d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1192

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -1
    • +1
    ./binary_null/binary_null.1.query.sqlpp
    • -1
    • +1
    ./int64_missing/int64_missing.1.query.sqlpp
  1. … 11 more files in changeset.
Add <> as a synonym to !=.

Change-Id: I3c670cf3d0e53725dce8ef2acb33970f8030a0a8

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1180

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +23
    ./neq_02/neq_02.3.query.sqlpp
  1. … 2 more files in changeset.
Add the BETWEEN operator.

Change-Id: I5df7370154aa30db7547f7fd47ea69b5b76dcf49

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1143

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +35
    ./datetime_range_between/datetime_range_between.1.ddl.sqlpp
    • -0
    • +25
    ./datetime_range_between/datetime_range_between.2.update.sqlpp
    • -0
    • +27
    ./datetime_range_between/datetime_range_between.3.query.sqlpp
    • -0
    • +23
    ./int_not_between/int_not_between.3.query.sqlpp
  1. … 7 more files in changeset.
Add several builtin functions.

- add functions such as greatest, least, concat(||), initcap(title),

regexp_contains, regexp_like, regexp_position, regexp_replace, ltrim,

trim, rtrim, position;

- refactor string functions;

- remove undocumented function "regexp", which is equivalent to "matches";

- remove AQL.html and SQLPP.html since they are generated in "target/".

Change-Id: I26351af22f67d66b56176f55b29a4e7ff63583f7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1104

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +21
    ./greatest_mixed/greatest_mixed.3.query.sqlpp
    • -0
    • +21
    ./least_mixed/least_mixed.1.query.sqlpp
  1. … 91 more files in changeset.
Renaming: "table"->"dataset", "database"->"dataverse".

Change-Id: Ia80193f08651fc99341d9a8cf156d0feb6d0575f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1036

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./datetime_order/datetime_order.1.ddl.sqlpp
    • -3
    • +3
    ./datetime_range/datetime_range.1.ddl.sqlpp
    • -1
    • +1
    ./datetime_range/datetime_range.2.update.sqlpp
    • -2
    • +2
    ./datetime_tzeq/datetime_tzeq.1.ddl.sqlpp
    • -2
    • +2
    ./day_time_duration_order/day_time_duration_order.1.ddl.sqlpp
    • -2
    • +2
    ./double_gte_01/double_gte_01.1.ddl.sqlpp
  1. … 2760 more files in changeset.
ASTERIXDB-1223: let incompatiable comparisons return null.

- make null/missing/true/false case-insensitive;

- add tests for incompatible comparisons;

- add tests for group-by/order-by with MISSING valued keys.

Change-Id: I8130d505f810631231d3755941ce4de64313501b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/912

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +29
    ./incompatible/incompatible.1.query.sqlpp
  1. … 17 more files in changeset.
Use backticks instead of double quotes for delimited identifiers in SQL++.

Change-Id: I2db58d68e8e28befa4105504c261b101fa0285af

Reviewed-on: https://asterix-gerrit.ics.uci.edu/909

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -1
    • +1
    ./datetime_range/datetime_range.2.update.sqlpp
    • -4
    • +4
    ./day_time_duration_order/day_time_duration_order.3.query.sqlpp
    • -4
    • +4
    ./issue363_equality/issue363_equality.3.query.sqlpp
    • -4
    • +4
    ./year_month_duration_order/year_month_duration_order.3.query.sqlpp
  1. … 2129 more files in changeset.
Supports Left Outer Join and Left Outer Unnest in SQL++.

- change record format to allow MISSING value for an optional field;

- support roundtrips of MISSING valued closed fields for load and insert;

- suppress fields with MISSING values in result printer;

- fix ByNameToByIndexFieldAccessRule and LoadRecordFieldsRule;

- update test queries and results.

Change-Id: Ie0caea9c1842d93541b067a1193d117af30d8dfc

Reviewed-on: https://asterix-gerrit.ics.uci.edu/899

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -0
    • +21
    ./binary_missing/binary_missing.1.query.sqlpp
    • -22
    • +0
    ./binary_null/binary_null.1.ddl.sqlpp
    • -0
    • +21
    ./binary_null/binary_null.1.query.sqlpp
    • -19
    • +0
    ./binary_null/binary_null.2.update.sqlpp
    • -23
    • +0
    ./binary_null/binary_null.3.query.sqlpp
    • -0
    • +21
    ./double_missing/double_missing.1.query.sqlpp
    • -22
    • +0
    ./double_null/double_null.1.ddl.sqlpp
    • -0
    • +21
    ./double_null/double_null.1.query.sqlpp
    • -19
    • +0
    ./double_null/double_null.2.update.sqlpp
    • -23
    • +0
    ./double_null/double_null.3.query.sqlpp
    • -0
    • +21
    ./float_missing/float_missing.1.query.sqlpp
    • -22
    • +0
    ./float_null/float_null.1.ddl.sqlpp
    • -0
    • +21
    ./float_null/float_null.1.query.sqlpp
    • -19
    • +0
    ./float_null/float_null.2.update.sqlpp
    • -23
    • +0
    ./float_null/float_null.3.query.sqlpp
  1. … 571 more files in changeset.