Clone Tools
  • last updated 16 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NO ISSUE] Support multipart dataverse names

- user model changes: yes

- storage format changes: no

- interface changes: yes

Details:

- Support dataverse names that consist of multiple parts

- Introduce DataverseName class and adopt it throughout the system

- Add testcases for multipart dataverse names

Change-Id: I1313b2dc0e8df6a9b0ded48dea122afc3ba5dbe7

Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4004

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

  1. … 284 more files in changeset.
[NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- VariableCheckAndRewriteVisitor should create FieldAccessor

expressions when resolving identifiers as field accessors.

Currently it produces an internal function call in these cases.

FieldAccessor expressions will be converted into internal

function calls later by LangExpressionToPlanTranslator.

Change-Id: Icaab2a29f787439eebd67e44aa6a9e92df422a98

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3343

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -2
    • +2
    ./btree-index-join/secondary-equi-join_06.ast
  1. … 43 more files in changeset.
[ASTERIXDB-2272][FUN] Count character positions from 0

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Count character positions in strings, binary from 0 instead of 1

- Affects following built-in functions:

position(), regexp_position(), substr()/subtring(),

sub_binary(), find-binary()

- Introduce new configuration property “compiler.stringoffset”

for backward compatibility

compiler.stringoffset = 0 - count from 0 (new default)

compiler.stringoffset = 1 - count from 1 (backwards-compatible setting)

Change-Id: Icdb2c241983d5f592b2695ef16eae9951518d7fd

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2342

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 108 more files in changeset.
[ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- When compiling user-defined function set default dataverse

to be the function's dataverse to correclty resolve dataset

accesses within that function

- Fix incorrect interpretation of quoted dataset names

FROM `a.b` now means FROM default_dataverse.`a.b`

(previously it meant FROM `a`.`b`)

Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2236

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.ast
    • -2
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_03.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_03.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_04.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_05.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_06.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-multipred.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_03.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_04.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_05.ast
  1. … 1502 more files in changeset.
[ASTERIXDB-2170][SQL] Fix resolution order of implicit field access

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Improved name resolution rules

- Resolve field access to the nearest variable in scope

instead of raising compile-time error

- Do not rely on type information when resolving names

- Cleanup group variable handling in GroupBy clause,

no longer use ‘with’ map for it

- Fix ByNameToByIndexFieldAccessRule to use type environment

of its input operator when analyzing its expression

- Fix ExternalGroupByPOperator to use input schema of its

aggregate function when generating runtime for that function

- Fix invalid free variable computation for GroupBy clause

Change-Id: I50bc823ff53da06507a5454b30f4f500b862d4bf

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2207

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -6
    • +6
    ./btree-index-join/secondary-equi-join_06.ast
    • -2
    • +2
    ./inlined_q18_large_volume_customer.ast
    • -38
    • +49
    ./q01_pricing_summary_report_nt.ast
  1. … 300 more files in changeset.
[NO ISSUE][COMP] Function references cleanup

- user model changes: no

- storage format changes: no

- interface change: no

Details: cleanup function references

- Use function identifiers when referring to built-in functions

- Use OperatorType enum when referring to operators

- Add FunctionSignature constructor that takes FunctionIdentifier

- Use asterix/algebricks namespace when referring to built-in functions

Change-Id: Ibad290182ed0f248f65987df97e6c61aac95b232

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2130

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ian Maxon <imaxon@apache.org>

Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>

    • -2
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.ast
    • -2
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-join_03.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_03.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_04.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_05.ast
    • -2
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_06.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-multipred.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-neg_01.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-neg_02.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_01.ast
  1. … 1569 more files in changeset.
[ASTERIXDB-2015][IDX] Introduce Primary Index Optimization Rule

- user model changes: no

- storage format changes: no

- interface changes: no

details:

This is the optimization rule that will optimize aggregation queries

when only PKs are involved. The rule will use the primary index and

replace the dataset scan or unnest-map operator.

Change-Id: I3bbb2b5e1f25e61928d73b866e91c592ce0bf954

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2111

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +30
    ./btree-index/btree-secondary-64.ast
    • -0
    • +39
    ./btree-index/btree-secondary-65.ast
    • -0
    • +36
    ./btree-index/btree-secondary-66.ast
    • -0
    • +36
    ./btree-index/btree-secondary-67.ast
  1. … 30 more files in changeset.
[ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Let the IntroduceJoinAccessMethod accept arbitrary

forms of sub-tree for the probe-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26

Reviewed-on: https://asterix-gerrit.ics.uci.edu/2030

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

    • -0
    • +53
    ./btree-index-join/secondary-equi-join_04.ast
    • -0
    • +33
    ./btree-index-join/secondary-equi-join_05.ast
    • -0
    • +66
    ./btree-index-join/secondary-equi-join_06.ast
  1. … 7 more files in changeset.
[ASTERIXDB-2078][SQL] DISTINCT modifier for aggregate functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Adds support for DISTINCT modifier in aggregate functions:

AGG(DISTINCT expr), ARRAY_AGG(DISTINCT expr), COLL_AGG(DISTINCT expr)

where AGG = COUNT | SUM | AVG | MIN | MAX

Change-Id: I52772349cbcbfc68a3a1ff261d610871ca38748d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1987

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./inlined_q18_large_volume_customer.ast
  1. … 347 more files in changeset.
[ASTERIXDB-1753][SQL] Disable auto-plural for group-by.

- user model changes: do not perform auto-scalar-to-plural

transition for variables that are defined prior to a group-by

group clause after the group-by clause.

- storage format changes: no

- interface changes: no

details:

- migrated existing test queries that use auto-plural;

- added a negative test query.

Change-Id: I5d6383fc7453fe7537fc291c3483708b59df3871

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1860

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

    • -2
    • +6
    ./inlined_q18_large_volume_customer.ast
    • -8
    • +27
    ./q01_pricing_summary_report_nt.ast
  1. … 248 more files in changeset.
ASTERIXDB-1650: fix undefined variable reference resolution.

The order of resolving a reference to an undefined variable is:

-- If the reference to an undefined variable is the binding expression for FROM/JOIN/UNNEST/Quantifier,

then it can only be resolved to a dataset;

-- Otherwise, it is firstly resolved as a field-access. If the system couldn't find a candidate

field access, it is then resolved to a dataset.

Change-Id: I24e4c1b38e53c97380cfb3e2e9b61cdd05fe7002

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1408

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

BAD: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -5
    • +26
    ./split-materialization-above-join.ast
  1. … 82 more files in changeset.
ASTERIXDB-1539: add aliases for several builtin types and builtin functions.

- tinyint for int8;

- smallint for int16;

- integer(or, int) for int32;

- bigint for int64;

- year_month_duration for year-month-duration;

- day_time_duration for day-time-duration;

- timestamp for datetime;

- double precision for double;

int8, int16, int32, int64, year-month-duration and day-time-duration

is going to be deprecated.

In addition, it

- converts underscores to hypens for SQL++ functions;

- uses "array_" prefix for builtin aggregation functions.

Change-Id: I5c4a933f9775e89c2d503d9ea1cb98c5934d1475

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1199

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

    • -6
    • +6
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.ast
    • -6
    • +6
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.ast
    • -6
    • +6
    ./btree-index-join/primary-equi-join-multipred.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-neg_01.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join-neg_02.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-equi-join_02.ast
    • -6
    • +6
    ./btree-index-join/primary-equi-join_03.ast
    • -6
    • +6
    ./btree-index-join/primary-equi-join_04.ast
    • -4
    • +4
    ./btree-index-join/primary-equi-join_05.ast
    • -2
    • +2
    ./btree-index-join/primary-ge-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-ge-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-gt-join_01.ast
    • -2
    • +2
    ./btree-index-join/primary-gt-join_02.ast
    • -2
    • +2
    ./btree-index-join/primary-le-join_01.ast
  1. … 3547 more files in changeset.
Clean up GROUP BY and WITH clause.

- fix ASTERIXDB-971, i.e., the expression to plan translator for FLWOGR without a "for";

- fix the scoping for nested WITH clause;

- fix the scoping for nested GROUP BY clause;

- fix default fields in group variables;

- fix/unify the expression substition AST visitor;

- enhance RemoveUnusedAssignAndAggregateRule to be able to remove unused GROUP BY

decoration varaibles;

- clearly sperate SQL++ aggregate functions and SQL-92 aggregate functions, i.e.,

SQL-92 aggregate sugars cannot apply to SQL++ aggregate functions;

- fix PushAggregateIntoGroupbyRule for nested plan deletions;

- enhance RemoveCartesianProductWithEmptyBranchRule;

- add ExtractGroupByDecorVariablesRule;

- add an aggregate function first-element;

- fix ASTERIXDB-1560, an error message issue.

Change-Id: I62fca7f937aa007d97ed87c75cef19f6aa3e5ade

Reviewed-on: https://asterix-gerrit.ics.uci.edu/1050

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -5
    • +3
    ./inlined_q18_large_volume_customer.ast
    • -11
    • +1
    ./q01_pricing_summary_report_nt.ast
  1. … 221 more files in changeset.
Add IS (NOT) NULL/MISSING/UNKOWN.

Change-Id: I7e4008d97f0d3a92816b90492dd8c887b05bac27

Reviewed-on: https://asterix-gerrit.ics.uci.edu/963

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Yingyi Bu <buyingyi@gmail.com>

  1. … 43 more files in changeset.
Let SQL-92 aggregate functions behave the same as SQL-92.

Change-Id: Ia2929d1ca6344508bbf772884ea8ef1f39a0e19f

Reviewed-on: https://asterix-gerrit.ics.uci.edu/857

Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -2
    • +2
    ./split-materialization-above-join.ast
  1. … 86 more files in changeset.
ASTERIXDB-1383: reduce the number of lines for "AS".

Change-Id: Ic655bf25701f33230787d175b78bedc489909cb0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/822

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

    • -4
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01.ast
    • -4
    • +2
    ./btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-join_01.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-join_02.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-join_03.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_01.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_02.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_03.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_04.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_05.ast
    • -4
    • +2
    ./btree-index-join/primary-composite-key-prefix-join_06.ast
    • -4
    • +2
    ./btree-index-join/primary-equi-join-multipred.ast
    • -4
    • +2
    ./btree-index-join/primary-equi-join-neg_01.ast
    • -4
    • +2
    ./btree-index-join/primary-equi-join-neg_02.ast
    • -4
    • +2
    ./btree-index-join/primary-equi-join_01.ast
  1. … 1705 more files in changeset.