asterixdb

Clone Tools
  • last updated 17 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

ARecordVisitablePointable writes field names, field tags, and field values

first before giving access to the record information. This is not ideal for

comparison. A different record accessor is needed for comparison. Also, the

field names should be sorted which ARecordVisitablePointable does not provide.

- avoid this writing when a pointable to the name & value can be obtained

(especially when the field value already includes the tag)

- use UTF8Pointable cached values (string length, meta length) to compare

instead of using the string comparator which would recalculate these values

- refactored some common code.

- removed not used methods in ARecordPointable

Change-Id: I19ac95a91749b2983bf06f763e463521a97a261c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3280

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][OTH] Redact syntax error messages

- user model changes: no

- storage format changes: no

- interface changes: no

Redact syntax error messages in the grammar file.

Change-Id: I41143377689488ef9c05dc5b3650fc62a3a5420e

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3282

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][FUN] Remove AST tests for statistical functions

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Remove AST tests for statistical functions

Change-Id: Ided329f38df568a32d2e8bca8f6125c23c04a07b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3279

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 610 more files in changeset.
[NO ISSUE][TYPE] Avoid 'null' collection types

- user model changes: no

- storage format changes: no

- interface changes: no

Change-Id: Id7ab2a20e776152ecf35d5bd01b1eded7e987e26

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3247

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[NO ISSUE][FUN] Add aliases for stddev_*(), var_*() functions

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

- Support aliases for SQL aggregate functions

- Add function aliases: stddev() -> stddev_samp(),

variance() -> var_samp(), variance_samp() -> var_samp(),

variance_pop() -> var_pop()

- stddev_pop() and var_pop() must return 0 if input is a single item

Change-Id: I0fe04164164726cfb4e17f951f0fd6c2a823c162

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3278

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

  1. … 19 more files in changeset.
[NO ISSUE][OTH] Introduce NC CacheManager

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

- Introduce NC CacheManager that can be used to cache

values and reevaluate them based on cache policy.

- Add test case for CacheManager.

Change-Id: I8cba7753af11469e8a45cb1d59dfd70c17cd05f6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3277

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

[NO ISSUE][FUN] Cleanup function name reporting in error messages

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Pass function identifier to exception constructors, so function name

can be extracted by the constructor code

- Deprecate exception constructors that expect function name directly

Change-Id: If40e115db5482b255595e1a651b99c5d7b53712a

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3273

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 42 more files in changeset.
[NO ISSUE][RT] Eliminate Excessive Object Creation in Sort Merge

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Currently, every binary search for frame lookup during

the sort merge phase results in auto-boxing to an Integer.

In addition, every call to InnerFrameInfo#compareTo during

the binary search results another auto-boxing. This change

eliminates these objects creation by using a MutableInt and

and using a primitive int comparison while comparing.

Change-Id: I72b498d476d242f85966caf67d2543978e5c88bb

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3276

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[ASTERIXDB-2516][COMP] Avoid writing into buffer when comparing numbers

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Avoid writing into buffer when comparing and promoting between numbers.

- made seed the initial hash for arrays and records.

- renamed & refactored LogicalComparatorUtil to share code between logical

and physical comparators

- minor code clean-ups

Change-Id: Ie089d386a9ab8271f2833c05ffdfb0d484937b51

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3272

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

Reviewed-by: Till Westmann <tillw@apache.org>

[NO ISSUE][HYR] Log thread dump at shutdown at DEBUG level

Change-Id: I29b3e01caa5b8747163fb6b2dbcee268549455c6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3275

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[NO ISSUE][HYR] EnsureAllCcTasksCompleted failure handling

Don't halt on interrupt while waiting for aborted cc tasks to complete,

or on interrupt while notifying cc of success of the completion

Change-Id: I02819afcb80a0bcd645c3f79950c3fa12dba0274

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3274

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

[ASTERIXDB-2530][COMP] Error computing type for numeric add

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fixed type computation for numeric add when first argument

is of type ANY and second argument is of a temporal type

Change-Id: I4beac66a6a71179bb3214d27a820f3306533b03c

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3271

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE][COMP] Documenting BreakSelectIntoConjunctsRule

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Added documentation for BreakSelectIntoConjunctsRule.

- Renamed some variables for easier readability and maintenance.

- No actual code/logic changes.

Change-Id: Iadc5dc41115f91caa835255396969eaf47e1356d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3230

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE][*DB] Remove statement as request body

Remove the undocumented ability to treat request body as

statement, if a statement parameter is not otherwise supplied

Change-Id: I566a0c2deaf29e6da0d4dabf9d9de3bfd60da8d6

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3267

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

[ASTERIXDB-2459][FUN] Add skewness and kurtosis aggregate function

- user model changes: yes

- storage format changes: no

- interface changes: no

Details:

1. Add skewness and kurtosis function and test cases

2. Add skewness and kurtosis distinct functions

3. Add documentation for skewness and kurtosis

4. Cleaned up some files related to the stddev and var tests cases

5. Change stddev() to stddev_samp() and var() to var_samp()

Change-Id: Iae0d7fc9d5ab3676b23b27ad62a730598221d8a5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3037

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

  1. … 1330 more files in changeset.
Merge "Merge commit 'ac5b498' from 'stabilization-f69489' into 'master'"

[NO ISSUE][FUN] Fix type inference in JListAccessor

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

As the list element type is available, there is no need to deserialize

element types from the data. Doing so, for example, will cause the

object type to be fully open type and closed fields to be recognized as

open fields. This will further cause NPE in UDFs. Modified the upperCase

test case to check this issue.

Change-Id: I4f437857779e5c0af175c695938fbd7208da244d

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3264

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[ASTERIXDB-2529][COMP] Incorrect result with MISSING field value

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fixed StaticTypeCastUtil.staticRecordTypeCast() to

correctly handle MISSING fields in record constructors

Change-Id: I5d3435274ebf0007fe7e63b86264337072fd8305

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3269

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[NO ISSUE] Add API to override log level on halt

Change-Id: Ia5574d5f51c23f6972c5f086938f355a0b55d007

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3268

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Tested-by: Michael Blow <mblow@apache.org>

Merge commit 'ac5b498' from 'stabilization-f69489' into 'master'

Change-Id: Iaf16894f0628189e3d2de685f2b3f132c65baff3

[NO ISSUE][HTTP] Character encoding fixes

- Support alternate charset for application/x-www-form-urlencoded requests

- Use a random charset in TestExecutor for each query request

Change-Id: I4a982f7c6c34bb32652c1bdd9b546780a2d967d0

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3265

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Murtadha Hubail <mhubail@apache.org>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

[NO ISSUE][COMP] Refactor function lookup in expression translator

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Move function lookup code in LangExpressionToPlanTranslator

into a separate method so it can be modified by product extensions

Change-Id: I917665fd631b220daa6fe7436288193b0dec60b4

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3258

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[ASTERIXDB-2516][COMP] Change logical comparator interface

- user model changes: no

- storage format changes: no

- interface changes: yes

Details:

Use IPointable instead of bytes, offset, and length.

Change-Id: I8150ccb4b18550fd8fba10ffca9c88d45ebc625b

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3263

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

Merge commit 'ffe8fe6' from 'stabilization-f69489' into 'master'

Change-Id: I4783b5ee835f3c571bb39c2d7a1de0e3758dfd56

[ASTERIXDB-2551][*DB] Use Ordered Property in range merge POperator

- user model changes: no

- storage format changes: no

- interface changes: no

details:

- Create the IPartitioningProperty using the orderedPartitionedProperty

instead of creating the list to be used in an unorderedPartitionProperty.

Change-Id: I044e2219fff7564864f68fa0df849d1102b4bb20

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3261

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[ASTERIXDB-2516][COMP] Change logical comparators handling of null/missing

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

Change the result of comparing against null and missing.

For arrays, comparing against null or missing item will result in incomparable.

For records, comparing against a null field will result in incomparable.

- modified test cases accordingly

- moved few object factories to the common place.

- modified compareRecords to avoid string construction for field names

- few code clean-ups.

Change-Id: Id93bea76e13658768e08a98fd373c71a901ceec5

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3259

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[NO ISSUE][OTH] Allow Binding HTTP Server to Specific Address

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Allow binding HTTP server to specific network address

rather than always defaulting it to all network interfaces.

Change-Id: Ie4b6c66502aacf8e0564cc3c6e2fd20c4efac385

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3260

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Till Westmann <tillw@apache.org>

[ASTERIXDB-2528][COMP] Fix illegal state exception in the compiler

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fix illegal state exception raised by the compiler when

a variable used by SQL aggregate function is not mapped

by GROUP AS clause

Change-Id: I12bab27ad8e25d0bd55c900e559541eff2141fb9

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3257

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Contrib: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

[ASTERIXDB-2527][COMP] Fix illegal state error

- user model changes: no

- storage format changes: no

- interface changes: no

Details:

- Fix Illegal State error raised by the compiler

for a query with a quantified expression

Change-Id: I53046ffd104035e36395e8a0fa4c624ccfdedf09

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3253

Reviewed-by: Ali Alsuliman <ali.al.solaiman@gmail.com>

Tested-by: Dmitry Lychagin <dmitry.lychagin@couchbase.com>

[ASTERIXDB-2491][TXN] Recovery fixes

- user model changes: no

- storage format changes: yes[1]

- interface changes: no

Details:

- Change field offset type from integer16 to integer32

- Add recovery test

- Add version to log entries

[1] LogRecord format change with this patch; old LogRecord format can still

be processed, however old instances cannot read new log format

Change-Id: Iaf14b9a73a0239763bfeb0ce2d81cf952e6d72d3

Reviewed-on: https://asterix-gerrit.ics.uci.edu/3065

Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>

Reviewed-by: Michael Blow <mblow@apache.org>

  1. … 11 more files in changeset.