Trafodion

Clone Tools
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LP 1444044, dup col definitions are not detected

During a create table or create view, duplicate col

names are not being detected and an error is not being

returned. This results in an incorect table or view

being created. An error may or may not be returned

later depending on how that object is being used.

That has been fixed to detect dup cols and return an

error message during create time.

Fixing it now so users dont create incorrect objects

by mistake.

Change-Id: I7ad772adcb067159ab80a487dead8dffc62bb546

    • -0
    • +14
    /sql/sqlcomp/CmpSeabaseDDLcommon.cpp
Fix for bug 1442932 and bug 1442966, encoding for varchar

Submitting this before finishing regressions on workstation, in the

interest of time.

Key encodings for VARCHAR values used to put a varchar length indicator

in front of the encoded value. The value was the max. length of the

varchar and the indicator was 2 or 4 bytes long, depending on the

length of the indicator in the source field. That length used to

depend only on the max number of bytes in the field, for >32767

bytes we would use a 4 byte VC length indicator.

Now, with the introduction of long rows, the varchar indicator length

for varchars in aligned rows is always 4 bytes, regardless of the

character length. This causes a problem for the key encoding.

We could have computed the encoded VC indicator length from the field

length. Anoop suggested a better solution, not to include the VC

indicator at all, since that is unnecessary. Note that for HBase row

keys stored on disk, we already remove the VC indicator by converting

such keys from varchar to fixed char. Therefore, the issue happens

only for encoding needed in a query, for example when sorting or in a

merge join or union.

Description of the fix:

1. Change CompEncode::synthType not to include the VC length

indicator in the encoded buffer. This change also includes

some minor code clean-up.

2. Change the assert in CompEncode::codeGen not to include the

VC indicator length anymore.

3. Changes in ex_function_encode::encodeKeyValue():

a) Read 2 and 4 byte VC length indicators for VARCHAR/NVARCHAR.

b) Small code cleanup, don't copy buffer for case-insensitive

encode, since that is not necessary.

c) Don't write max length as VC length indicator into target

and adjust target offsets accordingly (for VARCHAR/NVARCHAR).

4. Other changes in sql/exp/exp_function.cpp:

d) Handle 2 and 4 byte VC len indicators in hash function

and Hive hash function (problems unrelated to LP bugs fixed).

e) Add some asserts for cases where we assume VC length indicator

is a 2 byte integer.

CompDecode is not yet changed. Filed bug 1444134 to do that for

the next release, since that change is less urgent.

Patch set 2: Copyright notice changes only.

Patch set 3: Updated expected regression test file that

prints out encoded key in hex.

Change-Id: Idab3ed488f8c1b9aabedba4689bfb8d7286b9538

    • -18
    • +18
    /sql/regress/charsets/EXPECTED001
refactor gomon.cold.

remove obsolete parts of sqstart.

LP 1442730 Eliminating SQL Cancel for PUBLISHING Queries

In Publishing Thread added "CQD DETAILED_STATISTICS 'OFF'"

Change-Id: Ica8c5e3e339deb33ce0a10db14275e9dc0d19dc4

    • -2
    • +25
    /conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp
LP 1442730 Eliminating SQL Cancel for PUBLISHING Queries

DCSMaster checks if OID ends with text "_PUBLISHING" and if yes, ignores

SQL Cancel

Patch #1

Fixed reported problems

Change-Id: I4b913517f5cbb20bfca203c6f9bfa9fa9abd5047

remove obsolete.

    • -169
    • +1
    /sqf/sql/scripts/sqconfig.sample
obsolete.

Qualify percomstart.

refactor lobstart - phase I.

    • -0
    • +48
    /sqf/sql/scripts/percomstart
remove extraneous from gensq.pl/sqconfig.

hive/test002 fix

This fix is related to "additional changes to support ALIGNED row format."

OFFSET_SIZE in ExpAlignedFormat.h changed from 2 to 4 bytes.

Change-Id: I941a692e602f103f4234a7a8b5d3a8e9a24ad739

Merge "LP Bug 1442949"

Temporary fix for LP bug 1438372

Hold and set CQD optimization_level to 3 during DDL query compilation

when hash joins and merge joins are turned off. This is to prevent the

optimization level set by user to other than 3 (maximum) to affect

meta-data queries. In the future, any secondary compiler won't get any

user CQDs, thus this is temporary fix as work-around.

Change-Id: Idc36d3e98f7729937e6c8a16ab95a41f68c8823d

LP Bug 1442949

-- alter add col was not running under an internal Xn.

that caused rollback to not work.

-- change to allow internal cleanup command to proceed if

running under a transaction. This is needed for internal

cleanups after error.

-- better error msg if index population fails.

Change-Id: I0fd85be97a2ab96544cd037f920df0a3f5868542

    • -0
    • +11
    /sql/sqlcomp/CmpSeabaseDDLindex.cpp
    • -51
    • +0
    /sql/sqlcomp/CmpSeabaseDDLtable.cpp
Updated expected results for fullstack2/TEST062

The release version for fullstack2 test TEST062 was incorrect. Updated

expected results.

Change-Id: I82d46babf621cc20329aa0dc5f34e9c2ec38a560

Fix for bug 1443561

SQL plan collection enabled by default now.

Fixes bug 1443561

Change-Id: Ibc9cb9e41d37a384a6f0bf4cb34c625ea0a98dd7

Fix for bug 1443561

SQL plan collection enabled by default now.

Fixes bug 1443561

Change-Id: Ibc9cb9e41d37a384a6f0bf4cb34c625ea0a98dd7

Fix for ssh redirect bug

Removed output redirection

Change-Id: I86ee98d8a7e6ce6b36739ced2f36c770459d5c50

Merge "DDL Transactions,drop end to end & prepareCommit"

Merge "Changes to reduce the memory growth/leak in mxosrvr and T2 driver"

    • -54
    • +500
    /sql/executor/HBaseClient_JNI.cpp
DDL Transactions,drop end to end & prepareCommit

Change-Id: I69b1d6b3babcaf61761c821bac091fd2101be729

Merge "Transactional DDL, Drop Table functionality"

Merge "additional changes to support ALIGNED row format."

Merge "Correct expected SSCCC return val on stateless put"

Merge "Alternate local-io signaling for use in JVM."

Fix Phoenix T2 CLASSPATH issue and enhance phoenix_test.py

* Fix problem with wrong classpath being generated for Phoenix T2.

This is causing tests to core and/or run into Error 201.

* Added option (--nomvntest) to run the tests without Maven. However

Maven is still used for downloading dependencies and compiling.

This option is mostly to help with debugging.

* Added option (--mvnlocalrepo) to change which directory

Maven uses for its local repository

* Copy Maven error log to phoenix working directory so it can be

saved off later

* Change Maven Surefire configuration option for T2

Change-Id: I34abacb37da55c67da7eaaccaf32fb8cc04f5e92

Closes-Bug: 1403353, 1436995

Merge "Fix for bug 1441932 TMUDF: setLong() trouble handling decimal"

additional changes to support ALIGNED row format.

This feature is not externalized yet.

Change-Id: Idbf19022916d437bb7bb69019194de5057cbcb65

    • -111
    • +65
    /sql/executor/ExHbaseAccess.cpp
    • -513
    • +273
    /sql/regress/seabase/EXPECTED010
  1. … 7 more files in changeset.
Removed check for period in FQDN

When property dcs.dns.interface is specified some systems return

only the short DNS name. DCS assume that returned name always

contains at least one "." This caused a null value to be inserted

into zookeeper nodes for the hostname.

closes bug: #1442402

Change-Id: Idb9abd3c63bba1293adb4797902f7128e3c3f07c