Complete the upgrade of array insert/delete functions.
For issue #4840 "Merge assertion failure in svn_sort__array_insert".
This changes all remaining callers, in other areas of Subversion, to use the new array insert/delete functions that return standard Subversion errors if inputs are out of bounds, and removes the old versions of those functions. These are private functions so the public API is not affected.
* subversion/include/private/svn_sorts_private.h * subversion/libsvn_subr/sorts.c (svn_sort__array_insert, svn_sort__array_delete): Remove. (svn_sort__array_insert2, svn_sort__array_delete2): Rewrite as the only version, instead of calling the old version. No functional change.