Fix a bug in the legacy recursive commit support, which in most cases would have always disabled the recursive commit logic.
* subversion/libsvn_wc/adm_ops.c (process_committed_internal): Properly detect when to recurse.
* subversion/tests/libsvn_wc/wc-test.c (test_legacy_commit1): Remove intermediate state test, as that now would fail now. (test_legacy_commit2): New function. Testing the slightly newer but also long deprecated commit support used around 1.6. (test_funcs): Add test.
Rename a few members of a private commit struct. Reverse a few booleans to make it clearer how they are handled.
There should be no functional changes, although a few variables have different values.
* subversion/libsvn_wc/adm_ops.c (committed_queue_item_t): Update a few member names. Add more documentation. (process_committed_leaf, process_committed_internal): Rename arguments to match committed_queue_item_t.
(svn_wc_queue_committed4): Update initialization. Update caller. (svn_wc_process_committed_queue2): Update usage. Remove bail out as the post processing that could be optimized is gone.